Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment
       [not found] <20260616000135.62815-1-enelsonmoore@gmail.com>
@ 2026-06-23  7:40 ` David Hildenbrand (Arm)
  2026-06-29 10:25 ` Lorenzo Stoakes
  1 sibling, 0 replies; 2+ messages in thread
From: David Hildenbrand (Arm) @ 2026-06-23  7:40 UTC (permalink / raw)
  To: Ethan Nelson-Moore, linux-kernel, linux-mm
  Cc: Muchun Song, Oscar Salvador, Lorenzo Stoakes, Andrew Morton,
	Pedro Falcato, Anthony Yznaga

On 6/16/26 02:01, Ethan Nelson-Moore wrote:
> A comment in <linux/hugetlb_cgroup.h> incorrectly refers to
> CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel,
> instead of CONFIG_CGROUP_HUGETLB. Correct it.
> 
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
>  include/linux/hugetlb_cgroup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
> index e5d64b8b59c2..16d72c8c71f6 100644
> --- a/include/linux/hugetlb_cgroup.h
> +++ b/include/linux/hugetlb_cgroup.h
> @@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
>  {
>  }
>  
> -#endif  /* CONFIG_MEM_RES_CTLR_HUGETLB */
> +#endif  /* CONFIG_CGROUP_HUGETLB */
>  #endif

Right, commit 2bc64a204697 ("mm/hugetlb: add new HugeTLB cgroup") introduced
that. Probably a leftover after reworks.

Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment
       [not found] <20260616000135.62815-1-enelsonmoore@gmail.com>
  2026-06-23  7:40 ` [PATCH] mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment David Hildenbrand (Arm)
@ 2026-06-29 10:25 ` Lorenzo Stoakes
  1 sibling, 0 replies; 2+ messages in thread
From: Lorenzo Stoakes @ 2026-06-29 10:25 UTC (permalink / raw)
  To: Ethan Nelson-Moore
  Cc: linux-kernel, linux-mm, Muchun Song, Oscar Salvador,
	David Hildenbrand, Andrew Morton, Pedro Falcato, Anthony Yznaga

On Mon, Jun 15, 2026 at 05:01:31PM -0700, Ethan Nelson-Moore wrote:
> A comment in <linux/hugetlb_cgroup.h> incorrectly refers to
> CONFIG_MEM_RES_CTLR_HUGETLB, which has never existed in the kernel,
> instead of CONFIG_CGROUP_HUGETLB. Correct it.
>
> Discovered while searching for CONFIG_* symbols referenced in code but
> not defined in any Kconfig file.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>

LGTM, so:

Reviewed-by: Lorenzo Stoakes <ljs@kernel.org>

> ---
>  include/linux/hugetlb_cgroup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h
> index e5d64b8b59c2..16d72c8c71f6 100644
> --- a/include/linux/hugetlb_cgroup.h
> +++ b/include/linux/hugetlb_cgroup.h
> @@ -267,5 +267,5 @@ static inline void hugetlb_cgroup_migrate(struct folio *old_folio,
>  {
>  }
>
> -#endif  /* CONFIG_MEM_RES_CTLR_HUGETLB */
> +#endif  /* CONFIG_CGROUP_HUGETLB */
>  #endif
> --
> 2.43.0
>

Cheers, Lorenzo


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-29 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20260616000135.62815-1-enelsonmoore@gmail.com>
2026-06-23  7:40 ` [PATCH] mm: hugetlb: correct CONFIG_CGROUP_HUGETLB macro name in comment David Hildenbrand (Arm)
2026-06-29 10:25 ` Lorenzo Stoakes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox