From: Mike Rapoport <rppt@kernel.org>
To: "Rafael J. Wysocki (Intel)" <rafael@kernel.org>
Cc: Sang-Heon Jeon <ekffu200098@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
Danilo Krummrich <dakr@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Huacai Chen <chenhuacai@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH v2 2/9] ACPI: NUMA: remove redundant numa_nodes_parsed node_set()
Date: Tue, 7 Jul 2026 08:42:56 +0300 [thread overview]
Message-ID: <akyR4OFOb8qLlVra@kernel.org> (raw)
In-Reply-To: <CAJZ5v0iq+SjMvFVwsfwh0Zyp+h5MUJ7eeejQAOir8ssSu7yO3Q@mail.gmail.com>
Hi Rafael,
On Mon, Jul 06, 2026 at 07:57:55PM +0200, Rafael J. Wysocki (Intel) wrote:
> On Fri, Jul 3, 2026 at 6:14 AM Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> >
> > numa_add_memblk() now sets the node in numa_nodes_parsed itself, so the
> > caller's own node_set() is redundant. Remove it.
> >
> > No functional change.
> >
> > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> > ---
> > drivers/acpi/numa/srat.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c
> > index 62d4a8df0b8c..5c407dc6401e 100644
> > --- a/drivers/acpi/numa/srat.c
> > +++ b/drivers/acpi/numa/srat.c
> > @@ -399,8 +399,6 @@ acpi_parse_memory_affinity(union acpi_subtable_headers *header,
> > goto out_err_bad_srat;
> > }
> >
> > - node_set(node, numa_nodes_parsed);
> > -
> > pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n",
> > node, pxm,
> > (unsigned long long) start, (unsigned long long) end - 1,
> > --
>
> Applied as 7.3 material, thanks!
This depends on patch 1 in the series, so I think it's better to keep the
series together and merge via the memblock tree so I took it there a few
days ago:
https://lore.kernel.org/all/178306815065.2173096.9480193260074524906.b4-ty@b4
Would you like me to add your tag for this patch?
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-07-07 5:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 4:13 [PATCH v2 0/9] treewide, numa_memblks: remove redundant work during NUMA init Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 1/9] mm: numa_memblks: set numa_nodes_parsed in numa_add_memblk() Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 2/9] ACPI: NUMA: remove redundant numa_nodes_parsed node_set() Sang-Heon Jeon
2026-07-06 17:57 ` Rafael J. Wysocki (Intel)
2026-07-07 5:42 ` Mike Rapoport [this message]
2026-07-03 4:13 ` [PATCH v2 3/9] of/numa: " Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 4/9] x86/numa: " Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 5/9] arch_numa: " Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 6/9] LoongArch: " Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 7/9] mm: numa_memblks: remove redundant numa_nodemask_from_meminfo() Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 8/9] arch_numa: remove redundant node_possible_map assignment Sang-Heon Jeon
2026-07-03 4:13 ` [PATCH v2 9/9] mm: numa_memblks: use numa_add_reserved_memblk() in numa_cleanup_meminfo() Sang-Heon Jeon
2026-07-03 9:43 ` [PATCH v2 0/9] treewide, numa_memblks: remove redundant work during NUMA init Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akyR4OFOb8qLlVra@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=chenhuacai@kernel.org \
--cc=dakr@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=ekffu200098@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox