From: Mike Rapoport <rppt@kernel.org>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
Chris Zankel <chris@zankel.net>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Rich Felker <dalias@libc.org>, Thomas Gleixner <tglx@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-mm@kvack.org,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>,
x86@kernel.org
Subject: Re: [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot
Date: Tue, 7 Jul 2026 09:17:08 +0300 [thread overview]
Message-ID: <akyZ5DhIV_Grn1Kc@kernel.org> (raw)
In-Reply-To: <20260706163753.193875-1-ekffu200098@gmail.com>
Hi Sang-Heon,
On Tue, Jul 07, 2026 at 01:37:48AM +0900, Sang-Heon Jeon wrote:
> memblock_reserve() can only return an error after memblock_allow_resize()
> has been called. Before that it either succeeds or panics, never returning
> an error.
>
> Before memblock_allow_resize() is called, the return value checks of
> memblock_reserve() are unreachable and can be removed.
I'd rather keep these checks.
Removing them relies on internal details of memblock_reserve() implementation
and the existing event sequence. If the code would move around relying on
panic in memblock_reserve() may not be correct.
And the few bytes and cycles the change saves do not worth the churn.
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2026-07-07 6:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 16:37 [PATCH v2 0/5] treewide: remove unreachable memblock_reserve() return value checks in early boot Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 1/5] x86/setup: remove unreachable memblock_reserve() return value check Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 2/5] sh: " Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 3/5] powerpc/fadump: remove unreachable memblock_reserve() return value checks Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 4/5] xtensa: " Sang-Heon Jeon
2026-07-06 16:37 ` [PATCH v2 5/5] Revert "tpm: do not ignore memblock_reserve return value" Sang-Heon Jeon
2026-07-07 6:17 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akyZ5DhIV_Grn1Kc@kernel.org \
--to=rppt@kernel.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=chleroy@kernel.org \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=ekffu200098@gmail.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hpa@zytor.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox