* [PATCH] selftests/mm: Drop redundant open() in mprotect_tests()
@ 2026-08-17 8:06 Hongfu Li
2026-08-17 11:29 ` Lorenzo Stoakes (ARM)
0 siblings, 1 reply; 3+ messages in thread
From: Hongfu Li @ 2026-08-17 8:06 UTC (permalink / raw)
To: akpm, david, ljs, liam, vbabka, rppt, surenb, mhocko, shuah
Cc: linux-mm, linux-kselftest, linux-kernel, hongfu.li, Hongfu Li
From: Hongfu Li <lihongfu@kylinos.cn>
Remove duplicate open() for local pagemap_fd in mprotect_tests() that
shadows the global pagemap_fd already opened in main(). The local fd
is never used in the function.
Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
---
tools/testing/selftests/mm/pagemap_ioctl.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
index cfd1987339c1..eadc7159ca5b 100644
--- a/tools/testing/selftests/mm/pagemap_ioctl.c
+++ b/tools/testing/selftests/mm/pagemap_ioctl.c
@@ -1332,12 +1332,6 @@ int mprotect_tests(void)
int ret;
char *mem, *mem2;
struct page_region vec;
- int pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
-
- if (pagemap_fd < 0) {
- fprintf(stderr, "open() failed\n");
- exit(1);
- }
/* 1. Map two pages */
mem = mmap(0, 2 * page_size, PROT_READ|PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0);
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/mm: Drop redundant open() in mprotect_tests()
2026-08-17 8:06 [PATCH] selftests/mm: Drop redundant open() in mprotect_tests() Hongfu Li
@ 2026-08-17 11:29 ` Lorenzo Stoakes (ARM)
2026-08-17 11:54 ` Usama Anjum
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-08-17 11:29 UTC (permalink / raw)
To: Hongfu Li
Cc: akpm, david, liam, vbabka, rppt, surenb, mhocko, shuah, linux-mm,
linux-kselftest, linux-kernel, Hongfu Li, Muhammad Usama Anjum
+cc Muhammad
On Mon, Aug 17, 2026 at 04:06:16PM +0800, Hongfu Li wrote:
> From: Hongfu Li <lihongfu@kylinos.cn>
>
> Remove duplicate open() for local pagemap_fd in mprotect_tests() that
> shadows the global pagemap_fd already opened in main(). The local fd
> is never used in the function.
>
> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
Hmm yeah it's not even closed either...
I'm assuming this was an error in the origianl tests, Muhammad - I'm
guessing some artifact of a previous approach or similar?
Anyway, LGTM, so:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/pagemap_ioctl.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
> index cfd1987339c1..eadc7159ca5b 100644
> --- a/tools/testing/selftests/mm/pagemap_ioctl.c
> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c
> @@ -1332,12 +1332,6 @@ int mprotect_tests(void)
> int ret;
> char *mem, *mem2;
> struct page_region vec;
> - int pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
> -
> - if (pagemap_fd < 0) {
> - fprintf(stderr, "open() failed\n");
> - exit(1);
> - }
>
> /* 1. Map two pages */
> mem = mmap(0, 2 * page_size, PROT_READ|PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0);
> --
> 2.54.0
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/mm: Drop redundant open() in mprotect_tests()
2026-08-17 11:29 ` Lorenzo Stoakes (ARM)
@ 2026-08-17 11:54 ` Usama Anjum
0 siblings, 0 replies; 3+ messages in thread
From: Usama Anjum @ 2026-08-17 11:54 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM), Hongfu Li
Cc: usama.anjum, akpm, david, liam, vbabka, rppt, surenb, mhocko,
shuah, linux-mm, linux-kselftest, linux-kernel, Hongfu Li
On 17/08/2026 12:29 pm, Lorenzo Stoakes (ARM) wrote:
> +cc Muhammad
>
> On Mon, Aug 17, 2026 at 04:06:16PM +0800, Hongfu Li wrote:
>> From: Hongfu Li <lihongfu@kylinos.cn>
>>
>> Remove duplicate open() for local pagemap_fd in mprotect_tests() that
>> shadows the global pagemap_fd already opened in main(). The local fd
>> is never used in the function.
>>
>> Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>
> Hmm yeah it's not even closed either...
>
> I'm assuming this was an error in the origianl tests, Muhammad - I'm
> guessing some artifact of a previous approach or similar?
Its definitively the dead code.
Reviewed-by: Muhammad Usama Anjum <usama.anjum@arm.com>
>
> Anyway, LGTM, so:
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
>> ---
>> tools/testing/selftests/mm/pagemap_ioctl.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c
>> index cfd1987339c1..eadc7159ca5b 100644
>> --- a/tools/testing/selftests/mm/pagemap_ioctl.c
>> +++ b/tools/testing/selftests/mm/pagemap_ioctl.c
>> @@ -1332,12 +1332,6 @@ int mprotect_tests(void)
>> int ret;
>> char *mem, *mem2;
>> struct page_region vec;
>> - int pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
>> -
>> - if (pagemap_fd < 0) {
>> - fprintf(stderr, "open() failed\n");
>> - exit(1);
>> - }
>>
>> /* 1. Map two pages */
>> mem = mmap(0, 2 * page_size, PROT_READ|PROT_WRITE, MAP_PRIVATE | MAP_ANON, -1, 0);
>> --
>> 2.54.0
>>
>
> --
> Cheers, Lorenzo
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-17 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-17 8:06 [PATCH] selftests/mm: Drop redundant open() in mprotect_tests() Hongfu Li
2026-08-17 11:29 ` Lorenzo Stoakes (ARM)
2026-08-17 11:54 ` Usama Anjum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox