* Re: [PATCH] tools/testing/selftests/mm: add missing .gitignore entries
2026-08-31 14:18 [PATCH] tools/testing/selftests/mm: add missing .gitignore entries Lorenzo Stoakes (ARM)
@ 2026-08-31 17:06 ` Gregory Price
2026-08-31 17:39 ` Pratyush Mallick
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Gregory Price @ 2026-08-31 17:06 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM)
Cc: Andrew Morton, David Hildenbrand, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Shuah Khan, Pratyush Mallick, linux-mm, linux-kselftest,
linux-kernel
On Mon, Aug 31, 2026 at 03:18:23PM +0100, Lorenzo Stoakes (ARM) wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Reviewed-by: Gregory Price (Meta) <gourry@gourry.net>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
> --
> Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tools/testing/selftests/mm: add missing .gitignore entries
2026-08-31 14:18 [PATCH] tools/testing/selftests/mm: add missing .gitignore entries Lorenzo Stoakes (ARM)
2026-08-31 17:06 ` Gregory Price
@ 2026-08-31 17:39 ` Pratyush Mallick
2026-09-01 4:20 ` Sarthak Sharma
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Pratyush Mallick @ 2026-08-31 17:39 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM)
Cc: Andrew Morton, David Hildenbrand, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Shuah Khan, linux-mm, linux-kselftest, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
Thanks for the fix, Lorenzo, and apologies for missing it.
Regards,
Pratyush
On Mon, Aug 31, 2026 at 7:18 AM Lorenzo Stoakes (ARM) <ljs@kernel.org>
wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore
> b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
> --
> Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
>
[-- Attachment #2: Type: text/html, Size: 2030 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tools/testing/selftests/mm: add missing .gitignore entries
2026-08-31 14:18 [PATCH] tools/testing/selftests/mm: add missing .gitignore entries Lorenzo Stoakes (ARM)
2026-08-31 17:06 ` Gregory Price
2026-08-31 17:39 ` Pratyush Mallick
@ 2026-09-01 4:20 ` Sarthak Sharma
2026-09-01 4:31 ` Pratyush Mallick
2026-09-07 13:57 ` David Hildenbrand (Arm)
4 siblings, 0 replies; 7+ messages in thread
From: Sarthak Sharma @ 2026-09-01 4:20 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM), Andrew Morton, David Hildenbrand,
Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Shuah Khan
Cc: Pratyush Mallick, linux-mm, linux-kselftest, linux-kernel
On 8/31/26 7:48 PM, Lorenzo Stoakes (ARM) wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Looks good to me.
Reviewed-by: Sarthak Sharma <sarthak.sharma@arm.com>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tools/testing/selftests/mm: add missing .gitignore entries
2026-08-31 14:18 [PATCH] tools/testing/selftests/mm: add missing .gitignore entries Lorenzo Stoakes (ARM)
` (2 preceding siblings ...)
2026-09-01 4:20 ` Sarthak Sharma
@ 2026-09-01 4:31 ` Pratyush Mallick
2026-09-07 14:02 ` Lorenzo Stoakes (ARM)
2026-09-07 13:57 ` David Hildenbrand (Arm)
4 siblings, 1 reply; 7+ messages in thread
From: Pratyush Mallick @ 2026-09-01 4:31 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM)
Cc: Andrew Morton, David Hildenbrand, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Shuah Khan, linux-mm, linux-kselftest, linux-kernel
Thanks for the fix and apologies for missing it.
Regards,
Pratyush
On Mon, Aug 31, 2026 at 7:18 AM Lorenzo Stoakes (ARM) <ljs@kernel.org> wrote:
>
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
> --
> Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] tools/testing/selftests/mm: add missing .gitignore entries
2026-09-01 4:31 ` Pratyush Mallick
@ 2026-09-07 14:02 ` Lorenzo Stoakes (ARM)
0 siblings, 0 replies; 7+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-09-07 14:02 UTC (permalink / raw)
To: Pratyush Mallick
Cc: Andrew Morton, David Hildenbrand, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Shuah Khan, linux-mm, linux-kselftest, linux-kernel
On Mon, Aug 31, 2026 at 09:31:06PM -0700, Pratyush Mallick wrote:
> Thanks for the fix and apologies for missing it.
No worries, very easy to miss stuff with these :) thanks for cleaning this up,
it's MUCH better now...
>
> Regards,
> Pratyush
>
>
> On Mon, Aug 31, 2026 at 7:18 AM Lorenzo Stoakes (ARM) <ljs@kernel.org> wrote:
> >
> > Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> > switched to a pattern-matching mechanism to reduce churn in .gitignore.
> >
> > It however accidentally excluded the page_frag test's-generated module
> > intermediate C file with .mod.c extension, and also the local_config.h
> > header generated if liburing is available locally.
> >
> > Explicitly fix both the issues, fixing the module-generated C file as a
> > general pattern as these are always intermediate files that should be
> > ignored.
> >
> > Since this is a trivial .gitignore change it doesn't seem necessary to
> > treat it as a hotfix.
> >
> > Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> > ---
> > tools/testing/selftests/mm/.gitignore | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> > index fcd892ed21e3..a306d7754786 100644
> > --- a/tools/testing/selftests/mm/.gitignore
> > +++ b/tools/testing/selftests/mm/.gitignore
> > @@ -2,7 +2,9 @@
> > *
> > !/**/
> > !*.c
> > +*.mod.c
> > !*.h
> > +local_config.h
> > !*.sh
> > !.gitignore
> > !Makefile
> >
> > ---
> > base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> > change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
> >
> > Cheers,
> > --
> > Lorenzo Stoakes (ARM) <ljs@kernel.org>
> >
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] tools/testing/selftests/mm: add missing .gitignore entries
2026-08-31 14:18 [PATCH] tools/testing/selftests/mm: add missing .gitignore entries Lorenzo Stoakes (ARM)
` (3 preceding siblings ...)
2026-09-01 4:31 ` Pratyush Mallick
@ 2026-09-07 13:57 ` David Hildenbrand (Arm)
4 siblings, 0 replies; 7+ messages in thread
From: David Hildenbrand (Arm) @ 2026-09-07 13:57 UTC (permalink / raw)
To: Lorenzo Stoakes (ARM), Andrew Morton, Liam R. Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Shuah Khan
Cc: Pratyush Mallick, linux-mm, linux-kselftest, linux-kernel
On 8/31/26 16:18, Lorenzo Stoakes (ARM) wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
^ permalink raw reply [flat|nested] 7+ messages in thread