[PATCH 0/2] mm: remove three unused helpers from mm.h

[PATCH 0/2] mm: remove three unused helpers from mm.h

[Tal Zussman]

I happened to notice these were unused. Two of them are relatively
recently unused, and one has been unused for a few years. Remove them.

---
Tal Zussman (2):
      mm: remove unused mark_page_reserved()
      mm: remove unused totalram_pages_inc() and totalram_pages_dec()

 include/linux/mm.h | 16 ----------------
 1 file changed, 16 deletions(-)
---
base-commit: ead700ca770c82167af32622cf8b68c9f87c3c7c
change-id: 20260901-mm-remove-unused-helpers-33056049864c

Best regards,
--  
Tal Zussman <tz2294@columbia.edu>

[PATCH 1/2] mm: remove unused mark_page_reserved()

[Tal Zussman]

mark_page_reserved() lost its last caller in commit 6215d9f4470f ("arch,
mm: consolidate empty_zero_page"). Remove it.

Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
 include/linux/mm.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 1b28e6fc8d5d..e3736c42c4db 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -4080,12 +4080,6 @@ static inline void free_reserved_page(struct page *page)
 	free_reserved_pages(page, 0);
 }
 
-static inline void mark_page_reserved(struct page *page)
-{
-	SetPageReserved(page);
-	adjust_managed_page_count(page, -1);
-}
-
 static inline void free_reserved_ptdesc(struct ptdesc *pt)
 {
 	free_reserved_page(ptdesc_page(pt));

-- 
2.39.5

Re: [PATCH 1/2] mm: remove unused mark_page_reserved()

[Lorenzo Stoakes (ARM)]

On Tue, Sep 01, 2026 at 08:59:19AM -0400, Tal Zussman wrote:
> mark_page_reserved() lost its last caller in commit 6215d9f4470f ("arch,
> mm: consolidate empty_zero_page"). Remove it.
>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>

LGTM, so:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

> ---
>  include/linux/mm.h | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 1b28e6fc8d5d..e3736c42c4db 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4080,12 +4080,6 @@ static inline void free_reserved_page(struct page *page)
>  	free_reserved_pages(page, 0);
>  }
>
> -static inline void mark_page_reserved(struct page *page)
> -{
> -	SetPageReserved(page);
> -	adjust_managed_page_count(page, -1);
> -}
> -
>  static inline void free_reserved_ptdesc(struct ptdesc *pt)
>  {
>  	free_reserved_page(ptdesc_page(pt));
>
> --
> 2.39.5
>

--
Cheers, Lorenzo

Re: [PATCH 1/2] mm: remove unused mark_page_reserved()

[Mike Rapoport]

On Tue, Sep 01, 2026 at 08:59:19AM -0400, Tal Zussman wrote:
> mark_page_reserved() lost its last caller in commit 6215d9f4470f ("arch,
> mm: consolidate empty_zero_page"). Remove it.
> 
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  include/linux/mm.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 1b28e6fc8d5d..e3736c42c4db 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -4080,12 +4080,6 @@ static inline void free_reserved_page(struct page *page)
>  	free_reserved_pages(page, 0);
>  }
>  
> -static inline void mark_page_reserved(struct page *page)
> -{
> -	SetPageReserved(page);
> -	adjust_managed_page_count(page, -1);
> -}
> -
>  static inline void free_reserved_ptdesc(struct ptdesc *pt)
>  {
>  	free_reserved_page(ptdesc_page(pt));
> 
> -- 
> 2.39.5
> 

-- 
Sincerely yours,
Mike.

[PATCH 2/2] mm: remove unused totalram_pages_inc() and totalram_pages_dec()

[Tal Zussman]

totalram_pages_inc() and totalram_pages_dec() have had no callers since
commit 7fbc5e26123e ("memblock: extract page freeing from
free_reserved_area() into a helper") and commit 287b89773d81
("powerpc/pseries/cmm: Use adjust_managed_page_count() insted of
totalram_pages_*"), respectively. Remove them.

Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
 include/linux/mm.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index e3736c42c4db..c105a3758915 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -57,16 +57,6 @@ static inline unsigned long totalram_pages(void)
 	return (unsigned long)atomic_long_read(&_totalram_pages);
 }
 
-static inline void totalram_pages_inc(void)
-{
-	atomic_long_inc(&_totalram_pages);
-}
-
-static inline void totalram_pages_dec(void)
-{
-	atomic_long_dec(&_totalram_pages);
-}
-
 static inline void totalram_pages_add(long count)
 {
 	atomic_long_add(count, &_totalram_pages);

-- 
2.39.5

Re: [PATCH 2/2] mm: remove unused totalram_pages_inc() and totalram_pages_dec()

[Lorenzo Stoakes (ARM)]

On Tue, Sep 01, 2026 at 08:59:20AM -0400, Tal Zussman wrote:
> totalram_pages_inc() and totalram_pages_dec() have had no callers since
> commit 7fbc5e26123e ("memblock: extract page freeing from
> free_reserved_area() into a helper") and commit 287b89773d81
> ("powerpc/pseries/cmm: Use adjust_managed_page_count() insted of
> totalram_pages_*"), respectively. Remove them.
>
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>

With additional change requested below addressed, LGTM and:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

> ---
>  include/linux/mm.h | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index e3736c42c4db..c105a3758915 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -57,16 +57,6 @@ static inline unsigned long totalram_pages(void)
>  	return (unsigned long)atomic_long_read(&_totalram_pages);
>  }
>
> -static inline void totalram_pages_inc(void)
> -{
> -	atomic_long_inc(&_totalram_pages);
> -}

I also see totalram_pages_inc() in tools/include/linux/mm.h - could you remove
it too to keep things consistent? Thanks!

> -
> -static inline void totalram_pages_dec(void)
> -{
> -	atomic_long_dec(&_totalram_pages);
> -}
> -
>  static inline void totalram_pages_add(long count)
>  {
>  	atomic_long_add(count, &_totalram_pages);
>
> --
> 2.39.5
>

--
Cheers, Lorenzo

Re: [PATCH 2/2] mm: remove unused totalram_pages_inc() and totalram_pages_dec()

[Tal Zussman]

On 9/1/26 5:06 PM, Lorenzo Stoakes (ARM) wrote:
> On Tue, Sep 01, 2026 at 08:59:20AM -0400, Tal Zussman wrote:
>> totalram_pages_inc() and totalram_pages_dec() have had no callers since
>> commit 7fbc5e26123e ("memblock: extract page freeing from
>> free_reserved_area() into a helper") and commit 287b89773d81
>> ("powerpc/pseries/cmm: Use adjust_managed_page_count() insted of
>> totalram_pages_*"), respectively. Remove them.
>>
>> Signed-off-by: Tal Zussman <tz2294@columbia.edu>
> 
> With additional change requested below addressed, LGTM and:
> 
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> 

Thanks!

>> ---
>>  include/linux/mm.h | 10 ----------
>>  1 file changed, 10 deletions(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index e3736c42c4db..c105a3758915 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -57,16 +57,6 @@ static inline unsigned long totalram_pages(void)
>>  	return (unsigned long)atomic_long_read(&_totalram_pages);
>>  }
>>
>> -static inline void totalram_pages_inc(void)
>> -{
>> -	atomic_long_inc(&_totalram_pages);
>> -}
> 
> I also see totalram_pages_inc() in tools/include/linux/mm.h - could you remove
> it too to keep things consistent? Thanks!
> 

Yes, will do. For some reason I was under the impression that tools headers
are generally synced separately as needed, but that's clearly not the case...
Maybe I was thinking of the tools uapi headers.

>> -
>> -static inline void totalram_pages_dec(void)
>> -{
>> -	atomic_long_dec(&_totalram_pages);
>> -}
>> -
>>  static inline void totalram_pages_add(long count)
>>  {
>>  	atomic_long_add(count, &_totalram_pages);
>>
>> --
>> 2.39.5
>>
> 
> --
> Cheers, Lorenzo
> 

Re: [PATCH 2/2] mm: remove unused totalram_pages_inc() and totalram_pages_dec()

[Lorenzo Stoakes (ARM)]

On Tue, Sep 01, 2026 at 10:29:38AM -0400, Tal Zussman wrote:
> On 9/1/26 5:06 PM, Lorenzo Stoakes (ARM) wrote:
> > I also see totalram_pages_inc() in tools/include/linux/mm.h - could you remove
> > it too to keep things consistent? Thanks!
> >
>
> Yes, will do. For some reason I was under the impression that tools headers
> are generally synced separately as needed, but that's clearly not the case...
> Maybe I was thinking of the tools uapi headers.

Well they usually are, or should be (kinda) sometimes. But since this is being
removed it's a good point at which to sync at least this known-no-longer-needed
bit :)

--
Cheers, Lorenzo

Re: [PATCH 2/2] mm: remove unused totalram_pages_inc() and totalram_pages_dec()

[Mike Rapoport]

On Tue, Sep 01, 2026 at 08:59:20AM -0400, Tal Zussman wrote:
> totalram_pages_inc() and totalram_pages_dec() have had no callers since
> commit 7fbc5e26123e ("memblock: extract page freeing from
> free_reserved_area() into a helper") and commit 287b89773d81
> ("powerpc/pseries/cmm: Use adjust_managed_page_count() insted of
> totalram_pages_*"), respectively. Remove them.
> 
> Signed-off-by: Tal Zussman <tz2294@columbia.edu>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

> ---
>  include/linux/mm.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index e3736c42c4db..c105a3758915 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -57,16 +57,6 @@ static inline unsigned long totalram_pages(void)
>  	return (unsigned long)atomic_long_read(&_totalram_pages);
>  }
>  
> -static inline void totalram_pages_inc(void)
> -{
> -	atomic_long_inc(&_totalram_pages);
> -}
> -
> -static inline void totalram_pages_dec(void)
> -{
> -	atomic_long_dec(&_totalram_pages);
> -}
> -
>  static inline void totalram_pages_add(long count)
>  {
>  	atomic_long_add(count, &_totalram_pages);
> 
> -- 
> 2.39.5
> 

-- 
Sincerely yours,
Mike.