From: Uladzislau Rezki <urezki@gmail.com>
To: Hao Ge <hao.ge@linux.dev>
Cc: Suren Baghdasaryan <surenb@google.com>,
Uladzislau Rezki <urezki@gmail.com>, Dev Jain <dev.jain@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@gentwo.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
stable@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v5 01/11] mm/vmalloc: skip cond_resched() in the vmap unmap paths when atomic
Date: Wed, 18 Nov 2026 20:00:13 +0100 [thread overview]
Message-ID: <av31vR89G64KJHpj@milan> (raw)
In-Reply-To: <20261116071325.263682-2-hao.ge@linux.dev>
On Mon, Nov 16, 2026 at 03:13:15PM +0800, Hao Ge wrote:
> The vmap failure paths can be reached with GFP_ATOMIC or GFP_NOWAIT
> since commit b186a94227b7 ("kmsan: remove hard-coded GFP_KERNEL
> flags") and commit 8da89ba18ed4 ("mm/vmalloc: handle non-blocking
> GFP in __vmalloc_area_node()"), so an undo of a partially installed
> mapping may have to run in atomic context, where the cond_resched()
> in vunmap_pmd_range() cannot schedule.
>
> Give __vunmap_range_noflush() and kmsan_vunmap_range_noflush() a
> can_resched argument and skip the cond_resched() when it is false.
> The existing callers are on sleepable paths and pass true, so nothing
> changes for them.
>
> Fixes: 47ebd0310e89 ("mm: kmsan: handle alloc failures in kmsan_vmap_pages_range_noflush()")
> Cc: stable@vger.kernel.org
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/all/sashiko-outbox-178439@kernel.org/
> Signed-off-by: Hao Ge <hao.ge@linux.dev>
> ---
> include/linux/kmsan.h | 8 ++++++--
> mm/kmsan/hooks.c | 14 +++++++++-----
> mm/vmalloc.c | 24 ++++++++++++++----------
> mm/vmalloc.h | 3 ++-
> 4 files changed, 31 insertions(+), 18 deletions(-)
>
> diff --git a/include/linux/kmsan.h b/include/linux/kmsan.h
> index 7da9fd506b39..0016c032d1e7 100644
> --- a/include/linux/kmsan.h
> +++ b/include/linux/kmsan.h
> @@ -150,11 +150,14 @@ int __must_check kmsan_vmap_pages_range_noflush(unsigned long start,
> * kmsan_vunmap_kernel_range_noflush() - Notify KMSAN about a vunmap.
> * @start: start of vunmapped range.
> * @end: end of vunmapped range.
> + * @can_resched: whether the unmap walk may call cond_resched(); pass
> + * false from atomic context.
> *
> * KMSAN unmaps the contiguous metadata ranges created by
> * kmsan_map_kernel_range_noflush().
> */
> -void kmsan_vunmap_range_noflush(unsigned long start, unsigned long end);
> +void kmsan_vunmap_range_noflush(unsigned long start, unsigned long end,
> + bool can_resched);
>
> /**
> * kmsan_ioremap_page_range() - Notify KMSAN about a ioremap_page_range() call.
> @@ -355,7 +358,8 @@ static inline int __must_check kmsan_vmap_pages_range_noflush(
> }
>
> static inline void kmsan_vunmap_range_noflush(unsigned long start,
> - unsigned long end)
> + unsigned long end,
> + bool can_resched)
> {
> }
>
> diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c
> index a706666db097..69008b085658 100644
> --- a/mm/kmsan/hooks.c
> +++ b/mm/kmsan/hooks.c
> @@ -136,10 +136,13 @@ static unsigned long vmalloc_origin(unsigned long addr)
> KMSAN_META_ORIGIN);
> }
>
> -void kmsan_vunmap_range_noflush(unsigned long start, unsigned long end)
> +void kmsan_vunmap_range_noflush(unsigned long start, unsigned long end,
> + bool can_resched)
> {
> - __vunmap_range_noflush(vmalloc_shadow(start), vmalloc_shadow(end));
> - __vunmap_range_noflush(vmalloc_origin(start), vmalloc_origin(end));
> + __vunmap_range_noflush(vmalloc_shadow(start), vmalloc_shadow(end),
> + can_resched);
> + __vunmap_range_noflush(vmalloc_origin(start), vmalloc_origin(end),
> + can_resched);
> flush_cache_vmap(vmalloc_shadow(start), vmalloc_shadow(end));
> flush_cache_vmap(vmalloc_origin(start), vmalloc_origin(end));
> }
> @@ -168,8 +171,9 @@ static void kmsan_iounmap_pages(unsigned long start, unsigned long end)
> if (origin)
> __free_pages(origin, KMSAN_IOREMAP_META_ORDER);
> }
> - __vunmap_range_noflush(shadow_start, shadow_end);
> - __vunmap_range_noflush(origin_start, origin_end);
> + /* ioremap metadata mappings are always GFP_KERNEL, so resched is safe. */
> + __vunmap_range_noflush(shadow_start, shadow_end, true);
> + __vunmap_range_noflush(origin_start, origin_end, true);
> flush_tlb_kernel_range(shadow_start, shadow_end);
> flush_tlb_kernel_range(origin_start, origin_end);
> }
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index ccaf158c5b7f..3c0d9e69b886 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -429,7 +429,7 @@ static void vunmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
> }
>
> static void vunmap_pmd_range(pud_t *pud, unsigned long addr, unsigned long end,
> - pgtbl_mod_mask *mask)
> + pgtbl_mod_mask *mask, bool can_resched)
> {
> pmd_t *pmd;
> unsigned long next;
> @@ -451,12 +451,14 @@ static void vunmap_pmd_range(pud_t *pud, unsigned long addr, unsigned long end,
> continue;
> vunmap_pte_range(pmd, addr, next, mask);
>
> - cond_resched();
> + /* The undo path may run in atomic context. */
> + if (can_resched)
> + cond_resched();
> } while (pmd++, addr = next, addr != end);
> }
>
> static void vunmap_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end,
> - pgtbl_mod_mask *mask)
> + pgtbl_mod_mask *mask, bool can_resched)
> {
> pud_t *pud;
> unsigned long next;
> @@ -476,12 +478,12 @@ static void vunmap_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end,
> }
> if (pud_none_or_clear_bad(pud))
> continue;
> - vunmap_pmd_range(pud, addr, next, mask);
> + vunmap_pmd_range(pud, addr, next, mask, can_resched);
> } while (pud++, addr = next, addr != end);
> }
>
> static void vunmap_p4d_range(pgd_t *pgd, unsigned long addr, unsigned long end,
> - pgtbl_mod_mask *mask)
> + pgtbl_mod_mask *mask, bool can_resched)
> {
> p4d_t *p4d;
> unsigned long next;
> @@ -496,7 +498,7 @@ static void vunmap_p4d_range(pgd_t *pgd, unsigned long addr, unsigned long end,
>
> if (p4d_none_or_clear_bad(p4d))
> continue;
> - vunmap_pud_range(p4d, addr, next, mask);
> + vunmap_pud_range(p4d, addr, next, mask, can_resched);
> } while (p4d++, addr = next, addr != end);
> }
>
> @@ -512,7 +514,8 @@ static void vunmap_p4d_range(pgd_t *pgd, unsigned long addr, unsigned long end,
> *
> * This is an internal function only. Do not use outside mm/.
> */
> -void __vunmap_range_noflush(unsigned long start, unsigned long end)
> +void __vunmap_range_noflush(unsigned long start, unsigned long end,
> + bool can_resched)
> {
> unsigned long next;
> pgd_t *pgd;
> @@ -527,7 +530,7 @@ void __vunmap_range_noflush(unsigned long start, unsigned long end)
> mask |= PGTBL_PGD_MODIFIED;
> if (pgd_none_or_clear_bad(pgd))
> continue;
> - vunmap_p4d_range(pgd, addr, next, &mask);
> + vunmap_p4d_range(pgd, addr, next, &mask, can_resched);
> } while (pgd++, addr = next, addr != end);
>
> if (mask & ARCH_PAGE_TABLE_SYNC_MASK)
> @@ -536,8 +539,9 @@ void __vunmap_range_noflush(unsigned long start, unsigned long end)
>
> void vunmap_range_noflush(unsigned long start, unsigned long end)
> {
> - kmsan_vunmap_range_noflush(start, end);
> - __vunmap_range_noflush(start, end);
> + /* The unmap paths are sleepable, keep the resched point. */
> + kmsan_vunmap_range_noflush(start, end, true);
> + __vunmap_range_noflush(start, end, true);
> }
>
> /**
> diff --git a/mm/vmalloc.h b/mm/vmalloc.h
> index d8372a4f65c4..4ec114a75f04 100644
> --- a/mm/vmalloc.h
> +++ b/mm/vmalloc.h
> @@ -44,6 +44,7 @@ int __must_check __vmap_pages_range_noflush(unsigned long addr,
>
> void vunmap_range_noflush(unsigned long start, unsigned long end);
>
> -void __vunmap_range_noflush(unsigned long start, unsigned long end);
> +void __vunmap_range_noflush(unsigned long start, unsigned long end,
> + bool can_resched);
>
> #endif /* __MM_VMALLOC_H */
> --
> 2.25.1
>
This looks good to me. I am not sure if passing gfp_mask is better
here since it is only for checking if-allow-blocking.
--
Uladzislau Rezki
next prev parent reply other threads:[~2026-11-18 19:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 7:13 [PATCH v5 00/11] mm/vmalloc: fix up vmap error handling Hao Ge
2026-11-16 7:13 ` [PATCH v5 01/11] mm/vmalloc: skip cond_resched() in the vmap unmap paths when atomic Hao Ge
2026-11-18 19:00 ` Uladzislau Rezki [this message]
2026-11-16 7:13 ` [PATCH v5 02/11] mm/kmsan: undo the shadow mapping when the origin mapping fails Hao Ge
2026-11-16 7:13 ` [PATCH v5 03/11] mm/vmalloc: reject an unaligned range in vmap_page_range() Hao Ge
2026-11-17 5:53 ` Dev Jain
2026-11-18 19:10 ` Uladzislau Rezki
2026-11-16 7:13 ` [PATCH v5 04/11] mm/vmalloc: reject an unaligned range in __vunmap_range_noflush() Hao Ge
2026-11-17 6:05 ` Dev Jain
2026-11-18 19:16 ` Uladzislau Rezki
2026-11-16 7:13 ` [PATCH v5 05/11] mm/vmalloc: only flush the cache after the vmap succeeded Hao Ge
2026-11-18 19:31 ` Uladzislau Rezki
2026-11-16 7:13 ` [PATCH v5 06/11] mm/vmalloc: undo what vmap_page_range() mapped on failure Hao Ge
2026-11-18 19:50 ` Uladzislau Rezki
2026-11-16 7:13 ` [PATCH v5 07/11] mm/vmalloc: undo what __vmap_pages_range_noflush() " Hao Ge
2026-11-17 7:15 ` sashiko-bot
2026-11-17 7:27 ` Hao Ge
2026-11-16 7:13 ` [PATCH v5 08/11] mm/vmalloc: drop the KMSAN metadata in vmap_pages_range_noflush() " Hao Ge
2026-11-16 7:13 ` [PATCH v5 09/11] mm/vmalloc: undo what vmap_pages_range_batched() mapped " Hao Ge
2026-11-16 7:13 ` [PATCH v5 10/11] powerpc: drop redundant unmaps of failed vmap mappings Hao Ge
2026-11-16 7:13 ` [PATCH v5 11/11] mm/percpu: stop unmapping the CPU that failed to map Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av31vR89G64KJHpj@milan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chleroy@kernel.org \
--cc=cl@gentwo.org \
--cc=dennis@kernel.org \
--cc=dev.jain@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=hao.ge@linux.dev \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=sashiko-bot@kernel.org \
--cc=sshegde@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).