From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Muhammad Haris Awan <m.harisawan@icloud.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <kees@kernel.org>,
David Hildenbrand <david@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] fork: mark memcpy() in dup_mm() with data_race()
Date: Tue, 17 Nov 2026 12:58:48 +0000 [thread overview]
Message-ID: <avxJKzw9JLrSZTlR@gremlin> (raw)
In-Reply-To: <179489519663.1444496.15875846661591982934@icloud.com>
On Tue, Nov 17, 2026 at 10:59:56AM +0500, Muhammad Haris Awan wrote:
> KCSAN reported a data race between dup_mm() copying oldmm via
> memcpy(mm, oldmm, sizeof(*mm)) and lru_gen_del_mm() modifying
> oldmm->lru_gen.list when an adjacent mm_struct on the shared
> mm_list->fifo is removed under mm_list->lock.
>
> oldmm->lru_gen and oldmm->mmlist are protected by mm_list->lock /
> mmlist_lock (or updated locklessly via lru_gen_use_mm()), not
> oldmm->mmap_lock. Because struct mm_struct uses __randomize_layout and
Firstly what on earth does __randomize_layout have to do with anything?
Secondly, ef694e2d2101 takes the oldmm mmap_lock so what you're saying here is
wrong.
The problem is that you end up manipulating a neighbouring mm in the list.
> mm_init() immediately reinitializes these fields on the new mm, wrap
> the memcpy() in data_race(), matching dup_vma() in mm/vma_init.c.
>
> Fixes: bd74fdaea146 ("mm: multi-gen LRU: support page table walks")
> Reported-by: syzbot+c6e1b1b32ff2fc3b7d60@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=c6e1b1b32ff2fc3b7d60
> Signed-off-by: Muhammad Haris Awan <m.harisawan@icloud.com>
Given you're a complete newcomer to mm I do have to ask if you used an LLM, you
should mention that somewhere in the commit message or at least below the '---'
by convention.
And it's vital that you understand everything you submit as per
https://docs.kernel.org/process/generated-content.html
So what work are you doing with regard to KCSAN, data races and mm lifetime that
led you to this? And what expertise are you coming to it with?
> ---
> kernel/fork.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 5efceb8d5..14ac9a070 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1539,7 +1539,12 @@ static struct mm_struct *dup_mm(struct task_struct *tsk,
> goto fail_uprobe;
> }
>
> - memcpy(mm, oldmm, sizeof(*mm));
> + /*
> + * oldmm->lru_gen and oldmm->mmlist may be modified concurrently under
> + * mm_list->lock / mmlist_lock or locklessly via lru_gen_use_mm(),
> + * and mm_init() will immediately reinitialize them.
> + */
I really don't like this comment that is begging to bit rot.
> + data_race(memcpy(mm, oldmm, sizeof(*mm)));
That's _really_ horrible.
That's now making it so any race that matters is ignored in a _super_ sensitive
part of mm, because MGLRU decided it was a special snowflake.
But I'm confused as to why in 4 years nobody reported a KCSAN issue with this?
Surely something increased the likelihood of this race?
In any case, this is MGLRU's fault. It's abusing the mm data structure and doing
something it shouldn't.
So any fix should be there. Similarly for other mmlist users.
Or really, given this seems to be a one-off, spurious, KCSAN report, do nothing
until it becomes clear this will be reported more than once in 4 years? :)
>
> if (!mm_init(mm, tsk)) {
> mmap_write_unlock(oldmm);
> --
> 2.56.0
>
--
Cheers, Lorenzo
prev parent reply other threads:[~2026-11-17 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:59 [PATCH] fork: mark memcpy() in dup_mm() with data_race() Muhammad Haris Awan
2026-11-17 8:59 ` David Hildenbrand (Arm)
2026-11-17 10:24 ` Muhammad Haris Awan
2026-11-17 10:54 ` David Hildenbrand (Arm)
2026-11-17 13:02 ` Lorenzo Stoakes (ARM)
2026-11-17 12:58 ` Lorenzo Stoakes (ARM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avxJKzw9JLrSZTlR@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bsegall@google.com \
--cc=david@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.harisawan@icloud.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox