From: "Arnd Bergmann" <arnd@arndb.de>
To: sashiko-reviews@lists.linux.dev,
"Arnd Bergmann" <arnd@kernel.org>,
linux-mm@kvack.org
Cc: "Andreas Larsson" <andreas@gaisler.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christophe Leroy" <chleroy@kernel.org>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David Hildenbrand (Red Hat)" <david@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Linus Walleij" <linusw@kernel.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Malin Jonsson" <malin.jonsson@est.tech>,
"Matthew Wilcox" <willy@infradead.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michal Simek" <monstr@monstr.eu>,
"Mike Rapoport" <rppt@kernel.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Nishanth Menon" <nm@ti.com>,
"Richard Weinberger" <richard@nod.at>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Gleixner" <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [PATCH v3 10/10] mm: print pte in __print_bad_page_map_pgtable()
Date: Wed, 18 Nov 2026 08:32:50 +0100 [thread overview]
Message-ID: <ec881778-0f77-4f4e-be4e-17dc0adf8bf0@app.fastmail.com> (raw)
In-Reply-To: <sashiko-outbox-218805@kernel.org>
On Tue, Nov 17, 2026, at 13:50, sashiko-bot@kernel.org wrote:
> print_bad_pte()
> ...
> pmd = pmdp_get(pmdp)
> if (!pmd_present(pmd) || ...)
> retract_page_tables() / zap_pte_range()
> pmdp_collapse_flush() / pmd_clear()
> pte_free_defer()
> /* RCU grace period elapses */
> ptep = pte_offset_kernel(pmdp, addr)
> pte = ptep_get(ptep) <-- bogus address or use-after-free
>
> If CPU1 clears *pmdp or replaces it with a huge leaf PMD and frees the PTE
> page table via RCU between pmdp_get(pmdp) and ptep_get(ptep), CPU0 will
> re-read the modified *pmdp and dereference a bogus kernel address or freed
> PTE table. Using pte_offset_map() and pte_unmap() here avoids re-reading
> *pmdp and keeps the PTE page table RCU-protected while reading the entry.
This looks like it should be prevented calling conventions for
print_bad_page_map():
* This function must be called during a proper page table walk, as it will
* re-walk the page table to dump information: the caller MUST prevent page
* table teardown (by holding mmap, vma or rmap lock) and MUST hold the leaf
* page table lock.
Is that a case of do_swap_page() calling print_bad_pte() incorrectly
that I can ignore here, or should I actually change this? Is the
same race present in the upper page table lookups?
> Also, this isn't a bug, but the early-return pr_alert() above adds an extra
> space in "pmd: %s" compared to "pmd:%s" in the other messages.
Fixed.
Arnd
next prev parent reply other threads:[~2026-11-18 7:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:48 [PATCH v3 00/10] mm: highmem cleanups Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 01/10] ARM: remove support for highmem on VIVT Arnd Bergmann
2026-11-17 12:49 ` sashiko-bot
2026-11-18 9:47 ` Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 02/10] ARM: drop CONFIG_HIGHPTE support Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 03/10] ARM: pxa: support arbitrary PAGE_OFFSET Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 04/10] powerpc: kvm: allow flexible PAGE_OFFSET Arnd Bergmann
2026-11-16 13:38 ` Christophe Leroy (CS GROUP)
2026-11-16 22:54 ` Arnd Bergmann
2026-11-17 15:11 ` Christophe Leroy (CS GROUP)
2026-11-17 15:41 ` Arnd Bergmann
2026-11-17 12:49 ` sashiko-bot
2026-11-16 12:48 ` [PATCH v3 05/10] ARM: add CONFIG_VMSPLIT_2G_OPT option Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 06/10] arch/*: increase lowmem size to avoid highmem use Arnd Bergmann
2026-11-17 12:49 ` sashiko-bot
2026-11-18 9:35 ` Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 07/10] ARM: defconfig: turn off highmem in favor of CONFIG_VMSPLIT_2G_OPT Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 08/10] mm: remove ARCH_NEEDS_KMAP_HIGH_GET Arnd Bergmann
2026-11-17 10:05 ` David Hildenbrand (Arm)
2026-11-16 12:48 ` [PATCH v3 09/10] mm: drop HIGHPTE support altogether Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 10/10] mm: print pte in __print_bad_page_map_pgtable() Arnd Bergmann
2026-11-16 13:00 ` Mike Rapoport
2026-11-17 12:50 ` sashiko-bot
2026-11-18 7:32 ` Arnd Bergmann [this message]
2026-11-18 9:26 ` David Hildenbrand (Arm)
2026-11-17 10:07 ` [PATCH v3 00/10] mm: highmem cleanups David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec881778-0f77-4f4e-be4e-17dc0adf8bf0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=arnd@kernel.org \
--cc=chleroy@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=hpa@zytor.com \
--cc=jgg@nvidia.com \
--cc=l.stach@pengutronix.de \
--cc=linusw@kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=ljs@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=malin.jonsson@est.tech \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=nm@ti.com \
--cc=npiggin@gmail.com \
--cc=richard@nod.at \
--cc=rppt@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox