public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Li Wang <wangli.ahau@gmail.com>,
	akpm@linux-foundation.org, ljs@kernel.org,
	Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org,
	surenb@google.com, mhocko@suse.com, shuah@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] selftests/mm: suppress compiler error in liburing check
Date: Thu, 23 Apr 2026 15:40:51 +0200	[thread overview]
Message-ID: <f6ca5592-9a5b-46bf-94ab-3d8a0e2ad996@kernel.org> (raw)
In-Reply-To: <20260422080446.26020-3-wangli.ahau@gmail.com>

On 4/22/26 10:04, Li Wang wrote:
> When building the mm selftests on a system without liburing development
> headers, check_config.sh leaks a raw compiler error:
> 
>   /tmp/tmp.kIIOIqwe3n.c:2:10: fatal error: liburing.h: No such file or directory
>       2 | #include <liburing.h>
>         |          ^~~~~~~~~~~~
> 
> Since this is an expected failure during the configuration probe,
> redirect the compiler output to /dev/null to hide it.
> 
> And the build system prints a clear warning when this occurs:
> 
>   Warning: missing liburing support. Some tests will be skipped.
> 
> Because the user is properly notified about the missing dependency, the
> raw compiler error is redundant and only confuse users.
> 
> Additionally, update the Makefile to use $(Q) and $(call msg,...) for
> the check_config.sh execution. This aligns the probe with standard
> kbuild output formatting, providing a clean "CHK" message instead of
> printing the raw command during the build.
> 
> Signed-off-by: Li Wang <wangli.ahau@gmail.com>
> ---

Thanks!

Tested-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David


  reply	other threads:[~2026-04-23 13:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22  8:04 [PATCH v3 0/2] selftests/mm: clean up build output and verbosity Li Wang
2026-04-22  8:04 ` [PATCH v3 1/2] selftests/mm: respect build verbosity settings for 32/64-bit targets Li Wang
2026-04-23 13:38   ` David Hildenbrand (Arm)
2026-04-22  8:04 ` [PATCH v3 2/2] selftests/mm: suppress compiler error in liburing check Li Wang
2026-04-23 13:40   ` David Hildenbrand (Arm) [this message]
2026-04-23 13:31 ` [PATCH v3 0/2] selftests/mm: clean up build output and verbosity David Hildenbrand (Arm)
2026-04-24  0:17   ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6ca5592-9a5b-46bf-94ab-3d8a0e2ad996@kernel.org \
    --to=david@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=wangli.ahau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox