Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Auld" <matthew.auld@intel.com>,
	linux-mm@kvack.org
Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Mika Penttilä" <mpenttil@redhat.com>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"John Hubbard" <jhubbard@nvidia.com>
Subject: Re: [PATCH] mm/hmm: skip NUMA balancing on protnone faults
Date: Mon, 16 Nov 2026 21:12:42 +0100	[thread overview]
Message-ID: <f81bd37a-9637-44be-83fd-be7e717fa182@kernel.org> (raw)
In-Reply-To: <58755e3cb51d534b749d70847a5478a40c1c10fa.camel@linux.intel.com>

On 11/16/26 15:53, Thomas Hellström wrote:
> On Fri, 2026-11-13 at 22:19 +0100, David Hildenbrand (Arm) wrote:
>> On 11/13/26 21:56, Thomas Hellström wrote:
>>>
>>> Wouldn't the net effect be that content stays put instead of being
>>> migrated? In both cases a later CPU access will not trigger NUMA
>>> hinting except that the proposed change doesn't send content to an
>>> irrelevant node?
>>
>> My point is that you are essentially disabling NUMA hinting because
>> the CPU will
>> no longer trigger NUMA hinting faults.
> 
> Yes, I got that part, but that's is only for a single scan, right?

Well, one NUMA-hinting protects again, you would get an MMU notifier, and fault
again here?

It all gets pretty unpredictable for these PTEs, no?


>> But then, just disable it entirely. Maybe John knows what to do.
> 
> We can't do that globally, really, for these type of apps. But one
> remedy might be recommending the app to mbind() with a no-migration-on-
> fault policy.

Yeah, something like this. I mean, it's hard to see how NUMA balancing makes any
sense here. You're just trying to fight the mechanism because it ends up causing
more harm then good.

> 
> Also the hmm O(n²) complexity in this situation isn't really ideal. We
> might need to look at that as well.
I didn't quite get that, can you elaborate?

-- 
Cheers,

David


      reply	other threads:[~2026-11-16 20:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 16:25 [PATCH] mm/hmm: skip NUMA balancing on protnone faults Matthew Auld
2026-11-13 18:27 ` David Hildenbrand (Arm)
2026-11-13 20:34   ` Thomas Hellström
2026-11-13 20:43     ` David Hildenbrand (Arm)
2026-11-13 20:53       ` Gregory Price (Meta)
2026-11-13 20:56       ` Thomas Hellström
2026-11-13 21:19         ` David Hildenbrand (Arm)
2026-11-16 14:53           ` Thomas Hellström
2026-11-16 20:12             ` David Hildenbrand (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f81bd37a-9637-44be-83fd-be7e717fa182@kernel.org \
    --to=david@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jgg@ziepe.ca \
    --cc=jhubbard@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=mpenttil@redhat.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox