From: "David Hildenbrand (Arm)" <david@kernel.org>
To: xu.xin16@zte.com.cn, akpm@linux-foundation.org
Cc: chengming.zhou@linux.dev, hughd@google.com,
wang.yaxin@zte.com.cn, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, ljs@kernel.org
Subject: Re: [PATCH v11 3/3] ksm: add mremap selftests for ksm_rmap_walk
Date: Mon, 6 Jul 2026 08:55:23 +0200 [thread overview]
Message-ID: <fdb8fd51-d351-48b8-b2e5-5a480a068e11@kernel.org> (raw)
In-Reply-To: <20260703162637070FU4ekl58Hw_Z7OSuJryZB@zte.com.cn>
On 7/3/26 10:26, xu.xin16@zte.com.cn wrote:
> From: xu xin <xu.xin16@zte.com.cn>
>
> The existing tools/testing/selftests/mm/rmap.c has already one testcase
> for ksm_rmap_walk in TEST_F(migrate, ksm), which takes use of migration
> of page from one NUMA node to another NUMA node. However, it just lacks
> the scenario of mremapped VMAs.
>
> We add the calling of mremap() and then trigger KSM to merge pages before
> migrating, which is specifically to test an optimization which is
> introduced by this patch ("ksm: Optimize rmap_walk_ksm by passing a
> suitable address pgoff").
>
> This test can reproduce the issue that Hugh points out at
> https://lore.kernel.org/all/02e1b8df-d568-8cbb-b8f6-46d5476d9d75@google.com/
>
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-07-06 6:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 8:22 [PATCH v11 0/3] KSM: performance optimizations for rmap_walk_ksm xu.xin16
2026-07-03 8:23 ` [PATCH v11 1/3] ksm: add linear_page_index into ksm_rmap_item xu.xin16
2026-07-03 8:25 ` [PATCH v11 2/3] ksm: Optimize rmap_walk_ksm by passing a suitable page index xu.xin16
2026-07-06 6:53 ` David Hildenbrand (Arm)
2026-07-03 8:26 ` [PATCH v11 3/3] ksm: add mremap selftests for ksm_rmap_walk xu.xin16
2026-07-06 6:55 ` David Hildenbrand (Arm) [this message]
2026-07-05 8:00 ` [PATCH v11 0/3] KSM: performance optimizations for rmap_walk_ksm Andrew Morton
2026-07-06 4:40 ` xu.xin16
2026-07-06 6:49 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb8fd51-d351-48b8-b2e5-5a480a068e11@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=wang.yaxin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox