* [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat
@ 2026-11-16 19:10 Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
DAMOS stat sz_ops_filter_passed shows the total bytes that passed
operations layer-handled DAMOS filters, accumulated from the beginning
of the scheme's execution. Users who want the amount for only the
latest apply interval, e.g., the size of a workload's anonymous memory
that is cold as of now, have to keep the previous value in user space
and compute the difference. To know how many apply intervals a
difference covers, they have to rely on nr_snapshots. But nr_snapshots
is increased once per target per apply interval, so the computation is
complicated for contexts having multiple targets.
This series introduces a new DAMOS stat, sz_ops_filter_passed_last. It
shows the amount of sz_ops_filter_passed increase in the last apply
interval of the scheme. It is updated at the end of each apply
interval, and kept unchanged until the next apply interval is
completed. Like the other DAMOS stats, it is exposed under the stats/
directory of the scheme in the DAMON sysfs interface, and refreshed
together with the other stats when refresh_ms expires or
update_schemes_stats is written.
Patches sequence
================
Patch 1 introduces the stat to the DAMON core. Patch 2 exposes it via
the DAMON sysfs interface. Patch 3 adds a kunit test. Patches 4-6
update the design, usage, and ABI documents, respectively.
Tests
=====
I ran the DAMON kunit tests (all 50 pass, including the new one), built
mm/damon/ with W=1 (no warnings), built htmldocs (no new warnings
compared to mm-new), and ran checkpatch.pl --strict on the patches (it
reports a warning and an error on each patch because it does not
recognize the Assisted-by tag, and four alignment checks on patches 2
and 3 for the continuation line alignment that the existing DAMON code
uses).
I also ran the DAMON selftests in a QEMU VM without KVM, on mm-new and
on mm-new with this series. On mm-new, 12 tests pass, 2 fail
(sysfs_update_schemes_tried_regions_wss_estimation.py and
damos_tried_regions.py), and 1 is skipped (sysfs_memcg_path_leak.sh,
because kmemleak is not available). With this series, 13 pass, 1 fails
(the wss_estimation one), and the same one is skipped, so I saw no
failure that mm-new does not also have.
None of the selftests read the new stat, so I also checked it on a
live kernel. In the same kind of VM running this series, I started two
Docker containers, each running a Python process that allocates 512 MiB
and 2 GiB of anonymous memory and then holds it. Each process was
monitored by its own kdamond, using the vaddr operations set and a
stat scheme with an anon operations layer filter, with refresh_ms set
to 1000. Output from sz_ops_filter_passed_last was correct:
# cd /sys/kernel/mm/damon/admin/kdamonds
# cat 0/contexts/0/schemes/0/stats/sz_ops_filter_passed_last
546385920
# cat 1/contexts/0/schemes/0/stats/sz_ops_filter_passed_last
2157043712
Tool use
========
Claude (Anthropic) assisted with the code, kunit test, documents, and
changelogs of this series, as noted by the Assisted-by: tags. I
reviewed all of it and ran the tests listed above.
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
Mattathias Pinchover (6):
mm/damon/core: introduce sz_ops_filter_passed_last stat
mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file
mm/damon/tests/core-kunit: test sz_ops_filter_passed_last
Docs/mm/damon/design: update for sz_ops_filter_passed_last
Docs/admin-guide/mm/damon/usage: update for sz_ops_filter_passed_last
Docs/ABI/damon: update for sz_ops_filter_passed_last
Documentation/ABI/testing/sysfs-kernel-mm-damon | 7 ++
Documentation/admin-guide/mm/damon/usage.rst | 6 +-
Documentation/mm/damon/design.rst | 9 +++
include/linux/damon.h | 6 ++
mm/damon/core.c | 5 ++
mm/damon/sysfs-schemes.c | 17 +++++
mm/damon/tests/core-kunit.h | 92 +++++++++++++++++++++++++
7 files changed, 139 insertions(+), 3 deletions(-)
---
base-commit: 67f3b04b277373438f17300e056306adbd9edf7b
change-id: 20261113-damon-sz-ops-b4-3857ebdfbcc5
Best regards,
--
Mattathias Pinchover <mattathias.pinchover@uber.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:10 ` Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
From: Mattathias Pinchover <mattathias.pinchover@uber.com>
DAMOS stat sz_ops_filter_passed shows the total bytes that passed
operations layer-handled DAMOS filters, accumulated from the beginning of
the scheme's execution. Users who want the amount for only the latest
apply interval, e.g., the size of a workload's anonymous memory that is
cold as of now, need to keep the previous values in user space and
compute the difference with the help of nr_snapshots. Because
nr_snapshots is increased once per target per apply interval, the
computation is complicated and error-prone, especially for contexts
having multiple targets.
Introduce a new DAMOS stat, sz_ops_filter_passed_last. It is
updated at the end of each apply interval of the scheme with the amount
of sz_ops_filter_passed increase in the interval.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
include/linux/damon.h | 6 ++++++
mm/damon/core.c | 5 +++++
2 files changed, 11 insertions(+)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index 06bd92981af2..3aff5c525132 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -351,6 +351,9 @@ struct damos_watermarks {
* @sz_applied: Total size of regions that the scheme is applied.
* @sz_ops_filter_passed:
* Total bytes that passed ops layer-handled DAMOS filters.
+ * @sz_ops_filter_passed_last:
+ * Bytes that passed ops layer-handled DAMOS filters in the last
+ * apply interval.
* @qt_exceeds: Total number of times the quota of the scheme has exceeded.
* @nr_snapshots:
* Total number of DAMON snapshots that the scheme is completely
@@ -379,6 +382,7 @@ struct damos_stat {
unsigned long nr_applied;
unsigned long sz_applied;
unsigned long sz_ops_filter_passed;
+ unsigned long sz_ops_filter_passed_last;
unsigned long qt_exceeds;
unsigned long nr_snapshots;
};
@@ -578,6 +582,8 @@ struct damos {
* @action
*/
unsigned long next_apply_sis;
+ /* @stat.sz_ops_filter_passed at the start of the current apply interval */
+ unsigned long sz_ops_filter_passed_at_start;
/* informs if ongoing DAMOS walk for this scheme is finished */
bool walk_completed;
/*
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 0a056949604f..6af3309691d4 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -769,6 +769,7 @@ struct damos *damon_new_scheme(struct damos_access_pattern *pattern,
* or damon_attrs are updated.
*/
scheme->next_apply_sis = 0;
+ scheme->sz_ops_filter_passed_at_start = 0;
scheme->walk_completed = false;
INIT_LIST_HEAD(&scheme->core_filters);
INIT_LIST_HEAD(&scheme->ops_filters);
@@ -3533,6 +3534,10 @@ static noinline_for_stack void kdamond_apply_schemes(struct damon_ctx *c)
if (time_before(c->passed_sample_intervals, s->next_apply_sis))
continue;
damos_walk_complete(c, s);
+ s->stat.sz_ops_filter_passed_last =
+ s->stat.sz_ops_filter_passed -
+ s->sz_ops_filter_passed_at_start;
+ s->sz_ops_filter_passed_at_start = s->stat.sz_ops_filter_passed;
damos_set_next_apply_sis(s, c);
s->last_applied = NULL;
damos_trace_stat(c, s);
--
2.54.0-uber3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:10 ` Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
From: Mattathias Pinchover <mattathias.pinchover@uber.com>
Introduce a new DAMON sysfs interface file for exposing the newly added
DAMOS stat, sz_ops_filter_passed_last. The file has the same
name as the stat and is placed under the DAMOS stats directory. Like
other stats files, it is updated when the stats are refreshed via
refresh_ms or the update_schemes_stats command.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
mm/damon/sysfs-schemes.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index 230987efac3a..fe33189e8802 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -370,6 +370,7 @@ struct damon_sysfs_stats {
unsigned long nr_applied;
unsigned long sz_applied;
unsigned long sz_ops_filter_passed;
+ unsigned long sz_ops_filter_passed_last;
unsigned long qt_exceeds;
unsigned long nr_snapshots;
unsigned long max_nr_snapshots;
@@ -425,6 +426,15 @@ static ssize_t sz_ops_filter_passed_show(struct kobject *kobj,
return sysfs_emit(buf, "%lu\n", stats->sz_ops_filter_passed);
}
+static ssize_t sz_ops_filter_passed_last_show(struct kobject *kobj,
+ struct kobj_attribute *attr, char *buf)
+{
+ struct damon_sysfs_stats *stats = container_of(kobj,
+ struct damon_sysfs_stats, kobj);
+
+ return sysfs_emit(buf, "%lu\n", stats->sz_ops_filter_passed_last);
+}
+
static ssize_t qt_exceeds_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
@@ -485,6 +495,10 @@ static struct kobj_attribute damon_sysfs_stats_sz_applied_attr =
static struct kobj_attribute damon_sysfs_stats_sz_ops_filter_passed_attr =
__ATTR_RO_MODE(sz_ops_filter_passed, 0400);
+static struct kobj_attribute
+damon_sysfs_stats_sz_ops_filter_passed_last_attr =
+ __ATTR_RO_MODE(sz_ops_filter_passed_last, 0400);
+
static struct kobj_attribute damon_sysfs_stats_qt_exceeds_attr =
__ATTR_RO_MODE(qt_exceeds, 0400);
@@ -500,6 +514,7 @@ static struct attribute *damon_sysfs_stats_attrs[] = {
&damon_sysfs_stats_nr_applied_attr.attr,
&damon_sysfs_stats_sz_applied_attr.attr,
&damon_sysfs_stats_sz_ops_filter_passed_attr.attr,
+ &damon_sysfs_stats_sz_ops_filter_passed_last_attr.attr,
&damon_sysfs_stats_qt_exceeds_attr.attr,
&damon_sysfs_stats_nr_snapshots_attr.attr,
&damon_sysfs_stats_max_nr_snapshots_attr.attr,
@@ -3130,6 +3145,8 @@ void damon_sysfs_schemes_update_stats(
sysfs_stats->sz_applied = scheme->stat.sz_applied;
sysfs_stats->sz_ops_filter_passed =
scheme->stat.sz_ops_filter_passed;
+ sysfs_stats->sz_ops_filter_passed_last =
+ scheme->stat.sz_ops_filter_passed_last;
sysfs_stats->qt_exceeds = scheme->stat.qt_exceeds;
sysfs_stats->nr_snapshots = scheme->stat.nr_snapshots;
}
--
2.54.0-uber3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:10 ` Mattathias Pinchover via B4 Relay
2026-11-16 19:30 ` sashiko-bot
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
` (2 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
From: Mattathias Pinchover <mattathias.pinchover@uber.com>
Add a kunit test for the sz_ops_filter_passed_last DAMOS
stat. The test runs kdamond_apply_schemes() for multiple apply intervals
with a stub apply_scheme() operation that reports a given ops
filter-passed size, and checks that the stat is set to the value of the
last apply interval rather than the accumulated value, and that it is
kept unchanged until the next apply interval is completed.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
mm/damon/tests/core-kunit.h | 92 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index a5ca4bfe2f0d..ec83598fff0e 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -2541,6 +2541,97 @@ static void damon_test_last_region_quota_reset(struct kunit *test)
damon_destroy_ctx(ctx);
}
+/* bytes that damos_test_apply_scheme_passed_stub() reports per region */
+static unsigned long damos_test_sz_passed;
+
+static unsigned long damos_test_apply_scheme_passed_stub(struct damon_ctx *c,
+ struct damon_target *t, struct damon_region *r,
+ struct damos *s, unsigned long *sz_filter_passed)
+{
+ *sz_filter_passed = damos_test_sz_passed;
+ return 0;
+}
+
+/* run one apply interval and return the last apply interval's passed bytes */
+static unsigned long damos_test_apply_interval(struct damon_ctx *c,
+ struct damos *s)
+{
+ c->passed_sample_intervals = s->next_apply_sis;
+ kdamond_apply_schemes(c);
+ return s->stat.sz_ops_filter_passed_last;
+}
+
+static void damos_test_sz_ops_filter_passed_last(struct kunit *test)
+{
+ struct damos_access_pattern pattern = {
+ .min_sz_region = 0,
+ .max_sz_region = ULONG_MAX,
+ .min_nr_accesses = 0,
+ .max_nr_accesses = UINT_MAX,
+ .min_age_region = 0,
+ .max_age_region = UINT_MAX,
+ };
+ struct damos_watermarks wmarks = {};
+ struct damos_quota quota = {};
+ struct damon_ctx *c;
+ struct damon_target *t;
+ struct damon_region *r;
+ struct damos *s;
+
+ c = damon_new_ctx();
+ if (!c)
+ kunit_skip(test, "ctx alloc fail");
+ c->ops.apply_scheme = damos_test_apply_scheme_passed_stub;
+
+ s = damon_new_scheme(&pattern, DAMOS_STAT, 0, "a, &wmarks,
+ NUMA_NO_NODE);
+ if (!s) {
+ damon_destroy_ctx(c);
+ kunit_skip(test, "scheme alloc fail");
+ }
+ damon_add_scheme(c, s);
+
+ t = damon_new_target();
+ if (!t) {
+ damon_destroy_ctx(c);
+ kunit_skip(test, "target alloc fail");
+ }
+ damon_add_target(c, t);
+
+ r = damon_new_region(0, DAMON_MIN_REGION_SZ);
+ if (!r) {
+ damon_destroy_ctx(c);
+ kunit_skip(test, "region alloc fail");
+ }
+ damon_add_region(r, t);
+
+ KUNIT_EXPECT_EQ(test, s->stat.sz_ops_filter_passed_last, 0);
+
+ /* each value is for the last apply interval only, not cumulative */
+ damos_test_sz_passed = 1000;
+ KUNIT_EXPECT_EQ(test, damos_test_apply_interval(c, s), 1000);
+ KUNIT_EXPECT_EQ(test, damos_test_apply_interval(c, s), 1000);
+ KUNIT_EXPECT_EQ(test, s->stat.sz_ops_filter_passed, 2000);
+
+ damos_test_sz_passed = 300;
+ KUNIT_EXPECT_EQ(test, damos_test_apply_interval(c, s), 300);
+ KUNIT_EXPECT_EQ(test, s->stat.sz_ops_filter_passed, 2300);
+
+ damos_test_sz_passed = 0;
+ KUNIT_EXPECT_EQ(test, damos_test_apply_interval(c, s), 0);
+ KUNIT_EXPECT_EQ(test, s->stat.sz_ops_filter_passed, 2300);
+
+ /* not yet the time to apply, so the last value should be kept */
+ damos_test_sz_passed = 500;
+ damos_test_apply_interval(c, s);
+ c->passed_sample_intervals = s->next_apply_sis - 1;
+ kdamond_apply_schemes(c);
+ KUNIT_EXPECT_EQ(test, s->stat.sz_ops_filter_passed_last,
+ 500);
+
+ damon_destroy_ctx(c);
+}
+
static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_target),
KUNIT_CASE(damon_test_regions),
@@ -2585,6 +2676,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_rand),
KUNIT_CASE(damos_test_esz_goal_temporal),
KUNIT_CASE(damon_test_last_region_quota_reset),
+ KUNIT_CASE(damos_test_sz_ops_filter_passed_last),
{},
};
--
2.54.0-uber3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
` (2 preceding siblings ...)
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:10 ` Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
5 siblings, 0 replies; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
From: Mattathias Pinchover <mattathias.pinchover@uber.com>
Update DAMON design document for the newly added DAMOS stat,
sz_ops_filter_passed_last. Also explain that, unlike other
stats, it is not accumulated from the beginning of the scheme's
execution but shows the value of the last apply interval.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
Documentation/mm/damon/design.rst | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
index b676be697158..e40b8c1a3461 100644
--- a/Documentation/mm/damon/design.rst
+++ b/Documentation/mm/damon/design.rst
@@ -876,6 +876,8 @@ scheme's execution.
- ``sz_tried``: Total size of regions that the scheme is tried to be applied.
- ``sz_ops_filter_passed``: Total bytes that passed operations set
layer-handled DAMOS filters.
+- ``sz_ops_filter_passed_last``: Bytes that passed operations set
+ layer-handled DAMOS filters in the last ``apply_interval``.
- ``nr_applied``: Total number of regions that the scheme is applied.
- ``sz_applied``: Total size of regions that the scheme is applied.
- ``qt_exceeds``: Total number of times the quota of the scheme has exceeded.
@@ -903,6 +905,13 @@ to exclude anonymous pages and the region has only anonymous pages, or if the
action is ``pageout`` while all pages of the region are unreclaimable, applying
the action to the region will fail.
+Unlike other stats, ``sz_ops_filter_passed_last`` is not
+accumulated from the beginning of the scheme's execution. It is updated at the
+end of each :ref:`apply_interval <damon_design_damos>` with the amount of
+``sz_ops_filter_passed`` increase in the interval. Hence it shows the size of
+memory that passed the operations set layer-handled filters in the last
+completed ``apply_interval``.
+
Unlike normal stats, ``max_nr_snapshots`` is set by users. If it is set as
non-zero and ``nr_snapshots`` equals or is greater than ``max_nr_snapshots``,
the scheme is deactivated. Note that, unlike watermarks, even if a scheme's
--
2.54.0-uber3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 5/6] Docs/admin-guide/mm/damon/usage: update for sz_ops_filter_passed_last
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
` (3 preceding siblings ...)
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:10 ` Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
5 siblings, 0 replies; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
From: Mattathias Pinchover <mattathias.pinchover@uber.com>
Update DAMON usage document for the newly added DAMOS stat file,
sz_ops_filter_passed_last.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
Documentation/admin-guide/mm/damon/usage.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst
index 6093b1c8fbfd..c0101a68a033 100644
--- a/Documentation/admin-guide/mm/damon/usage.rst
+++ b/Documentation/admin-guide/mm/damon/usage.rst
@@ -105,7 +105,7 @@ comma (",").
│ │ │ │ │ │ │ │ 0/type,matching,allow,memcg_path,addr_start,addr_end,damon_target_idx,min,max
│ │ │ │ │ │ │ :ref:`dests <damon_sysfs_dests>`/nr_dests
│ │ │ │ │ │ │ │ 0/id,weight
- │ │ │ │ │ │ │ :ref:`stats <sysfs_schemes_stats>`/nr_tried,sz_tried,nr_applied,sz_applied,sz_ops_filter_passed,qt_exceeds,nr_snapshots,max_nr_snapshots
+ │ │ │ │ │ │ │ :ref:`stats <sysfs_schemes_stats>`/nr_tried,sz_tried,nr_applied,sz_applied,sz_ops_filter_passed,sz_ops_filter_passed_last,qt_exceeds,nr_snapshots,max_nr_snapshots
│ │ │ │ │ │ │ :ref:`tried_regions <sysfs_schemes_tried_regions>`/total_bytes
│ │ │ │ │ │ │ │ 0/start,end,nr_accesses,age,sz_filter_passed
│ │ │ │ │ │ │ │ │ probes
@@ -631,8 +631,8 @@ online analysis or tuning of the schemes. Refer to :ref:`design doc
The statistics can be retrieved by reading the files under ``stats`` directory
(``nr_tried``, ``sz_tried``, ``nr_applied``, ``sz_applied``,
-``sz_ops_filter_passed``, ``qt_exceeds``, ``nr_snapshots`` and
-``max_nr_snapshots``), respectively.
+``sz_ops_filter_passed``, ``sz_ops_filter_passed_last``,
+``qt_exceeds``, ``nr_snapshots`` and ``max_nr_snapshots``), respectively.
The files are not updated in real time by default. Users should ask DAMON
sysfs interface to periodically update those using ``refresh_ms``, or do a one
--
2.54.0-uber3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 6/6] Docs/ABI/damon: update for sz_ops_filter_passed_last
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
` (4 preceding siblings ...)
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:10 ` Mattathias Pinchover via B4 Relay
5 siblings, 0 replies; 8+ messages in thread
From: Mattathias Pinchover via B4 Relay @ 2026-11-16 19:10 UTC (permalink / raw)
To: SJ Park, Andrew Morton, Jonathan Corbet, Shuah Khan, Randy Dunlap
Cc: damon, linux-mm, linux-kernel, linux-doc, Mattathias Pinchover
From: Mattathias Pinchover <mattathias.pinchover@uber.com>
Update DAMON ABI document for the newly added DAMOS stat file,
sz_ops_filter_passed_last.
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
---
Documentation/ABI/testing/sysfs-kernel-mm-damon | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
index 4acb2015c2f4..92348178e48a 100644
--- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
+++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
@@ -623,6 +623,13 @@ Contact: SJ Park <sj@kernel.org>
Description: Reading this file returns the total size of memory that passed
DAMON operations layer-handled filters of the scheme in bytes.
+What: /sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/stats/sz_ops_filter_passed_last
+Date: Nov 2026
+Contact: SJ Park <sj@kernel.org>
+Description: Reading this file returns the size of memory that passed DAMON
+ operations layer-handled filters of the scheme in bytes, in the
+ last apply interval of the scheme.
+
What: /sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/schemes/<S>/stats/qt_exceeds
Date: Mar 2022
Contact: SJ Park <sj@kernel.org>
--
2.54.0-uber3
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
@ 2026-11-16 19:30 ` sashiko-bot
0 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-11-16 19:30 UTC (permalink / raw)
To: Mattathias Pinchover, SJ Park, Andrew Morton, Jonathan Corbet,
Shuah Khan, Randy Dunlap
Cc: damon, linux-mm
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mm/damon: uninitialized core_filters_default_reject read in
kunit test
--
commit 64315024865456d25a50aac3fbbdfa4d480bec80
Author: Mattathias Pinchover <mattathias.pinchover@uber.com>
mm/damon/tests/core-kunit: test sz_ops_filter_passed_last
This commit adds a KUnit test verifying that s->stat.sz_ops_filter_passed_last
records the ops filter-passed size for the last apply interval and remains
unchanged between apply intervals.
> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index a5ca4bfe2f0db..ec83598fff0e6 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
> @@ -2541,6 +2541,97 @@ static void damon_test_last_region_quota_reset(struct kunit *test)
[ ... ]
> +static void damos_test_sz_ops_filter_passed_last(struct kunit *test)
> +{
[ ... ]
> + c = damon_new_ctx();
> + if (!c)
> + kunit_skip(test, "ctx alloc fail");
> + c->ops.apply_scheme = damos_test_apply_scheme_passed_stub;
> +
> + s = damon_new_scheme(&pattern, DAMOS_STAT, 0, "a, &wmarks,
> + NUMA_NO_NODE);
> + if (!s) {
> + damon_destroy_ctx(c);
> + kunit_skip(test, "scheme alloc fail");
> + }
> + damon_add_scheme(c, s);
[Severity: Medium]
Does this leave s->core_filters_default_reject uninitialized before
kdamond_apply_schemes() runs?
damon_new_scheme() allocates struct damos with kmalloc_obj() without
initializing core_filters_default_reject, and damon_add_scheme() does not
set it either. When damos_test_apply_interval() runs
kdamond_apply_schemes() -> damos_apply_scheme() -> damos_core_filter_out()
with an empty s->core_filters list, damos_core_filter_out() returns
s->core_filters_default_reject directly.
If that slab byte is non-zero (for example when reusing a struct damos
freed by an earlier test in damon_test_cases[] that set
core_filters_default_reject to true), damos_apply_scheme() filters out the
region before calling c->ops.apply_scheme(), causing KMSAN/UBSAN warnings
and false test failures with s->stat.sz_ops_filter_passed_last remaining 0.
Calling damos_set_filters_default_reject(s) after damon_add_scheme(c, s),
as in damos_test_apply_scheme_quota_sz(), initializes the field.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-damon-sz-ops-b4-v1-0-1cffe7227e6d@uber.com?part=3
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-11-16 19:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:30 ` sashiko-bot
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox