Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] alloc_tag: Use __ prefixed ELF section names
@ 2026-11-18 13:27 Ard Biesheuvel
  2026-11-19 13:27 ` sashiko-bot
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2026-11-18 13:27 UTC (permalink / raw)
  To: linux-mm; +Cc: Ard Biesheuvel, Suren Baghdasaryan, Kent Overstreet, Hao Ge

From: Ard Biesheuvel <ardb@kernel.org>

The compiler will emit static relocations related to a section .foo into
a separate section called .rela.foo, i.e., it just appends the section
name to the string ".rela"

When section names start with . or __, this results in relocation
section names that are correctly matched by the various pattern rules in
the various linker scripts across the tree.

Without any such leading delimiter, it may lead to spurious warnings
such as

  >> ld: warning: orphan section `.relaalloc_tags' from `init/main.o' being placed in section `.rela.dyn'
     ld: warning: dot moved backwards before `.rela.dyn'
     ld: .tmp_vmlinux1: section `.rela.dyn' can't be allocated in segment 1

Fix this by renaming the section to __alloc_tags. While at it, tweak the
headers so that the definition of the name appears only a single time.

Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Kent Overstreet <kent.overstreet@linux.dev>
Cc: Hao Ge <hao.ge@linux.dev>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 include/asm-generic/codetag.lds.h | 14 +++++++++-----
 include/linux/alloc_tag.h         | 11 ++++++-----
 mm/alloc_tag.c                    |  6 +++---
 3 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/include/asm-generic/codetag.lds.h b/include/asm-generic/codetag.lds.h
index 4948e5d4e9d9..443e3a8fa60b 100644
--- a/include/asm-generic/codetag.lds.h
+++ b/include/asm-generic/codetag.lds.h
@@ -2,6 +2,10 @@
 #ifndef __ASM_GENERIC_CODETAG_LDS_H
 #define __ASM_GENERIC_CODETAG_LDS_H
 
+#include <linux/compiler_types.h>
+
+#define ALLOC_TAG_SECTION_NAME	__alloc_tags
+
 #ifdef CONFIG_MEM_ALLOC_PROFILING
 #define IF_MEM_ALLOC_PROFILING(...) __VA_ARGS__
 #else
@@ -10,15 +14,15 @@
 
 #define SECTION_WITH_BOUNDARIES(_name)	\
 	. = ALIGN(8);			\
-	__start_##_name = .;		\
+	__PASTE(__start_, _name) = .;	\
 	KEEP(*(_name))			\
-	__stop_##_name = .;
+	__PASTE(__stop_, _name) = .;
 
 #define CODETAG_SECTIONS()		\
-	IF_MEM_ALLOC_PROFILING(SECTION_WITH_BOUNDARIES(alloc_tags))
+	IF_MEM_ALLOC_PROFILING(SECTION_WITH_BOUNDARIES(ALLOC_TAG_SECTION_NAME))
 
 #define MOD_SEPARATE_CODETAG_SECTION(_name)	\
-	.codetag.##_name 0 : {			\
+	.codetag._name 0 : {			\
 		SECTION_WITH_BOUNDARIES(_name)	\
 	}
 
@@ -28,6 +32,6 @@
  * unload them individually once unused.
  */
 #define MOD_SEPARATE_CODETAG_SECTIONS()		\
-	IF_MEM_ALLOC_PROFILING(MOD_SEPARATE_CODETAG_SECTION(alloc_tags))
+	IF_MEM_ALLOC_PROFILING(MOD_SEPARATE_CODETAG_SECTION(ALLOC_TAG_SECTION_NAME))
 
 #endif /* __ASM_GENERIC_CODETAG_LDS_H */
diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h
index 7f2d80a59792..0703592a3302 100644
--- a/include/linux/alloc_tag.h
+++ b/include/linux/alloc_tag.h
@@ -15,6 +15,9 @@
 #include <linux/static_key.h>
 #include <linux/irqflags.h>
 
+/* for ALLOC_TAG_SECTION_NAME */
+#include <asm-generic/codetag.lds.h>
+
 struct alloc_tag_counters {
 	u64 bytes;
 	u64 calls;
@@ -74,8 +77,6 @@ static inline void set_codetag_empty(union codetag_ref *ref)
 
 #ifdef CONFIG_MEM_ALLOC_PROFILING
 
-#define ALLOC_TAG_SECTION_NAME	"alloc_tags"
-
 struct codetag_bytes {
 	struct codetag *ct;
 	s64 bytes;
@@ -98,7 +99,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 
 #define DEFINE_ALLOC_TAG(_alloc_tag)						\
 	static struct alloc_tag _alloc_tag __used __aligned(8)			\
-	__section(ALLOC_TAG_SECTION_NAME) = {					\
+	__section(__stringify(ALLOC_TAG_SECTION_NAME)) = {			\
 		.ct = CODE_TAG_INIT,						\
 		.counters = &_shared_alloc_tag };
 
@@ -108,7 +109,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 
 #define DEFINE_ALLOC_TAG(_alloc_tag)						\
 	static struct alloc_tag _alloc_tag __used __aligned(8)			\
-	__section(ALLOC_TAG_SECTION_NAME) = {					\
+	__section(__stringify(ALLOC_TAG_SECTION_NAME)) = {			\
 		.ct = CODE_TAG_INIT,						\
 		.counters = NULL };
 
@@ -117,7 +118,7 @@ DECLARE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag);
 #define DEFINE_ALLOC_TAG(_alloc_tag)						\
 	static DEFINE_PER_CPU(struct alloc_tag_counters, _alloc_tag_cntr);	\
 	static struct alloc_tag _alloc_tag __used __aligned(8)			\
-	__section(ALLOC_TAG_SECTION_NAME) = {					\
+	__section(__stringify(ALLOC_TAG_SECTION_NAME)) = {			\
 		.ct = CODE_TAG_INIT,						\
 		.counters = &_alloc_tag_cntr };
 
diff --git a/mm/alloc_tag.c b/mm/alloc_tag.c
index 82e2c3448dcf..4c13483e68b6 100644
--- a/mm/alloc_tag.c
+++ b/mm/alloc_tag.c
@@ -23,8 +23,8 @@
 
 #define ALLOCINFO_FILE_NAME		"allocinfo"
 #define MODULE_ALLOC_TAG_VMAP_SIZE	(100000UL * sizeof(struct alloc_tag))
-#define SECTION_START(NAME)		(CODETAG_SECTION_START_PREFIX NAME)
-#define SECTION_STOP(NAME)		(CODETAG_SECTION_STOP_PREFIX NAME)
+#define SECTION_START(NAME)		(CODETAG_SECTION_START_PREFIX #NAME)
+#define SECTION_STOP(NAME)		(CODETAG_SECTION_STOP_PREFIX #NAME)
 
 #ifdef CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT
 static bool mem_profiling_support = true;
@@ -1322,7 +1322,7 @@ static inline void sysctl_init(void) {}
 static int __init alloc_tag_init(void)
 {
 	const struct codetag_type_desc desc = {
-		.section		= ALLOC_TAG_SECTION_NAME,
+		.section		= __stringify(ALLOC_TAG_SECTION_NAME),
 		.tag_size		= sizeof(struct alloc_tag),
 #ifdef CONFIG_MODULES
 		.needs_section_mem	= needs_section_mem,
-- 
2.56.1.703.gf848ed807c-goog



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] alloc_tag: Use __ prefixed ELF section names
  2026-11-18 13:27 [PATCH] alloc_tag: Use __ prefixed ELF section names Ard Biesheuvel
@ 2026-11-19 13:27 ` sashiko-bot
  2026-11-19 14:03   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-11-19 13:27 UTC (permalink / raw)
  To: Ard Biesheuvel, linux-mm
  Cc: Ard Biesheuvel, Suren Baghdasaryan, Kent Overstreet, Hao Ge

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] alloc_tag: SECTION_START() and SECTION_STOP() fail to expand
  macro argument
- [Low] alloc_tag: missing Fixes: trailer for unprefixed alloc_tags
  section name
--

commit 933587991e6a16ab600445b22347397f80335de9
Author: Ard Biesheuvel <ardb@kernel.org>

> alloc_tag: Use __ prefixed ELF section names
>
> The compiler will emit static relocations related to a section .foo into
> a separate section called .rela.foo, i.e., it just appends the section
> name to the string ".rela"
>
> When section names start with . or __, this results in relocation
> section names that are correctly matched by the various pattern rules in
> the various linker scripts across the tree.
>
> Without any such leading delimiter, it may lead to spurious warnings
> such as
>
>   >> ld: warning: orphan section `.relaalloc_tags' from `init/main.o' being placed in section `.rela.dyn'
>      ld: warning: dot moved backwards before `.rela.dyn'
>      ld: .tmp_vmlinux1: section `.rela.dyn' can't be allocated in segment 1
>
> Fix this by renaming the section to __alloc_tags. While at it, tweak the
> headers so that the definition of the name appears only a single time.
>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Kent Overstreet <kent.overstreet@linux.dev>
> Cc: Hao Ge <hao.ge@linux.dev>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

[Severity: Low]
This fixes the unprefixed alloc_tags section name.  Should it include:

  Fixes: 22d407b164ff ("lib: add allocation tagging support for memory allocation profiling")

> diff --git a/mm/alloc_tag.c b/mm/alloc_tag.c
> index e9b70268eacb0..00a68ab0c409a 100644
> --- a/mm/alloc_tag.c
> +++ b/mm/alloc_tag.c
> @@ -26,8 +26,8 @@
>  
>  #define ALLOCINFO_FILE_NAME		"allocinfo"
>  #define MODULE_ALLOC_TAG_VMAP_SIZE	(100000UL * sizeof(struct alloc_tag))
> -#define SECTION_START(NAME)		(CODETAG_SECTION_START_PREFIX NAME)
> -#define SECTION_STOP(NAME)		(CODETAG_SECTION_STOP_PREFIX NAME)
> +#define SECTION_START(NAME)		(CODETAG_SECTION_START_PREFIX #NAME)
> +#define SECTION_STOP(NAME)		(CODETAG_SECTION_STOP_PREFIX #NAME)

[Severity: High]
Does #NAME in SECTION_START() and SECTION_STOP() stringify the macro name
"ALLOC_TAG_SECTION_NAME" instead of expanding it to "__alloc_tags"?

In alloc_tag_sec_init(), kallsyms_lookup_name() will look up
"__start_ALLOC_TAG_SECTION_NAME" and "__stop_ALLOC_TAG_SECTION_NAME"
instead of "__start___alloc_tags" and "__stop___alloc_tags", returning 0
for both.  When compressed page allocation profiling is enabled
(sysctl.vm.mem_profiling=1,compressed), kernel_tags.count remains 0,
causing idx_to_ref() and ref_to_idx() to misclassify built-in kernel tags
as module tags and dereference an invalid module_tags.first_tag pointer on
page allocation or free.

Using __stringify(NAME) instead of #NAME would expand the argument first.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118132719.632451-2-ardb+git@google.com?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] alloc_tag: Use __ prefixed ELF section names
  2026-11-19 13:27 ` sashiko-bot
@ 2026-11-19 14:03   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2026-11-19 14:03 UTC (permalink / raw)
  To: sashiko-reviews, Ard Biesheuvel, linux-mm
  Cc: Suren Baghdasaryan, Kent Overstreet, Hao Ge



On Thu, 19 Nov 2026, at 14:27, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issues to consider:
> - [High] alloc_tag: SECTION_START() and SECTION_STOP() fail to expand
>   macro argument
> - [Low] alloc_tag: missing Fixes: trailer for unprefixed alloc_tags
>   section name
> --
>
> commit 933587991e6a16ab600445b22347397f80335de9
> Author: Ard Biesheuvel <ardb@kernel.org>
>
>> alloc_tag: Use __ prefixed ELF section names
>>
>> The compiler will emit static relocations related to a section .foo into
>> a separate section called .rela.foo, i.e., it just appends the section
>> name to the string ".rela"
>>
>> When section names start with . or __, this results in relocation
>> section names that are correctly matched by the various pattern rules in
>> the various linker scripts across the tree.
>>
>> Without any such leading delimiter, it may lead to spurious warnings
>> such as
>>
>>   >> ld: warning: orphan section `.relaalloc_tags' from `init/main.o' being placed in section `.rela.dyn'
>>      ld: warning: dot moved backwards before `.rela.dyn'
>>      ld: .tmp_vmlinux1: section `.rela.dyn' can't be allocated in segment 1
>>
>> Fix this by renaming the section to __alloc_tags. While at it, tweak the
>> headers so that the definition of the name appears only a single time.
>>
>> Cc: Suren Baghdasaryan <surenb@google.com>
>> Cc: Kent Overstreet <kent.overstreet@linux.dev>
>> Cc: Hao Ge <hao.ge@linux.dev>
>> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
>
...
> Does #NAME in SECTION_START() and SECTION_STOP() stringify the macro name
> "ALLOC_TAG_SECTION_NAME" instead of expanding it to "__alloc_tags"?
>
> In alloc_tag_sec_init(), kallsyms_lookup_name() will look up
> "__start_ALLOC_TAG_SECTION_NAME" and "__stop_ALLOC_TAG_SECTION_NAME"
> instead of "__start___alloc_tags" and "__stop___alloc_tags", returning 0
> for both.  When compressed page allocation profiling is enabled
> (sysctl.vm.mem_profiling=1,compressed), kernel_tags.count remains 0,
> causing idx_to_ref() and ref_to_idx() to misclassify built-in kernel tags
> as module tags and dereference an invalid module_tags.first_tag pointer on
> page allocation or free.
>
> Using __stringify(NAME) instead of #NAME would expand the argument first.
>

Ugh the token pasting stuff always confuses me - I'll fold this in for v2.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19 14:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 13:27 [PATCH] alloc_tag: Use __ prefixed ELF section names Ard Biesheuvel
2026-11-19 13:27 ` sashiko-bot
2026-11-19 14:03   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox