From: Doug Brown <doug@schmorgal.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1
Date: Mon, 28 Nov 2022 19:44:46 -0800 [thread overview]
Message-ID: <08abea27-a751-d861-c526-80b41dd72ff2@schmorgal.com> (raw)
In-Reply-To: <263b5e29-f0b4-27b4-a753-592153edc3c3@linaro.org>
Hi Krzysztof and Rob,
On 11/28/2022 12:58 AM, Krzysztof Kozlowski wrote:
> No need for minItems.
>
> Start with capital letter if this is a sentence with full stop. It's
> anyway looking different then the rest of the file, right?
>
> Why maxItems: 1? What if one wants to add here more entries? Drop maxItems.
>
> Ditto
Thanks for the fast review. Will fix this all in V2 after I receive
feedback on the other patches. I was trying to follow the pattern from
another similar schema and didn't fully understand.
On 11/28/2022 4:20 AM, Rob Herring wrote:
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13)
Well this is embarrassing! I forgot to run dt_binding_check. Sorry about
that.
Doug
next prev parent reply other threads:[~2022-11-29 3:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:43 [PATCH 0/8] mmc: sdhci-pxav2: Add support for PXA168 Doug Brown
2022-11-28 2:44 ` [PATCH 1/8] mmc: sdhci-pxav2: add initial support for PXA168 V1 controller Doug Brown
2022-11-28 2:44 ` [PATCH 2/8] mmc: sdhci-pxav2: enable CONFIG_MMC_SDHCI_IO_ACCESSORS Doug Brown
2022-11-28 2:44 ` [PATCH 3/8] mmc: sdhci-pxav2: add register workaround for PXA168 silicon bug Doug Brown
2022-11-29 6:31 ` Adrian Hunter
2022-11-28 2:44 ` [PATCH 4/8] mmc: sdhci-pxav2: change clock name to match DT bindings Doug Brown
2022-11-28 2:44 ` [PATCH 5/8] mmc: sdhci-pxav2: add optional core clock Doug Brown
2022-11-28 2:44 ` [PATCH 6/8] mmc: sdhci-pxav2: add SDIO card IRQ workaround for PXA168 V1 controller Doug Brown
2022-11-29 7:29 ` Adrian Hunter
2022-12-01 5:27 ` Doug Brown
2022-11-28 2:44 ` [PATCH 7/8] mmc: sdhci-pxav2: add optional pinctrl for SDIO IRQ workaround Doug Brown
2022-11-28 2:44 ` [PATCH 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1 Doug Brown
2022-11-28 8:58 ` Krzysztof Kozlowski
2022-11-29 3:44 ` Doug Brown [this message]
2022-11-28 12:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08abea27-a751-d861-c526-80b41dd72ff2@schmorgal.com \
--to=doug@schmorgal.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox