From: Doug Brown <doug@schmorgal.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
Doug Brown <doug@schmorgal.com>
Subject: [PATCH 0/8] mmc: sdhci-pxav2: Add support for PXA168
Date: Sun, 27 Nov 2022 18:43:59 -0800 [thread overview]
Message-ID: <20221128024407.224393-1-doug@schmorgal.com> (raw)
This is a revival of an earlier patch series from 2013 to add support
for the PXA168 SDHC controller, with an additional SDIO IRQ errata fix.
It also cleans up the clock naming to be consistent with the existing DT
schema shared with the pxav3 driver (in a backwards-compatible way).
Here is the original patch series this is based on:
https://lore.kernel.org/linux-mmc/1363544206-3671-1-git-send-email-tanmay.upadhyay@einfochips.com/
Note that I left out the platform_specific_completion and clock gating
changes from the original patches. They both seemed controversial, and
don't seem necessary based on my testing. I've been running this code on
a PXA168 for months without any issues.
The SDIO IRQ workaround of sending a dummy CMD0 isn't pretty, but it
works just as the errata said it would. Should I export sdhci_post_req
and refer to it directly, rather than saving a pointer to it in this
driver like I'm doing now? Or is there a cleaner way to send the dummy
command after every SDIO command? It felt hacky, but I wasn't sure how
else to do it.
Doug Brown (8):
mmc: sdhci-pxav2: add initial support for PXA168 V1 controller
mmc: sdhci-pxav2: enable CONFIG_MMC_SDHCI_IO_ACCESSORS
mmc: sdhci-pxav2: add register workaround for PXA168 silicon bug
mmc: sdhci-pxav2: change clock name to match DT bindings
mmc: sdhci-pxav2: add optional core clock
mmc: sdhci-pxav2: add SDIO card IRQ workaround for PXA168 V1
controller
mmc: sdhci-pxav2: add optional pinctrl for SDIO IRQ workaround
dt-bindings: mmc: sdhci-pxa: add pxav1
.../devicetree/bindings/mmc/sdhci-pxa.yaml | 22 ++-
drivers/mmc/host/Kconfig | 1 +
drivers/mmc/host/sdhci-pxav2.c | 138 +++++++++++++++++-
3 files changed, 154 insertions(+), 7 deletions(-)
--
2.34.1
next reply other threads:[~2022-11-28 2:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 2:43 Doug Brown [this message]
2022-11-28 2:44 ` [PATCH 1/8] mmc: sdhci-pxav2: add initial support for PXA168 V1 controller Doug Brown
2022-11-28 2:44 ` [PATCH 2/8] mmc: sdhci-pxav2: enable CONFIG_MMC_SDHCI_IO_ACCESSORS Doug Brown
2022-11-28 2:44 ` [PATCH 3/8] mmc: sdhci-pxav2: add register workaround for PXA168 silicon bug Doug Brown
2022-11-29 6:31 ` Adrian Hunter
2022-11-28 2:44 ` [PATCH 4/8] mmc: sdhci-pxav2: change clock name to match DT bindings Doug Brown
2022-11-28 2:44 ` [PATCH 5/8] mmc: sdhci-pxav2: add optional core clock Doug Brown
2022-11-28 2:44 ` [PATCH 6/8] mmc: sdhci-pxav2: add SDIO card IRQ workaround for PXA168 V1 controller Doug Brown
2022-11-29 7:29 ` Adrian Hunter
2022-12-01 5:27 ` Doug Brown
2022-11-28 2:44 ` [PATCH 7/8] mmc: sdhci-pxav2: add optional pinctrl for SDIO IRQ workaround Doug Brown
2022-11-28 2:44 ` [PATCH 8/8] dt-bindings: mmc: sdhci-pxa: add pxav1 Doug Brown
2022-11-28 8:58 ` Krzysztof Kozlowski
2022-11-29 3:44 ` Doug Brown
2022-11-28 12:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128024407.224393-1-doug@schmorgal.com \
--to=doug@schmorgal.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox