From: Vinod Koul <vkoul@infradead.org>
To: Dan Williams <djbw@fb.com>
Cc: vinod.koul@intel.com, Matt Porter <mporter@ti.com>,
Chris Ball <cjb@laptop.org>,
Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()
Date: Wed, 24 Oct 2012 08:39:01 +0530 [thread overview]
Message-ID: <1351048141.5263.5.camel@vkoul-udesk3> (raw)
In-Reply-To: <CAA9_cmdVfbO+T0iSEf4uTPcejx1Mx+aQ5LidYZkJ89dVR=ydXw@mail.gmail.com>
On Tue, 2012-10-23 at 15:54 -0700, Dan Williams wrote:
> > +struct dmaengine_chan_caps {
> > + enum dmaengine_apis ops;
> > + int seg_nr;
> > + int seg_len;
> > +};
>
> This makes sense for the potentially dynamic capability properties
> that get set after configuration, but why do we need the operation
> types here? They can be retrieved from the parent device.
I was thinking that each channel can have different capabilities.
You can assign one channel for mempcy operations exclusively and some
others for slave usage exclusively.
I believe some h/w do have such assignment so would help in doing that.
--
Vinod Koul
Intel Corp.
next prev parent reply other threads:[~2012-10-24 3:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 2:51 [RFC PATCH 0/3] dmaengine: add per channel capabilities api Matt Porter
2012-10-19 2:51 ` [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps() Matt Porter
2012-10-23 22:38 ` Grant Likely
2012-10-23 22:49 ` Grant Likely
2012-10-24 3:13 ` Vinod Koul
2013-01-10 1:59 ` Matt Porter
2012-10-23 22:54 ` Dan Williams
2012-10-24 3:09 ` Vinod Koul [this message]
2012-10-19 2:51 ` [RFC PATCH 2/3] dma: edma: add device_channel_caps() support Matt Porter
2012-10-19 2:51 ` [RFC PATCH 3/3] mmc: davinci: get SG segment limits with dma_get_channel_caps() Matt Porter
2012-10-23 22:41 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351048141.5263.5.camel@vkoul-udesk3 \
--to=vkoul@infradead.org \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=djbw@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mporter@ti.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox