From: Vinod Koul <vkoul@infradead.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: vinod.koul@intel.com, Matt Porter <mporter@ti.com>,
Dan Williams <djbw@fb.com>, Chris Ball <cjb@laptop.org>,
Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>
Subject: Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()
Date: Wed, 24 Oct 2012 08:43:27 +0530 [thread overview]
Message-ID: <1351048407.5263.10.camel@vkoul-udesk3> (raw)
In-Reply-To: <CACxGe6sUrXPc2wtLfOy8_LvRMM+e=9=sSDNLkeszfe=JX_ipbw@mail.gmail.com>
On Tue, 2012-10-23 at 23:49 +0100, Grant Likely wrote:
> > +enum dmaengine_apis {
> > + DMAENGINE_MEMCPY = 0x0001,
> > + DMAENGINE_XOR = 0x0002,
> > + DMAENGINE_XOR_VAL = 0x0004,
> > + DMAENGINE_PQ = 0x0008,
> > + DMAENGINE_PQ_VAL = 0x0010,
> > + DMAENGINE_MEMSET = 0x0020,
> > + DMAENGINE_SLAVE = 0x0040,
> > + DMAENGINE_CYCLIC = 0x0080,
> > + DMAENGINE_INTERLEAVED = 0x0100,
> > + DMAENGINE_SG = 0x0200,
> > +};
>
> Actually, one more comment. Why the new enum? Why can't the
> dma_transaction_type enum be used directly along with dma_cap_mask_t?
Some of the capabilities above are not there in dma_caps_t like DMA_SG.
Also DMA_INTERRUPT and DMA_PRIVATE would not make much sense here.
BUT would help to keep things simpler if have one definition which
includes all.
--
Vinod Koul
Intel Corp.
next prev parent reply other threads:[~2012-10-24 3:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 2:51 [RFC PATCH 0/3] dmaengine: add per channel capabilities api Matt Porter
2012-10-19 2:51 ` [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps() Matt Porter
2012-10-23 22:38 ` Grant Likely
2012-10-23 22:49 ` Grant Likely
2012-10-24 3:13 ` Vinod Koul [this message]
2013-01-10 1:59 ` Matt Porter
2012-10-23 22:54 ` Dan Williams
2012-10-24 3:09 ` Vinod Koul
2012-10-19 2:51 ` [RFC PATCH 2/3] dma: edma: add device_channel_caps() support Matt Porter
2012-10-19 2:51 ` [RFC PATCH 3/3] mmc: davinci: get SG segment limits with dma_get_channel_caps() Matt Porter
2012-10-23 22:41 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351048407.5263.10.camel@vkoul-udesk3 \
--to=vkoul@infradead.org \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=djbw@fb.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mporter@ti.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox