* Re: [PATCH] mmc: dw_mmc: Add MSHC compatible for Exynos4412
2013-01-23 15:24 [PATCH] mmc: dw_mmc: Add MSHC compatible for Exynos4412 Dongjin Kim
@ 2013-01-24 2:41 ` Jaehoon Chung
2013-01-24 3:01 ` Dongjin Kim
2013-01-24 18:20 ` [PATCH v2] " Dongjin Kim
1 sibling, 1 reply; 4+ messages in thread
From: Jaehoon Chung @ 2013-01-24 2:41 UTC (permalink / raw)
To: Dongjin Kim
Cc: unlisted-recipients: ;Chris Ball, Arnd Bergmann, Thomas Abraham,
Will Newton, linux-mmc, linux-kernel
On 01/24/2013 12:24 AM, Dongjin Kim wrote:
> This patch adds the compatible string for MSHC controller of Exynos4412, and
> reuse the controller specific properties with Exynos5250 since those have same
> features.
>
> Signed-off-by: Dongjin Kim <tobetter@gmail.com>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 0cb9bcb..4f7685f 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -204,6 +204,8 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
> };
>
> static const struct of_device_id dw_mci_exynos_match[] = {
> + { .compatible = "samsung,exynos4412-dw-mshc",
> + .data = &exynos5250_drv_data, },
If we can use the same drv_data, should be changed to more generic name, not "exynos5250_".
Best Regards,
Jaehoon Chung
> { .compatible = "samsung,exynos5250-dw-mshc",
> .data = &exynos5250_drv_data, },
> {},
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] mmc: dw_mmc: Add MSHC compatible for Exynos4412
2013-01-23 15:24 [PATCH] mmc: dw_mmc: Add MSHC compatible for Exynos4412 Dongjin Kim
2013-01-24 2:41 ` Jaehoon Chung
@ 2013-01-24 18:20 ` Dongjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Dongjin Kim @ 2013-01-24 18:20 UTC (permalink / raw)
Cc: Dongjin Kim, Chris Ball, Arnd Bergmann, Thomas Abraham,
Will Newton, linux-mmc, linux-kernel
This patch adds the compatible string for MSHC controller of Exynos4412, and
share the controller specific properties with Exynos5250 since they have same
features. Its driver data name is changed to exynos5_drv_data not to use SoC
specific name.
Signed-off-by: Dongjin Kim <tobetter@gmail.com>
---
drivers/mmc/host/dw_mmc-exynos.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 4d50da6..8238a00 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -199,8 +199,8 @@ static int dw_mci_exynos_setup_bus(struct dw_mci *host,
return 0;
}
-/* Exynos5250 controller specific capabilities */
-static unsigned long exynos5250_dwmmc_caps[4] = {
+/* Exynos4412/Exynos5250 controller specific capabilities */
+static unsigned long exynos5_dwmmc_caps[4] = {
MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR |
MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23,
MMC_CAP_CMD23,
@@ -208,8 +208,8 @@ static unsigned long exynos5250_dwmmc_caps[4] = {
MMC_CAP_CMD23,
};
-static const struct dw_mci_drv_data exynos5250_drv_data = {
- .caps = exynos5250_dwmmc_caps,
+static const struct dw_mci_drv_data exynos5_drv_data = {
+ .caps = exynos5_dwmmc_caps,
.init = dw_mci_exynos_priv_init,
.setup_clock = dw_mci_exynos_setup_clock,
.prepare_command = dw_mci_exynos_prepare_command,
@@ -219,8 +219,10 @@ static const struct dw_mci_drv_data exynos5250_drv_data = {
};
static const struct of_device_id dw_mci_exynos_match[] = {
+ { .compatible = "samsung,exynos4412-dw-mshc",
+ .data = &exynos5_drv_data, },
{ .compatible = "samsung,exynos5250-dw-mshc",
- .data = &exynos5250_drv_data, },
+ .data = &exynos5_drv_data, },
{},
};
MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread