From: Ulf Hansson <ulf.hansson@linaro.org>
To: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Ritesh Raj Sarraf <rrs@researchut.com>,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.com>,
USB list <linux-usb@vger.kernel.org>,
Roger Tseng <rogerable@realtek.com>,
Wei WANG <wei_wang@realsil.com.cn>
Subject: [PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues
Date: Thu, 13 Oct 2016 13:37:34 +0200 [thread overview]
Message-ID: <1476358660-8338-1-git-send-email-ulf.hansson@linaro.org> (raw)
The rtsx_usb_sdmmc (mmc/sd) and rtsx_usb_ms (memstick) devices are interfacing
an rtsx_usb device (managed by an mfd driver) while communicating with the
cards. The mmc/sd and memstick devices are children of the usb device.
Issues has been reported [1] for rtsx, which have been investigated, discussed,
fixed, tested, etc, particularly when using mmc/sd cards. During the
investigation, some changes was proposed and tested successfully. In this
series I have picked up these changes and created some proper patches with
change-logs.
It turned out that most of the problems was related to the runtime PM
deployment in the memstick and the mmc/sd driver, which are fixed in this
series.
A couple of more issues were also discussed [2], which needs to be fixed as
well. Although they are out of scope for this series, so we will have to look
into those at a later point. Here's a brief summary of these leftovers:
*)
It seems reasonable to turn off autosuspend for usb devices and instead rely on
the usb device's children to deal with autosuspend. The reason is simply that
the children has better knowledge of when using autosuspend makes sense.
**)
Polling card detect mode is used both for mmc/sd and memstick. Because of the
lack of synchronization between the polling attempts for these subsystems, the
usb device may be powered on for unnecessary long intervals, thus we are
wasting power.
Besides the above changes, I folded in a change in the mmc core which improves
the behaviour for mmc hosts using MMC_CAP2_NO_PRESCAN_POWERUP, which is the
case for the rtsx_usb_sdmmc driver. This change should improve the boot time
with ~100ms per rtsx_usb_sdmmc device.
Finally, as I couldn't find an active maintainer for the memstick
subsystem/driver and because the author of the drivers can be reached, I
volunteer to take this all through my mmc tree. Please tell me if that is
problem to any of you.
[1]
https://www.spinics.net/lists/linux-usb/msg146998.html
[2]
https://www.spinics.net/lists/linux-mmc/msg39235.html
Alan Stern (1):
memstick: rtsx_usb_ms: Runtime resume the device when polling for
cards
Ulf Hansson (5):
mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when
unused
mmc: rtsx_usb_sdmmc: Handle runtime PM while changing the led
memstick: rtsx_usb_ms: Manage runtime PM when accessing the device
mmc: rtsx_usb_sdmmc: Enable runtime PM autosuspend
mmc: core: Don't power off the card when starting the host
drivers/memstick/host/rtsx_usb_ms.c | 6 ++++++
drivers/mmc/core/core.c | 9 ++++-----
drivers/mmc/host/rtsx_usb_sdmmc.c | 10 +++++-----
3 files changed, 15 insertions(+), 10 deletions(-)
--
1.9.1
next reply other threads:[~2016-10-13 11:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 11:37 Ulf Hansson [this message]
2016-10-13 11:37 ` [PATCH 1/6] mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused Ulf Hansson
2016-10-13 11:37 ` [PATCH 2/6] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing the led Ulf Hansson
2016-10-13 11:37 ` [PATCH 3/6] memstick: rtsx_usb_ms: Runtime resume the device when polling for cards Ulf Hansson
2016-10-13 11:37 ` [PATCH 4/6] memstick: rtsx_usb_ms: Manage runtime PM when accessing the device Ulf Hansson
2016-10-13 11:37 ` [PATCH 5/6] mmc: rtsx_usb_sdmmc: Enable runtime PM autosuspend Ulf Hansson
2016-10-13 11:37 ` [PATCH 6/6] mmc: core: Don't power off the card when starting the host Ulf Hansson
[not found] ` <1476358660-8338-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-17 13:49 ` [PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues Ulf Hansson
[not found] ` <CAPDyKFpzq2wRfh_5x119ouP-e8EAaibsSvM36msxm7oepxRoDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-17 16:34 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476358660-8338-1-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=rogerable@realtek.com \
--cc=rrs@researchut.com \
--cc=stern@rowland.harvard.edu \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox