Linux MultiMedia Card development
 help / color / mirror / Atom feed
From: Ulf Hansson <ulf.hansson@linaro.org>
To: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Ritesh Raj Sarraf <rrs@researchut.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Oliver Neukum <oneukum@suse.com>,
	USB list <linux-usb@vger.kernel.org>,
	Roger Tseng <rogerable@realtek.com>,
	Wei WANG <wei_wang@realsil.com.cn>,
	stable@vger.kernel.org
Subject: [PATCH 3/6] memstick: rtsx_usb_ms: Runtime resume the device when polling for cards
Date: Thu, 13 Oct 2016 13:37:37 +0200	[thread overview]
Message-ID: <1476358660-8338-4-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1476358660-8338-1-git-send-email-ulf.hansson@linaro.org>

From: Alan Stern <stern@rowland.harvard.edu>

Accesses to the rtsx usb device, which is the parent of the rtsx memstick
device, must not be done unless it's runtime resumed.

Therefore when the rtsx_usb_ms driver polls for inserted memstick cards,
let's add pm_runtime_get|put*() to make sure accesses is done when the
rtsx usb device is runtime resumed.

Reported-by: Ritesh Raj Sarraf <rrs@researchut.com>
Tested-by: Ritesh Raj Sarraf <rrs@researchut.com>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/memstick/host/rtsx_usb_ms.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c
index d34bc35..1b99489 100644
--- a/drivers/memstick/host/rtsx_usb_ms.c
+++ b/drivers/memstick/host/rtsx_usb_ms.c
@@ -681,6 +681,7 @@ static int rtsx_usb_detect_ms_card(void *__host)
 	int err;
 
 	for (;;) {
+		pm_runtime_get_sync(ms_dev(host));
 		mutex_lock(&ucr->dev_mutex);
 
 		/* Check pending MS card changes */
@@ -703,6 +704,7 @@ static int rtsx_usb_detect_ms_card(void *__host)
 		}
 
 poll_again:
+		pm_runtime_put(ms_dev(host));
 		if (host->eject)
 			break;
 
-- 
1.9.1

  parent reply	other threads:[~2016-10-13 11:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 11:37 [PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues Ulf Hansson
2016-10-13 11:37 ` [PATCH 1/6] mmc: rtsx_usb_sdmmc: Avoid keeping the device runtime resumed when unused Ulf Hansson
2016-10-13 11:37 ` [PATCH 2/6] mmc: rtsx_usb_sdmmc: Handle runtime PM while changing the led Ulf Hansson
2016-10-13 11:37 ` Ulf Hansson [this message]
2016-10-13 11:37 ` [PATCH 4/6] memstick: rtsx_usb_ms: Manage runtime PM when accessing the device Ulf Hansson
2016-10-13 11:37 ` [PATCH 5/6] mmc: rtsx_usb_sdmmc: Enable runtime PM autosuspend Ulf Hansson
2016-10-13 11:37 ` [PATCH 6/6] mmc: core: Don't power off the card when starting the host Ulf Hansson
     [not found] ` <1476358660-8338-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-17 13:49   ` [PATCH 0/6] mmc/memstick: rtsx_usb: Fix runtime PM issues Ulf Hansson
     [not found]     ` <CAPDyKFpzq2wRfh_5x119ouP-e8EAaibsSvM36msxm7oepxRoDQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-17 16:34       ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476358660-8338-4-git-send-email-ulf.hansson@linaro.org \
    --to=ulf.hansson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=rogerable@realtek.com \
    --cc=rrs@researchut.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox