* [PATCH] mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a
@ 2017-04-20 6:58 Yangbo Lu
2017-04-25 9:44 ` Adrian Hunter
2017-04-28 10:37 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Yangbo Lu @ 2017-04-20 6:58 UTC (permalink / raw)
To: linux-mmc, ulf.hansson, Adrian Hunter; +Cc: Xiaobo Xie, Yangbo Lu
The ls1046a datasheet specified that the max SD clock frequency
for eSDHC SDR104/HS200 was 167MHz, and the ls1012a datasheet
specified it's 125MHz for ls1012a. So this patch is to add the
limitation.
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
drivers/mmc/host/sdhci-of-esdhc.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
index 49ac197..57966ef 100644
--- a/drivers/mmc/host/sdhci-of-esdhc.c
+++ b/drivers/mmc/host/sdhci-of-esdhc.c
@@ -456,6 +456,20 @@ static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int clock)
if (esdhc->vendor_ver < VENDOR_V_23)
pre_div = 2;
+ /*
+ * Limit SD clock to 167MHz for ls1046a according to its datasheet
+ */
+ if (clock > 167000000 &&
+ of_find_compatible_node(NULL, NULL, "fsl,ls1046a-esdhc"))
+ clock = 167000000;
+
+ /*
+ * Limit SD clock to 125MHz for ls1012a according to its datasheet
+ */
+ if (clock > 125000000 &&
+ of_find_compatible_node(NULL, NULL, "fsl,ls1012a-esdhc"))
+ clock = 125000000;
+
/* Workaround to reduce the clock frequency for p1010 esdhc */
if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) {
if (clock > 20000000)
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a
2017-04-20 6:58 [PATCH] mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a Yangbo Lu
@ 2017-04-25 9:44 ` Adrian Hunter
2017-04-28 10:37 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2017-04-25 9:44 UTC (permalink / raw)
To: Yangbo Lu, linux-mmc, ulf.hansson; +Cc: Xiaobo Xie
On 20/04/17 09:58, Yangbo Lu wrote:
> The ls1046a datasheet specified that the max SD clock frequency
> for eSDHC SDR104/HS200 was 167MHz, and the ls1012a datasheet
> specified it's 125MHz for ls1012a. So this patch is to add the
> limitation.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 49ac197..57966ef 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -456,6 +456,20 @@ static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int clock)
> if (esdhc->vendor_ver < VENDOR_V_23)
> pre_div = 2;
>
> + /*
> + * Limit SD clock to 167MHz for ls1046a according to its datasheet
> + */
> + if (clock > 167000000 &&
> + of_find_compatible_node(NULL, NULL, "fsl,ls1046a-esdhc"))
> + clock = 167000000;
> +
> + /*
> + * Limit SD clock to 125MHz for ls1012a according to its datasheet
> + */
> + if (clock > 125000000 &&
> + of_find_compatible_node(NULL, NULL, "fsl,ls1012a-esdhc"))
> + clock = 125000000;
> +
> /* Workaround to reduce the clock frequency for p1010 esdhc */
> if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) {
> if (clock > 20000000)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a
2017-04-20 6:58 [PATCH] mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a Yangbo Lu
2017-04-25 9:44 ` Adrian Hunter
@ 2017-04-28 10:37 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2017-04-28 10:37 UTC (permalink / raw)
To: Yangbo Lu; +Cc: linux-mmc@vger.kernel.org, Adrian Hunter, Xiaobo Xie
On 20 April 2017 at 08:58, Yangbo Lu <yangbo.lu@nxp.com> wrote:
> The ls1046a datasheet specified that the max SD clock frequency
> for eSDHC SDR104/HS200 was 167MHz, and the ls1012a datasheet
> specified it's 125MHz for ls1012a. So this patch is to add the
> limitation.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-esdhc.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c
> index 49ac197..57966ef 100644
> --- a/drivers/mmc/host/sdhci-of-esdhc.c
> +++ b/drivers/mmc/host/sdhci-of-esdhc.c
> @@ -456,6 +456,20 @@ static void esdhc_of_set_clock(struct sdhci_host *host, unsigned int clock)
> if (esdhc->vendor_ver < VENDOR_V_23)
> pre_div = 2;
>
> + /*
> + * Limit SD clock to 167MHz for ls1046a according to its datasheet
> + */
> + if (clock > 167000000 &&
> + of_find_compatible_node(NULL, NULL, "fsl,ls1046a-esdhc"))
> + clock = 167000000;
> +
> + /*
> + * Limit SD clock to 125MHz for ls1012a according to its datasheet
> + */
> + if (clock > 125000000 &&
> + of_find_compatible_node(NULL, NULL, "fsl,ls1012a-esdhc"))
> + clock = 125000000;
> +
> /* Workaround to reduce the clock frequency for p1010 esdhc */
> if (of_find_compatible_node(NULL, NULL, "fsl,p1010-esdhc")) {
> if (clock > 20000000)
> --
> 2.1.0.27.g96db324
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-28 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-20 6:58 [PATCH] mmc: sdhci-of-esdhc: limit SD clock for ls1012a/ls1046a Yangbo Lu
2017-04-25 9:44 ` Adrian Hunter
2017-04-28 10:37 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox