* [PATCH] mmc: mmc: fix switch to 1V8 for hs400es mode
@ 2017-07-07 9:08 Haibo Chen
2017-07-11 0:38 ` Shawn Lin
0 siblings, 1 reply; 3+ messages in thread
From: Haibo Chen @ 2017-07-07 9:08 UTC (permalink / raw)
To: ulf.hansson, shawn.lin; +Cc: stable, dianders, linux-mmc, haibo.chen
Change the default err value to -EINVAL, otherwise signal voltage
will not change to 1V8 if card or controller only support 1V8 for
HS400ES mode.
Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es mode")
Cc: <stable@vger.kernel.org>
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/mmc/core/mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 92c6167..336a950 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card)
static int mmc_select_hs400es(struct mmc_card *card)
{
struct mmc_host *host = card->host;
- int err = 0;
+ int err = -EINVAL;
u8 val;
if (!(host->caps & MMC_CAP_8_BIT_DATA)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: mmc: fix switch to 1V8 for hs400es mode
2017-07-07 9:08 [PATCH] mmc: mmc: fix switch to 1V8 for hs400es mode Haibo Chen
@ 2017-07-11 0:38 ` Shawn Lin
2017-08-08 10:12 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Lin @ 2017-07-11 0:38 UTC (permalink / raw)
To: Haibo Chen, ulf.hansson; +Cc: shawn.lin, stable, dianders, linux-mmc
Hi Haibo,
On 2017/7/7 17:08, Haibo Chen wrote:
> Change the default err value to -EINVAL, otherwise signal voltage
> will not change to 1V8 if card or controller only support 1V8 for
> HS400ES mode.
>
This description is misleading as hs400(es) must be running under
1.8v vqmmc. But the patch itself is correct.
> Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es mode")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> drivers/mmc/core/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 92c6167..336a950 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card)
> static int mmc_select_hs400es(struct mmc_card *card)
> {
> struct mmc_host *host = card->host;
> - int err = 0;
> + int err = -EINVAL;
> u8 val;
>
> if (!(host->caps & MMC_CAP_8_BIT_DATA)) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: mmc: fix switch to 1V8 for hs400es mode
2017-07-11 0:38 ` Shawn Lin
@ 2017-08-08 10:12 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2017-08-08 10:12 UTC (permalink / raw)
To: Shawn Lin; +Cc: Haibo Chen, # 4.0+, Doug Anderson, linux-mmc@vger.kernel.org
On 11 July 2017 at 02:38, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Hi Haibo,
>
> On 2017/7/7 17:08, Haibo Chen wrote:
>>
>> Change the default err value to -EINVAL, otherwise signal voltage
>> will not change to 1V8 if card or controller only support 1V8 for
>> HS400ES mode.
>>
>
> This description is misleading as hs400(es) must be running under
> 1.8v vqmmc. But the patch itself is correct.
>
>
>> Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es
>> mode")
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>> ---
>> drivers/mmc/core/mmc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
>> index 92c6167..336a950 100644
>> --- a/drivers/mmc/core/mmc.c
>> +++ b/drivers/mmc/core/mmc.c
>> @@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card)
>> static int mmc_select_hs400es(struct mmc_card *card)
>> {
>> struct mmc_host *host = card->host;
>> - int err = 0;
>> + int err = -EINVAL;
>> u8 val;
>> if (!(host->caps & MMC_CAP_8_BIT_DATA)) {
>>
>
Seems like Haibo has been busy. Shawn, if you think it's important,
could you pick up this and re-submit?
Kind regards
Uffe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-08 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-07 9:08 [PATCH] mmc: mmc: fix switch to 1V8 for hs400es mode Haibo Chen
2017-07-11 0:38 ` Shawn Lin
2017-08-08 10:12 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox