* [PATCH] mmc: sdhci-esdhc-imx: use the correct host caps for MMC_CAP_8_BIT_DATA
@ 2022-11-08 7:45 haibo.chen
2022-11-08 8:40 ` Adrian Hunter
2022-11-09 12:34 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: haibo.chen @ 2022-11-08 7:45 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, linux-mmc
Cc: linux-imx, haibo.chen, stable, shawnguo, s.hauer, kernel,
festevam
From: Haibo Chen <haibo.chen@nxp.com>
MMC_CAP_8_BIT_DATA belongs to struct mmc_host, not struct sdhci_host.
So correct it here.
Fixes: 1ed5c3b22fc7 ("mmc: sdhci-esdhc-imx: Propagate ESDHC_FLAG_HS400* only on 8bit bus")
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Cc: stable@vger.kernel.org
---
drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index a54f1806dd57..004c6352d954 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -1679,14 +1679,14 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
if (imx_data->socdata->flags & ESDHC_FLAG_ERR004536)
host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
- if (host->caps & MMC_CAP_8_BIT_DATA &&
+ if (host->mmc->caps & MMC_CAP_8_BIT_DATA &&
imx_data->socdata->flags & ESDHC_FLAG_HS400)
host->mmc->caps2 |= MMC_CAP2_HS400;
if (imx_data->socdata->flags & ESDHC_FLAG_BROKEN_AUTO_CMD23)
host->quirks2 |= SDHCI_QUIRK2_ACMD23_BROKEN;
- if (host->caps & MMC_CAP_8_BIT_DATA &&
+ if (host->mmc->caps & MMC_CAP_8_BIT_DATA &&
imx_data->socdata->flags & ESDHC_FLAG_HS400_ES) {
host->mmc->caps2 |= MMC_CAP2_HS400_ES;
host->mmc_host_ops.hs400_enhanced_strobe =
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-esdhc-imx: use the correct host caps for MMC_CAP_8_BIT_DATA
2022-11-08 7:45 [PATCH] mmc: sdhci-esdhc-imx: use the correct host caps for MMC_CAP_8_BIT_DATA haibo.chen
@ 2022-11-08 8:40 ` Adrian Hunter
2022-11-09 12:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2022-11-08 8:40 UTC (permalink / raw)
To: haibo.chen, ulf.hansson, linux-mmc
Cc: linux-imx, stable, shawnguo, s.hauer, kernel, festevam
On 8/11/22 09:45, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> MMC_CAP_8_BIT_DATA belongs to struct mmc_host, not struct sdhci_host.
> So correct it here.
>
> Fixes: 1ed5c3b22fc7 ("mmc: sdhci-esdhc-imx: Propagate ESDHC_FLAG_HS400* only on 8bit bus")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Cc: stable@vger.kernel.org
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index a54f1806dd57..004c6352d954 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1679,14 +1679,14 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
> if (imx_data->socdata->flags & ESDHC_FLAG_ERR004536)
> host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
>
> - if (host->caps & MMC_CAP_8_BIT_DATA &&
> + if (host->mmc->caps & MMC_CAP_8_BIT_DATA &&
> imx_data->socdata->flags & ESDHC_FLAG_HS400)
> host->mmc->caps2 |= MMC_CAP2_HS400;
>
> if (imx_data->socdata->flags & ESDHC_FLAG_BROKEN_AUTO_CMD23)
> host->quirks2 |= SDHCI_QUIRK2_ACMD23_BROKEN;
>
> - if (host->caps & MMC_CAP_8_BIT_DATA &&
> + if (host->mmc->caps & MMC_CAP_8_BIT_DATA &&
> imx_data->socdata->flags & ESDHC_FLAG_HS400_ES) {
> host->mmc->caps2 |= MMC_CAP2_HS400_ES;
> host->mmc_host_ops.hs400_enhanced_strobe =
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sdhci-esdhc-imx: use the correct host caps for MMC_CAP_8_BIT_DATA
2022-11-08 7:45 [PATCH] mmc: sdhci-esdhc-imx: use the correct host caps for MMC_CAP_8_BIT_DATA haibo.chen
2022-11-08 8:40 ` Adrian Hunter
@ 2022-11-09 12:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2022-11-09 12:34 UTC (permalink / raw)
To: haibo.chen
Cc: adrian.hunter, linux-mmc, linux-imx, stable, shawnguo, s.hauer,
kernel, festevam
On Tue, 8 Nov 2022 at 09:06, <haibo.chen@nxp.com> wrote:
>
> From: Haibo Chen <haibo.chen@nxp.com>
>
> MMC_CAP_8_BIT_DATA belongs to struct mmc_host, not struct sdhci_host.
> So correct it here.
>
> Fixes: 1ed5c3b22fc7 ("mmc: sdhci-esdhc-imx: Propagate ESDHC_FLAG_HS400* only on 8bit bus")
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> Cc: stable@vger.kernel.org
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index a54f1806dd57..004c6352d954 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -1679,14 +1679,14 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev)
> if (imx_data->socdata->flags & ESDHC_FLAG_ERR004536)
> host->quirks |= SDHCI_QUIRK_BROKEN_ADMA;
>
> - if (host->caps & MMC_CAP_8_BIT_DATA &&
> + if (host->mmc->caps & MMC_CAP_8_BIT_DATA &&
> imx_data->socdata->flags & ESDHC_FLAG_HS400)
> host->mmc->caps2 |= MMC_CAP2_HS400;
>
> if (imx_data->socdata->flags & ESDHC_FLAG_BROKEN_AUTO_CMD23)
> host->quirks2 |= SDHCI_QUIRK2_ACMD23_BROKEN;
>
> - if (host->caps & MMC_CAP_8_BIT_DATA &&
> + if (host->mmc->caps & MMC_CAP_8_BIT_DATA &&
> imx_data->socdata->flags & ESDHC_FLAG_HS400_ES) {
> host->mmc->caps2 |= MMC_CAP2_HS400_ES;
> host->mmc_host_ops.hs400_enhanced_strobe =
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-09 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-08 7:45 [PATCH] mmc: sdhci-esdhc-imx: use the correct host caps for MMC_CAP_8_BIT_DATA haibo.chen
2022-11-08 8:40 ` Adrian Hunter
2022-11-09 12:34 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox