From: "Rob Herring (Arm)" <robh@kernel.org>
To: Sarthak Garg <quic_sartgarg@quicinc.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
quic_rampraka@quicinc.com, Conor Dooley <conor+dt@kernel.org>,
quic_nguyenb@quicinc.com, Ulf Hansson <ulf.hansson@linaro.org>,
linux-kernel@vger.kernel.org, quic_pragalla@quicinc.com,
quic_bhaskarv@quicinc.com,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
quic_sachgupt@quicinc.com,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
devicetree@vger.kernel.org, quic_nitirawa@quicinc.com,
quic_cang@quicinc.com, quic_narepall@quicinc.com,
quic_sayalil@quicinc.com, linux-mmc@vger.kernel.org,
kernel@quicinc.com, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter flag for SD card
Date: Thu, 07 Nov 2024 03:28:10 -0600 [thread overview]
Message-ID: <173097168998.1358564.6585218093768664587.robh@kernel.org> (raw)
In-Reply-To: <20241107080505.29244-2-quic_sartgarg@quicinc.com>
On Thu, 07 Nov 2024 13:35:03 +0530, Sarthak Garg wrote:
> Introduce a flag to indicate if the Qualcomm platform has a level
> shifter for SD cards. With level shifter addition some extra delay is
> seen on RX data path leading to CRC errors. To compensate these delays
> and avoid CRC errors below things needs to be done:
>
> 1) Enable tuning for SDR50 mode
> 2) Limit HS mode frequency to 37.5MHz from 50MHz
>
> Add this flag for all targets with a level shifter to handle these
> issues for SD card.
>
> Signed-off-by: Sarthak Garg <quic_sartgarg@quicinc.com>
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml: qcom,use-level-shifter: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241107080505.29244-2-quic_sartgarg@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-11-07 9:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 8:05 [PATCH V1 0/3] Add level shifter support for qualcomm SOC's Sarthak Garg
2024-11-07 8:05 ` [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter flag for SD card Sarthak Garg
2024-11-07 9:28 ` Rob Herring (Arm) [this message]
2024-11-07 9:59 ` Krzysztof Kozlowski
2025-05-20 6:58 ` Sarthak Garg
2025-05-20 7:18 ` Krzysztof Kozlowski
2025-05-20 9:15 ` Sarthak Garg
2024-11-07 8:05 ` [PATCH V1 2/3] mmc: sdhci-msm: Enable tuning for SDR50 mode " Sarthak Garg
2024-11-11 8:51 ` Adrian Hunter
2025-05-20 7:00 ` Sarthak Garg
2024-11-07 8:05 ` [PATCH V1 3/3] mmc: sdhci-msm: Limit HS mode frequency to 37.5MHz Sarthak Garg
2024-11-11 8:58 ` Adrian Hunter
2025-05-20 7:02 ` Sarthak Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173097168998.1358564.6585218093768664587.robh@kernel.org \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sachgupt@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox