From: Sarthak Garg <quic_sartgarg@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
<linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<quic_cang@quicinc.com>, <quic_nguyenb@quicinc.com>,
<quic_rampraka@quicinc.com>, <quic_pragalla@quicinc.com>,
<quic_sayalil@quicinc.com>, <quic_nitirawa@quicinc.com>,
<quic_sachgupt@quicinc.com>, <quic_bhaskarv@quicinc.com>,
<quic_narepall@quicinc.com>, <kernel@quicinc.com>
Subject: Re: [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter flag for SD card
Date: Tue, 20 May 2025 12:28:53 +0530 [thread overview]
Message-ID: <ba49151a-e32d-438d-8a2a-50840368a87c@quicinc.com> (raw)
In-Reply-To: <qffggh2ld2cw7d3eqwaerzicerhvdqojwsasherx7dgoda42b7@bigsjxr6vtao>
On 11/7/2024 3:29 PM, Krzysztof Kozlowski wrote:
> On Thu, Nov 07, 2024 at 01:35:03PM +0530, Sarthak Garg wrote:
>> Introduce a flag to indicate if the Qualcomm platform has a level
>> shifter for SD cards. With level shifter addition some extra delay is
>> seen on RX data path leading to CRC errors. To compensate these delays
>> and avoid CRC errors below things needs to be done:
>>
>> 1) Enable tuning for SDR50 mode
>> 2) Limit HS mode frequency to 37.5MHz from 50MHz
>>
>> Add this flag for all targets with a level shifter to handle these
>> issues for SD card.
>>
>> Signed-off-by: Sarthak Garg <quic_sartgarg@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>
> This wasn't tested, so just short review - platform means SoC usually,
> so this looks SoC specific, thus implied by compatible.
> > Best regards,
> Krzysztof
>
Sure will redesign this logic and use compatible in patch V2.
next prev parent reply other threads:[~2025-05-20 6:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 8:05 [PATCH V1 0/3] Add level shifter support for qualcomm SOC's Sarthak Garg
2024-11-07 8:05 ` [PATCH V1 1/3] dt-bindings: mmc: qcom: Document level shifter flag for SD card Sarthak Garg
2024-11-07 9:28 ` Rob Herring (Arm)
2024-11-07 9:59 ` Krzysztof Kozlowski
2025-05-20 6:58 ` Sarthak Garg [this message]
2025-05-20 7:18 ` Krzysztof Kozlowski
2025-05-20 9:15 ` Sarthak Garg
2024-11-07 8:05 ` [PATCH V1 2/3] mmc: sdhci-msm: Enable tuning for SDR50 mode " Sarthak Garg
2024-11-11 8:51 ` Adrian Hunter
2025-05-20 7:00 ` Sarthak Garg
2024-11-07 8:05 ` [PATCH V1 3/3] mmc: sdhci-msm: Limit HS mode frequency to 37.5MHz Sarthak Garg
2024-11-11 8:58 ` Adrian Hunter
2025-05-20 7:02 ` Sarthak Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba49151a-e32d-438d-8a2a-50840368a87c@quicinc.com \
--to=quic_sartgarg@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sachgupt@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox