* [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property
@ 2025-02-20 16:46 Frank Li
2025-02-21 23:22 ` Rob Herring (Arm)
2025-03-12 11:24 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2025-02-20 16:46 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx, shawnguo
mmc-controller.yaml is common schema file. According to writing-schema.rst,
* additionalProperties: true
Rare case, used for schemas implementing common set of properties. Such
schemas are supposed to be referenced by other schemas, which then use
'unevaluatedProperties: false'. Typically bus or common-part schemas.
Reproduce steps:
1. Add unevaluated property 'abc' at example of fsl-imx-esdhc.yaml
2. Run make dt_binding_check DT_SCHEMA_FILES=fsl-imx-esdhc.yaml
No any warning report. But suppose report below warning:
mmc@70004000: Unevaluated properties are not allowed ('abc' was unexpected)
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 9d7a1298c4554..26e4f0f8dc1ce 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -24,7 +24,7 @@ properties:
$nodename:
pattern: "^mmc(@.*)?$"
-unevaluatedProperties: true
+additionalProperties: true
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property
2025-02-20 16:46 [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property Frank Li
@ 2025-02-21 23:22 ` Rob Herring (Arm)
2025-03-12 11:24 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-02-21 23:22 UTC (permalink / raw)
To: Frank Li
Cc: linux-mmc, linux-kernel, Conor Dooley, shawnguo, Ulf Hansson,
devicetree, imx, Krzysztof Kozlowski
On Thu, 20 Feb 2025 11:46:54 -0500, Frank Li wrote:
> mmc-controller.yaml is common schema file. According to writing-schema.rst,
>
> * additionalProperties: true
> Rare case, used for schemas implementing common set of properties. Such
> schemas are supposed to be referenced by other schemas, which then use
> 'unevaluatedProperties: false'. Typically bus or common-part schemas.
>
> Reproduce steps:
> 1. Add unevaluated property 'abc' at example of fsl-imx-esdhc.yaml
> 2. Run make dt_binding_check DT_SCHEMA_FILES=fsl-imx-esdhc.yaml
>
> No any warning report. But suppose report below warning:
> mmc@70004000: Unevaluated properties are not allowed ('abc' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property
2025-02-20 16:46 [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property Frank Li
2025-02-21 23:22 ` Rob Herring (Arm)
@ 2025-03-12 11:24 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-03-12 11:24 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx, shawnguo
On Thu, 20 Feb 2025 at 17:47, Frank Li <Frank.Li@nxp.com> wrote:
>
> mmc-controller.yaml is common schema file. According to writing-schema.rst,
>
> * additionalProperties: true
> Rare case, used for schemas implementing common set of properties. Such
> schemas are supposed to be referenced by other schemas, which then use
> 'unevaluatedProperties: false'. Typically bus or common-part schemas.
>
> Reproduce steps:
> 1. Add unevaluated property 'abc' at example of fsl-imx-esdhc.yaml
> 2. Run make dt_binding_check DT_SCHEMA_FILES=fsl-imx-esdhc.yaml
>
> No any warning report. But suppose report below warning:
> mmc@70004000: Unevaluated properties are not allowed ('abc' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 9d7a1298c4554..26e4f0f8dc1ce 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -24,7 +24,7 @@ properties:
> $nodename:
> pattern: "^mmc(@.*)?$"
>
> -unevaluatedProperties: true
> +additionalProperties: true
>
> examples:
> - |
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-12 11:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-20 16:46 [PATCH 1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property Frank Li
2025-02-21 23:22 ` Rob Herring (Arm)
2025-03-12 11:24 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox