* [PATCH] mmc: dw_mmc: Use dma_set_mask_and_coherent() helper
@ 2025-10-10 3:37 Shawn Lin
2025-10-17 13:30 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Lin @ 2025-10-10 3:37 UTC (permalink / raw)
To: Ulf Hansson; +Cc: Jaehoon Chung, linux-mmc, Shawn Lin
Use dma_set_mask_and_coherent() instead. No functional changes.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/dw_mmc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index c5db92b..c4f5f44 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -3120,9 +3120,8 @@ static void dw_mci_init_dma(struct dw_mci *host)
host->dma_64bit_address = 1;
dev_info(host->dev,
"IDMAC supports 64-bit address mode.\n");
- if (!dma_set_mask(host->dev, DMA_BIT_MASK(64)))
- dma_set_coherent_mask(host->dev,
- DMA_BIT_MASK(64));
+ if (dma_set_mask_and_coherent(host->dev, DMA_BIT_MASK(64)))
+ dev_info(host->dev, "Fail to set 64-bit DMA mask");
} else {
/* host supports IDMAC in 32-bit address mode */
host->dma_64bit_address = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Use dma_set_mask_and_coherent() helper
2025-10-10 3:37 [PATCH] mmc: dw_mmc: Use dma_set_mask_and_coherent() helper Shawn Lin
@ 2025-10-17 13:30 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2025-10-17 13:30 UTC (permalink / raw)
To: Shawn Lin; +Cc: Jaehoon Chung, linux-mmc
On Fri, 10 Oct 2025 at 05:37, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>
> Use dma_set_mask_and_coherent() instead. No functional changes.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/dw_mmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index c5db92b..c4f5f44 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3120,9 +3120,8 @@ static void dw_mci_init_dma(struct dw_mci *host)
> host->dma_64bit_address = 1;
> dev_info(host->dev,
> "IDMAC supports 64-bit address mode.\n");
> - if (!dma_set_mask(host->dev, DMA_BIT_MASK(64)))
> - dma_set_coherent_mask(host->dev,
> - DMA_BIT_MASK(64));
> + if (dma_set_mask_and_coherent(host->dev, DMA_BIT_MASK(64)))
> + dev_info(host->dev, "Fail to set 64-bit DMA mask");
> } else {
> /* host supports IDMAC in 32-bit address mode */
> host->dma_64bit_address = 0;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-17 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-10 3:37 [PATCH] mmc: dw_mmc: Use dma_set_mask_and_coherent() helper Shawn Lin
2025-10-17 13:30 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox