From: Adrian Hunter <adrian.hunter@intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Georgi Djakov <georgi.djakov@linaro.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe()
Date: Thu, 27 Oct 2016 09:24:20 +0300 [thread overview]
Message-ID: <2005a16c-5cf4-25ad-b01b-5bbf25c751c2@intel.com> (raw)
In-Reply-To: <1477494281-24246-1-git-send-email-weiyj.lk@gmail.com>
On 26/10/16 18:04, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the platform_get_irq_byname()
> error handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ad81d3871004 ("mmc: sdhci-msm: Add support for UHS cards")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-msm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 795f16f..b78d72f 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -649,6 +649,7 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> if (msm_host->pwr_irq < 0) {
> dev_err(&pdev->dev, "Get pwr_irq failed (%d)\n",
> msm_host->pwr_irq);
> + ret = msm_host->pwr_irq;
> goto clk_disable;
> }
>
>
next prev parent reply other threads:[~2016-10-27 6:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 15:04 [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe() Wei Yongjun
2016-10-27 6:24 ` Adrian Hunter [this message]
2016-10-27 7:20 ` Georgi Djakov
2016-10-27 7:47 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2005a16c-5cf4-25ad-b01b-5bbf25c751c2@intel.com \
--to=adrian.hunter@intel.com \
--cc=georgi.djakov@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox