* [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe()
@ 2016-10-26 15:04 Wei Yongjun
2016-10-27 6:24 ` Adrian Hunter
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2016-10-26 15:04 UTC (permalink / raw)
To: Adrian Hunter, Ulf Hansson, Georgi Djakov; +Cc: Wei Yongjun, linux-mmc
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix to return a negative error code from the platform_get_irq_byname()
error handling case instead of 0, as done elsewhere in this function.
Fixes: ad81d3871004 ("mmc: sdhci-msm: Add support for UHS cards")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mmc/host/sdhci-msm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index 795f16f..b78d72f 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -649,6 +649,7 @@ static int sdhci_msm_probe(struct platform_device *pdev)
if (msm_host->pwr_irq < 0) {
dev_err(&pdev->dev, "Get pwr_irq failed (%d)\n",
msm_host->pwr_irq);
+ ret = msm_host->pwr_irq;
goto clk_disable;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe()
2016-10-26 15:04 [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe() Wei Yongjun
@ 2016-10-27 6:24 ` Adrian Hunter
2016-10-27 7:20 ` Georgi Djakov
2016-10-27 7:47 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Hunter @ 2016-10-27 6:24 UTC (permalink / raw)
To: Wei Yongjun, Ulf Hansson, Georgi Djakov; +Cc: Wei Yongjun, linux-mmc
On 26/10/16 18:04, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the platform_get_irq_byname()
> error handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ad81d3871004 ("mmc: sdhci-msm: Add support for UHS cards")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-msm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 795f16f..b78d72f 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -649,6 +649,7 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> if (msm_host->pwr_irq < 0) {
> dev_err(&pdev->dev, "Get pwr_irq failed (%d)\n",
> msm_host->pwr_irq);
> + ret = msm_host->pwr_irq;
> goto clk_disable;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe()
2016-10-26 15:04 [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe() Wei Yongjun
2016-10-27 6:24 ` Adrian Hunter
@ 2016-10-27 7:20 ` Georgi Djakov
2016-10-27 7:47 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Georgi Djakov @ 2016-10-27 7:20 UTC (permalink / raw)
To: Wei Yongjun, Adrian Hunter, Ulf Hansson; +Cc: Wei Yongjun, linux-mmc
On 10/26/2016 06:04 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the platform_get_irq_byname()
> error handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ad81d3871004 ("mmc: sdhci-msm: Add support for UHS cards")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Georgi Djakov <georgi.djakov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe()
2016-10-26 15:04 [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe() Wei Yongjun
2016-10-27 6:24 ` Adrian Hunter
2016-10-27 7:20 ` Georgi Djakov
@ 2016-10-27 7:47 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2016-10-27 7:47 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Adrian Hunter, Georgi Djakov, Wei Yongjun, linux-mmc
On 26 October 2016 at 17:04, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the platform_get_irq_byname()
> error handling case instead of 0, as done elsewhere in this function.
>
> Fixes: ad81d3871004 ("mmc: sdhci-msm: Add support for UHS cards")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-msm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 795f16f..b78d72f 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -649,6 +649,7 @@ static int sdhci_msm_probe(struct platform_device *pdev)
> if (msm_host->pwr_irq < 0) {
> dev_err(&pdev->dev, "Get pwr_irq failed (%d)\n",
> msm_host->pwr_irq);
> + ret = msm_host->pwr_irq;
> goto clk_disable;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-27 15:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 15:04 [PATCH -next] mmc: sdhci-msm: Fix error return code in sdhci_msm_probe() Wei Yongjun
2016-10-27 6:24 ` Adrian Hunter
2016-10-27 7:20 ` Georgi Djakov
2016-10-27 7:47 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox