public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Philip Rakity <prakity@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] sdhci: 8 bit widths - allow new QUIRK for 8 bit and v3 sd controller
Date: Sun, 7 Nov 2010 23:04:11 +0100	[thread overview]
Message-ID: <20101107220411.GB5376@pengutronix.de> (raw)
In-Reply-To: <74C0C915-257F-41CC-AEA8-C6F5B839586B@marvell.com>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

On Fri, Oct 08, 2010 at 12:31:34PM -0700, Philip Rakity wrote:
> 
> 8 bit width is a new feature in the sd 3.0 spec.  Add checks to
> ensure HOST_CONTROL register set 8 bit mode only if sd 3.0
> 
> add quirk to indicate that board design supports 8 data lines.
> The controller can support 8 data bits but the board design may
> only bring out 4 data bits.

This isn't a quirk, this is platform_data, no?

Without looking deeply into it, I think we need to use the callback you
introduced in the other patch?

Regards,

   Wolfram

PS: Sorry if there already was a discussion I might have missed. The bus width
thingie became a bit scattered, so I lost track...

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2010-11-07 22:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 19:31 [PATCH] sdhci: 8 bit widths - allow new QUIRK for 8 bit and v3 sd controller Philip Rakity
2010-11-07 22:04 ` Wolfram Sang [this message]
2010-11-08  7:21   ` Philip Rakity
2010-11-08  8:24     ` Kyungmin Park
2010-11-08  8:31       ` Philip Rakity
2010-11-08  9:15         ` Philip Rakity
2010-11-08  9:17     ` Wolfram Sang
2010-11-08 11:48       ` zhangfei gao
2010-11-08 12:07         ` Kyungmin Park
2010-11-08 12:12         ` Philip Rakity
2010-11-09  1:36           ` zhangfei gao
2010-11-09  3:36             ` Philip Rakity
2010-11-09 12:25         ` Philip Rakity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101107220411.GB5376@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox