From: Wolfram Sang <w.sang@pengutronix.de>
To: Philip Rakity <prakity@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] sdhci: 8 bit widths - allow new QUIRK for 8 bit and v3 sd controller
Date: Mon, 8 Nov 2010 10:17:54 +0100 [thread overview]
Message-ID: <20101108091754.GA8638@pengutronix.de> (raw)
In-Reply-To: <BEF8AD05-D094-4607-8C4F-1908C4FF54B3@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
> > This isn't a quirk, this is platform_data, no?
>
> Never sure of the difference between a quirk and platform data.
> example: Broken card detect is a quirk but maybe some slots on the board work and some do not
A quirk is something which needs to be handled in a special case because
some controllers do not adhere to the SDHC standard. An 8 bit bus seems
to be in the 3.0 standard, so it is not a quirk :) Does the standard say
anything about how the actual bus width should be handled?
That said, you are right that quirks have been abused to cover board
issues. Another reason to clean them up ;)
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-11-08 9:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 19:31 [PATCH] sdhci: 8 bit widths - allow new QUIRK for 8 bit and v3 sd controller Philip Rakity
2010-11-07 22:04 ` Wolfram Sang
2010-11-08 7:21 ` Philip Rakity
2010-11-08 8:24 ` Kyungmin Park
2010-11-08 8:31 ` Philip Rakity
2010-11-08 9:15 ` Philip Rakity
2010-11-08 9:17 ` Wolfram Sang [this message]
2010-11-08 11:48 ` zhangfei gao
2010-11-08 12:07 ` Kyungmin Park
2010-11-08 12:12 ` Philip Rakity
2010-11-09 1:36 ` zhangfei gao
2010-11-09 3:36 ` Philip Rakity
2010-11-09 12:25 ` Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108091754.GA8638@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox