From: Chris Ball <cjb@laptop.org>
To: "Mark F. Brown" <mark.brown314@gmail.com>
Cc: zhangfei.gao@gmail.com,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Philip Rakity <prakity@marvell.com>,
markb@marvell.com, Haojian Zhuang <haojian.zhuang@gmail.com>,
Eric Miao <eric.y.miao@gmail.com>
Subject: Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
Date: Tue, 23 Nov 2010 02:55:48 +0000 [thread overview]
Message-ID: <20101123025548.GA29770@void.printf.net> (raw)
In-Reply-To: <AANLkTimMFsxHt3AEfHDgZsia3c+rYVx2P5Diw=Robrbe@mail.gmail.com>
Hi,
On Mon, Nov 22, 2010 at 09:46:14PM -0500, Mark F. Brown wrote:
> > config MMC_SDHCI_PXA
> > tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
> > - depends on ARCH_PXA || ARCH_MMP
> > + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
> > select MMC_SDHCI
> > select MMC_SDHCI_IO_ACCESSORS
> > help
> > - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
> > - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
> > + This selects the Marvell(R) MMP2 SD Host Controller.
> > + If you have a MMP2 platform with SD Host Controller
> > and a card slot, say Y or M here.
>
> Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
> platform only. Until the sdhci-pxa code fixed or forked to support
> pxa168 and pxa910 we need to Philip's patch. Any feedback on this
> would be good thanks.
I don't mind changing the Kconfig text, but tying an SoC-level host
controller to dependencies on specific machines seems pretty wrong.
We should ask Haojian and Eric what they think. I think Philip
suggested using CPU_MMP2 at one point -- how about that?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-11-23 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 2:56 [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig Philip Rakity
2010-11-23 2:46 ` Mark F. Brown
2010-11-23 2:55 ` Chris Ball [this message]
2010-11-23 3:15 ` Philip Rakity
2010-11-23 3:16 ` zhangfei gao
2010-11-23 3:22 ` Philip Rakity
2010-11-23 4:38 ` Mark F. Brown
2010-11-23 4:59 ` Haojian Zhuang
2010-11-23 5:16 ` Philip Rakity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123025548.GA29770@void.printf.net \
--to=cjb@laptop.org \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.brown314@gmail.com \
--cc=markb@marvell.com \
--cc=prakity@marvell.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox