* [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
@ 2010-11-18 2:56 Philip Rakity
2010-11-23 2:46 ` Mark F. Brown
0 siblings, 1 reply; 9+ messages in thread
From: Philip Rakity @ 2010-11-18 2:56 UTC (permalink / raw)
To: linux-mmc@vger.kernel.org; +Cc: Mark Brown
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
>From 9de09a0575163c223f0aed0842daec9161b2f72e Mon Sep 17 00:00:00 2001
From: Philip Rakity <prakity@marvell.com>
Date: Wed, 17 Nov 2010 18:52:16 -0800
Subject: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
sdhci-pxa.c currently only supports mmp2. pxa168 and pxa9xx
controllers are not quite compatible with this code.
Disable the ability to select them until sdhci-pxa is changes
to support these systems.
Signed-off-by: Philip Rakity <prakity@marvell.com>
Signed-off-by: Mark Brown <markb@marvell.com>
---
drivers/mmc/host/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f8fa9ef..de138de 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -168,12 +168,12 @@ config MMC_SDHCI_S3C
config MMC_SDHCI_PXA
tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
- depends on ARCH_PXA || ARCH_MMP
+ depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
select MMC_SDHCI
select MMC_SDHCI_IO_ACCESSORS
help
- This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
- If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
+ This selects the Marvell(R) MMP2 SD Host Controller.
+ If you have a MMP2 platform with SD Host Controller
and a card slot, say Y or M here.
If unsure, say N.
--
1.6.0.4
[-- Attachment #2: 0001-sdhci-sdhci-pxa-only-supports-mmp2-at-this-time.-Ch.patch --]
[-- Type: application/octet-stream, Size: 1417 bytes --]
From 9de09a0575163c223f0aed0842daec9161b2f72e Mon Sep 17 00:00:00 2001
From: Philip Rakity <prakity@marvell.com>
Date: Wed, 17 Nov 2010 18:52:16 -0800
Subject: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
sdhci-pxa.c currently only supports mmp2. pxa168 and pxa9xx
controllers are not quite compatible with this code.
Disable the ability to select them until sdhci-pxa is changes
to support these systems.
Signed-off-by: Philip Rakity <prakity@marvell.com>
Signed-off-by: Mark Brown <markb@marvell.com>
---
drivers/mmc/host/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index f8fa9ef..de138de 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -168,12 +168,12 @@ config MMC_SDHCI_S3C
config MMC_SDHCI_PXA
tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
- depends on ARCH_PXA || ARCH_MMP
+ depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
select MMC_SDHCI
select MMC_SDHCI_IO_ACCESSORS
help
- This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
- If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
+ This selects the Marvell(R) MMP2 SD Host Controller.
+ If you have a MMP2 platform with SD Host Controller
and a card slot, say Y or M here.
If unsure, say N.
--
1.6.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-18 2:56 [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig Philip Rakity
@ 2010-11-23 2:46 ` Mark F. Brown
2010-11-23 2:55 ` Chris Ball
0 siblings, 1 reply; 9+ messages in thread
From: Mark F. Brown @ 2010-11-23 2:46 UTC (permalink / raw)
To: zhangfei.gao, cjb; +Cc: linux-mmc@vger.kernel.org, Philip Rakity, markb
On Wed, Nov 17, 2010 at 9:56 PM, Philip Rakity <prakity@marvell.com> wrote:
> From 9de09a0575163c223f0aed0842daec9161b2f72e Mon Sep 17 00:00:00 2001
> From: Philip Rakity <prakity@marvell.com>
> Date: Wed, 17 Nov 2010 18:52:16 -0800
> Subject: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
>
> sdhci-pxa.c currently only supports mmp2. pxa168 and pxa9xx
> controllers are not quite compatible with this code.
>
> Disable the ability to select them until sdhci-pxa is changes
> to support these systems.
>
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> Signed-off-by: Mark Brown <markb@marvell.com>
> ---
> drivers/mmc/host/Kconfig | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index f8fa9ef..de138de 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -168,12 +168,12 @@ config MMC_SDHCI_S3C
>
> config MMC_SDHCI_PXA
> tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
> - depends on ARCH_PXA || ARCH_MMP
> + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
> select MMC_SDHCI
> select MMC_SDHCI_IO_ACCESSORS
> help
> - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
> - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
> + This selects the Marvell(R) MMP2 SD Host Controller.
> + If you have a MMP2 platform with SD Host Controller
> and a card slot, say Y or M here.
>
> If unsure, say N.
> --
> 1.6.0.4
>
Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
platform only. Until the sdhci-pxa code fixed or forked to support
pxa168 and pxa910 we need to Philip's patch. Any feedback on this
would be good thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 2:46 ` Mark F. Brown
@ 2010-11-23 2:55 ` Chris Ball
2010-11-23 3:15 ` Philip Rakity
2010-11-23 3:16 ` zhangfei gao
0 siblings, 2 replies; 9+ messages in thread
From: Chris Ball @ 2010-11-23 2:55 UTC (permalink / raw)
To: Mark F. Brown
Cc: zhangfei.gao, linux-mmc@vger.kernel.org, Philip Rakity, markb,
Haojian Zhuang, Eric Miao
Hi,
On Mon, Nov 22, 2010 at 09:46:14PM -0500, Mark F. Brown wrote:
> > config MMC_SDHCI_PXA
> > tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
> > - depends on ARCH_PXA || ARCH_MMP
> > + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
> > select MMC_SDHCI
> > select MMC_SDHCI_IO_ACCESSORS
> > help
> > - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
> > - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
> > + This selects the Marvell(R) MMP2 SD Host Controller.
> > + If you have a MMP2 platform with SD Host Controller
> > and a card slot, say Y or M here.
>
> Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
> platform only. Until the sdhci-pxa code fixed or forked to support
> pxa168 and pxa910 we need to Philip's patch. Any feedback on this
> would be good thanks.
I don't mind changing the Kconfig text, but tying an SoC-level host
controller to dependencies on specific machines seems pretty wrong.
We should ask Haojian and Eric what they think. I think Philip
suggested using CPU_MMP2 at one point -- how about that?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 2:55 ` Chris Ball
@ 2010-11-23 3:15 ` Philip Rakity
2010-11-23 3:16 ` zhangfei gao
1 sibling, 0 replies; 9+ messages in thread
From: Philip Rakity @ 2010-11-23 3:15 UTC (permalink / raw)
To: Chris Ball
Cc: Mark F. Brown, zhangfei.gao@gmail.com, linux-mmc@vger.kernel.org,
Mark Brown, Haojian Zhuang, Eric Miao
>From dd7fc6c87544f7bb4437f226f50ed1571f8e6a79 Mon Sep 17 00:00:00 2001
From: philip <philip@philip-laptop.(none)>
Date: Fri, 19 Nov 2010 11:02:15 -0800
Subject: [PATCH] [PATCH} - revised sdhci: sdhci-pxa only supports mmp2 at this time - enforce this
sdhci-pxa.c does not handle pxa168 and pxa9xx at this time.
The code does not take into account differences in the private registers
nor other nuances. Restrict support to mmp2 until these issues are
resolved.
This patch is a revision of the previous patch - it uses CPU_MMP2
instead or the MACH_FLINT / MACH_ config variables
Signed-off-by: Mark Brown <markb@marvell.com>
Signed-off-by: Philip Rakity <prakity@marvell.com>
---
drivers/mmc/host/Kconfig | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 6466189..e5387fe 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -168,12 +168,12 @@ config MMC_SDHCI_S3C
config MMC_SDHCI_PXA
tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
- depends on ARCH_PXA || ARCH_MMP
+ depends on (ARCH_PXA || ARCH_MMP) && CPU_MMP2
select MMC_SDHCI
select MMC_SDHCI_IO_ACCESSORS
help
- This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
- If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
+ This selects the Marvell(R) MMP2 SD Host Controller.
+ If you have a MMP2 platform with SD Host Controller
and a card slot, say Y or M here.
If unsure, say N.
--
1.6.0.4
On Nov 22, 2010, at 6:55 PM, Chris Ball wrote:
> Hi,
>
> On Mon, Nov 22, 2010 at 09:46:14PM -0500, Mark F. Brown wrote:
>>> config MMC_SDHCI_PXA
>>> tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
>>> - depends on ARCH_PXA || ARCH_MMP
>>> + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
>>> select MMC_SDHCI
>>> select MMC_SDHCI_IO_ACCESSORS
>>> help
>>> - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
>>> - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
>>> + This selects the Marvell(R) MMP2 SD Host Controller.
>>> + If you have a MMP2 platform with SD Host Controller
>>> and a card slot, say Y or M here.
>>
>> Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
>> platform only. Until the sdhci-pxa code fixed or forked to support
>> pxa168 and pxa910 we need to Philip's patch. Any feedback on this
>> would be good thanks.
>
> I don't mind changing the Kconfig text, but tying an SoC-level host
> controller to dependencies on specific machines seems pretty wrong.
> We should ask Haojian and Eric what they think. I think Philip
> suggested using CPU_MMP2 at one point -- how about that?
>
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
> One Laptop Per Child
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 2:55 ` Chris Ball
2010-11-23 3:15 ` Philip Rakity
@ 2010-11-23 3:16 ` zhangfei gao
2010-11-23 3:22 ` Philip Rakity
1 sibling, 1 reply; 9+ messages in thread
From: zhangfei gao @ 2010-11-23 3:16 UTC (permalink / raw)
To: Chris Ball
Cc: Mark F. Brown, linux-mmc@vger.kernel.org, Philip Rakity, markb,
Haojian Zhuang, Eric Miao
On Mon, Nov 22, 2010 at 9:55 PM, Chris Ball <cjb@laptop.org> wrote:
> Hi,
>
> On Mon, Nov 22, 2010 at 09:46:14PM -0500, Mark F. Brown wrote:
>> > config MMC_SDHCI_PXA
>> > tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
>> > - depends on ARCH_PXA || ARCH_MMP
>> > + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
>> > select MMC_SDHCI
>> > select MMC_SDHCI_IO_ACCESSORS
>> > help
>> > - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
>> > - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
>> > + This selects the Marvell(R) MMP2 SD Host Controller.
>> > + If you have a MMP2 platform with SD Host Controller
>> > and a card slot, say Y or M here.
>>
>> Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
>> platform only. Until the sdhci-pxa code fixed or forked to support
>> pxa168 and pxa910 we need to Philip's patch. Any feedback on this
>> would be good thanks.
>
The patch "sdhci-pxa: init_sdh for different platform" already
submitted, to be merged.
The platfrom specific register accessing are move to arch
for mmp2, arch/arm/mach-mmp/include/mach/mmp2_sdh.h
for pxa168, another file may be needed
arch/arm/mach-mmp/include/mach/pxa168_sdh.h
> I don't mind changing the Kconfig text, but tying an SoC-level host
> controller to dependencies on specific machines seems pretty wrong.
> We should ask Haojian and Eric what they think. I think Philip
> suggested using CPU_MMP2 at one point -- how about that?
>
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
> One Laptop Per Child
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 3:16 ` zhangfei gao
@ 2010-11-23 3:22 ` Philip Rakity
2010-11-23 4:38 ` Mark F. Brown
2010-11-23 4:59 ` Haojian Zhuang
0 siblings, 2 replies; 9+ messages in thread
From: Philip Rakity @ 2010-11-23 3:22 UTC (permalink / raw)
To: zhangfei gao
Cc: Chris Ball, Mark F. Brown, linux-mmc@vger.kernel.org, Mark Brown,
Haojian Zhuang, Eric Miao
I implemented the first sdhci-pxa.c controller for the pxa168 over a year ago. Also fixed issues on Tavor.
This approach is not sufficient to make Aspen nor Tavor work.
There are a number of silicon issues that need to be addressed.
On Nov 22, 2010, at 7:16 PM, zhangfei gao wrote:
> On Mon, Nov 22, 2010 at 9:55 PM, Chris Ball <cjb@laptop.org> wrote:
>> Hi,
>>
>> On Mon, Nov 22, 2010 at 09:46:14PM -0500, Mark F. Brown wrote:
>>>> config MMC_SDHCI_PXA
>>>> tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
>>>> - depends on ARCH_PXA || ARCH_MMP
>>>> + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
>>>> select MMC_SDHCI
>>>> select MMC_SDHCI_IO_ACCESSORS
>>>> help
>>>> - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
>>>> - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
>>>> + This selects the Marvell(R) MMP2 SD Host Controller.
>>>> + If you have a MMP2 platform with SD Host Controller
>>>> and a card slot, say Y or M here.
>>>
>>> Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
>>> platform only. Until the sdhci-pxa code fixed or forked to support
>>> pxa168 and pxa910 we need to Philip's patch. Any feedback on this
>>> would be good thanks.
>>
> The patch "sdhci-pxa: init_sdh for different platform" already
> submitted, to be merged.
> The platfrom specific register accessing are move to arch
> for mmp2, arch/arm/mach-mmp/include/mach/mmp2_sdh.h
> for pxa168, another file may be needed
> arch/arm/mach-mmp/include/mach/pxa168_sdh.h
>
>> I don't mind changing the Kconfig text, but tying an SoC-level host
>> controller to dependencies on specific machines seems pretty wrong.
>> We should ask Haojian and Eric what they think. I think Philip
>> suggested using CPU_MMP2 at one point -- how about that?
>>
>> --
>> Chris Ball <cjb@laptop.org> <http://printf.net/>
>> One Laptop Per Child
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 3:22 ` Philip Rakity
@ 2010-11-23 4:38 ` Mark F. Brown
2010-11-23 4:59 ` Haojian Zhuang
1 sibling, 0 replies; 9+ messages in thread
From: Mark F. Brown @ 2010-11-23 4:38 UTC (permalink / raw)
To: Philip Rakity
Cc: zhangfei gao, Chris Ball, linux-mmc@vger.kernel.org, Mark Brown,
Haojian Zhuang, Eric Miao
On Mon, Nov 22, 2010 at 10:22 PM, Philip Rakity <prakity@marvell.com> wrote:
>
> I implemented the first sdhci-pxa.c controller for the pxa168 over a year ago. Also fixed issues on Tavor.
>
> This approach is not sufficient to make Aspen nor Tavor work.
>
> There are a number of silicon issues that need to be addressed.
>
>
>
>
> On Nov 22, 2010, at 7:16 PM, zhangfei gao wrote:
>
>> On Mon, Nov 22, 2010 at 9:55 PM, Chris Ball <cjb@laptop.org> wrote:
>>> Hi,
>>>
>>> On Mon, Nov 22, 2010 at 09:46:14PM -0500, Mark F. Brown wrote:
>>>>> config MMC_SDHCI_PXA
>>>>> tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support"
>>>>> - depends on ARCH_PXA || ARCH_MMP
>>>>> + depends on (ARCH_PXA || ARCH_MMP) && (MACH_MARVELL_JASPER || MACH_FLINT)
>>>>> select MMC_SDHCI
>>>>> select MMC_SDHCI_IO_ACCESSORS
>>>>> help
>>>>> - This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller.
>>>>> - If you have a PXA168/PXA910/MMP2 platform with SD Host Controller
>>>>> + This selects the Marvell(R) MMP2 SD Host Controller.
>>>>> + If you have a MMP2 platform with SD Host Controller
>>>>> and a card slot, say Y or M here.
>>>>
>>>> Currently the driver sdhci-pxa only supports the 88AP610 (MMP2)
>>>> platform only. Until the sdhci-pxa code fixed or forked to support
>>>> pxa168 and pxa910 we need to Philip's patch. Any feedback on this
>>>> would be good thanks.
>>>
>> The patch "sdhci-pxa: init_sdh for different platform" already
>> submitted, to be merged.
>> The platfrom specific register accessing are move to arch
>> for mmp2, arch/arm/mach-mmp/include/mach/mmp2_sdh.h
>> for pxa168, another file may be needed
>> arch/arm/mach-mmp/include/mach/pxa168_sdh.h
Zhangfei, I think Philip is correct here. You need to add support for
PXA168 and PXA910 before you declare support for it in the Kconfig.
When the proper accessors and support are added for those platforms
then you can add the Kconfig entries. If MMP2 is currently the only
supported platform, then we should just mention CPU_MMP2.
>>
>>> I don't mind changing the Kconfig text, but tying an SoC-level host
>>> controller to dependencies on specific machines seems pretty wrong.
>>> We should ask Haojian and Eric what they think. I think Philip
>>> suggested using CPU_MMP2 at one point -- how about that?
>>>
Chris I agree CPU_MMP2 is better here.
>>> --
>>> Chris Ball <cjb@laptop.org> <http://printf.net/>
>>> One Laptop Per Child
>>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 3:22 ` Philip Rakity
2010-11-23 4:38 ` Mark F. Brown
@ 2010-11-23 4:59 ` Haojian Zhuang
2010-11-23 5:16 ` Philip Rakity
1 sibling, 1 reply; 9+ messages in thread
From: Haojian Zhuang @ 2010-11-23 4:59 UTC (permalink / raw)
To: Philip Rakity
Cc: zhangfei gao, Chris Ball, Mark F. Brown,
linux-mmc@vger.kernel.org, Mark Brown, Eric Miao
On Tue, Nov 23, 2010 at 11:22 AM, Philip Rakity <prakity@marvell.com> wrote:
>
> I implemented the first sdhci-pxa.c controller for the pxa168 over a year ago. Also fixed issues on Tavor.
>
> This approach is not sufficient to make Aspen nor Tavor work.
>
> There are a number of silicon issues that need to be addressed.
>
>
>
>
But we're formating patches for these silicons. I prefer to push
patches for Aspen/Tavor rather than restricting on CPU_MMP2 now.
This driver is used to share among Aspen/Tavor/MMP2.
Thanks
Haojian
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig
2010-11-23 4:59 ` Haojian Zhuang
@ 2010-11-23 5:16 ` Philip Rakity
0 siblings, 0 replies; 9+ messages in thread
From: Philip Rakity @ 2010-11-23 5:16 UTC (permalink / raw)
To: Haojian Zhuang
Cc: zhangfei gao, Chris Ball, Mark F. Brown,
linux-mmc@vger.kernel.org, Mark Brown, Eric Miao
On Nov 22, 2010, at 8:59 PM, Haojian Zhuang wrote:
> On Tue, Nov 23, 2010 at 11:22 AM, Philip Rakity <prakity@marvell.com> wrote:
>>
>> I implemented the first sdhci-pxa.c controller for the pxa168 over a year ago. Also fixed issues on Tavor.
>>
>> This approach is not sufficient to make Aspen nor Tavor work.
>>
>> There are a number of silicon issues that need to be addressed.
>>
>>
>>
>>
> But we're formating patches for these silicons. I prefer to push
> patches for Aspen/Tavor rather than restricting on CPU_MMP2 now.
You can remove the CPU_MMP2 flag when that is done.
>
> This driver is used to share among Aspen/Tavor/MMP2.
Since Mark and I did the pxa168 mmc code we would prefer that you leave the patches for us.
Calling into the arch/ code for every platform does not seem the right way to go. It is probably simpler to factor out
any common code and define platform specific modules for mmp2/aspen/tavor. Once you start working around the
silicon issues calling into arch/ may not look like an approach that is easy to follow going forward.
>
> Thanks
> Haojian
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-11-23 5:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-18 2:56 [PATCH] sdhci: sdhci-pxa only supports mmp2 at this time. Change Kconfig Philip Rakity
2010-11-23 2:46 ` Mark F. Brown
2010-11-23 2:55 ` Chris Ball
2010-11-23 3:15 ` Philip Rakity
2010-11-23 3:16 ` zhangfei gao
2010-11-23 3:22 ` Philip Rakity
2010-11-23 4:38 ` Mark F. Brown
2010-11-23 4:59 ` Haojian Zhuang
2010-11-23 5:16 ` Philip Rakity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox