[PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

[PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

[H Hartley Sweeten]

Include the linux/mmc/cd-gpio.h header to pickup the prototypes
for the two exported symbols.

This quiets the sparse warnings:

warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

---

diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
index 29de31e..da7c3f9 100644
--- a/drivers/mmc/core/cd-gpio.c
+++ b/drivers/mmc/core/cd-gpio.c
@@ -13,6 +13,7 @@
 #include <linux/interrupt.h>
 #include <linux/jiffies.h>
 #include <linux/mmc/host.h>
+#include <linux/mmc/cd-gpio.h>
 #include <linux/module.h>
 #include <linux/slab.h>
 

Re: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

[Guennadi Liakhovetski]

Hi Hartley

Thanks for the patch.

On Mon, 16 Apr 2012, H Hartley Sweeten wrote:

> Include the linux/mmc/cd-gpio.h header to pickup the prototypes
> for the two exported symbols.
> 
> This quiets the sparse warnings:
> 
> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> 
> ---
> 
> diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
> index 29de31e..da7c3f9 100644
> --- a/drivers/mmc/core/cd-gpio.c
> +++ b/drivers/mmc/core/cd-gpio.c
> @@ -13,6 +13,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/jiffies.h>
>  #include <linux/mmc/host.h>
> +#include <linux/mmc/cd-gpio.h>

Call me a pettyfogger, but please put the header above mmc/host.h, please, 
keep the alphabetic order.

>  #include <linux/module.h>
>  #include <linux/slab.h>
>  

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

Re: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes

[S, Venkatraman]

On Tue, Apr 17, 2012 at 6:54 AM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> Include the linux/mmc/cd-gpio.h header to pickup the prototypes
> for the two exported symbols.
>
> This quiets the sparse warnings:
>
> warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
> warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
I posted a similar patch on friday. But yours has a more verbose commit log.
Acked-by: Venkatraman S <svenkatr@ti.com>

> ---
>
> diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
> index 29de31e..da7c3f9 100644
> --- a/drivers/mmc/core/cd-gpio.c
> +++ b/drivers/mmc/core/cd-gpio.c
> @@ -13,6 +13,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/jiffies.h>
>  #include <linux/mmc/host.h>
> +#include <linux/mmc/cd-gpio.h>
>  #include <linux/module.h>
>  #include <linux/slab.h>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html