From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Ball <cjb@laptop.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-mmc@vger.kernel.org, David Vrabel <david.vrabel@csr.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch -resend] mmc: ushc: fix an endianness conversion in ushc_request()
Date: Wed, 27 Jun 2012 12:02:58 +0300 [thread overview]
Message-ID: <20120627090258.GH31212@elgon.mountain> (raw)
In-Reply-To: <20120627085800.GA3007@mwanda>
The ->cmd_idx field is 8 bits, not 16 so the call to cpu_to_le16()
will probably set cmd_idx to zero here on big endian systems. My guess
is that this works because it has been tested on little endian systems
where the conversion to le16 is a nop.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I don't have a way to test this.
I have added a sentence to the changelog. I have added David Vrabel to
the CC list. This was originally sent to the mailing list on Mon, 21
Nov 2011 and there was no response.
diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index c0105a2..25932f5 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -278,7 +278,7 @@ static void ushc_request(struct mmc_host *mmc, struct mmc_request *req)
ushc->current_req = req;
/* Start cmd with CBW. */
- ushc->cbw->cmd_idx = cpu_to_le16(req->cmd->opcode);
+ ushc->cbw->cmd_idx = req->cmd->opcode;
if (req->data)
ushc->cbw->block_size = cpu_to_le16(req->data->blksz);
else
parent reply other threads:[~2012-06-27 9:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20120627085800.GA3007@mwanda>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120627090258.GH31212@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=cjb@laptop.org \
--cc=david.vrabel@csr.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox