* [patch -resend] mmc: ushc: fix an endianness conversion in ushc_request()
[not found] <20120627085800.GA3007@mwanda>
@ 2012-06-27 9:02 ` Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-06-27 9:02 UTC (permalink / raw)
To: Chris Ball
Cc: Greg Kroah-Hartman, linux-mmc, David Vrabel, linux-kernel,
kernel-janitors
The ->cmd_idx field is 8 bits, not 16 so the call to cpu_to_le16()
will probably set cmd_idx to zero here on big endian systems. My guess
is that this works because it has been tested on little endian systems
where the conversion to le16 is a nop.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I don't have a way to test this.
I have added a sentence to the changelog. I have added David Vrabel to
the CC list. This was originally sent to the mailing list on Mon, 21
Nov 2011 and there was no response.
diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index c0105a2..25932f5 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -278,7 +278,7 @@ static void ushc_request(struct mmc_host *mmc, struct mmc_request *req)
ushc->current_req = req;
/* Start cmd with CBW. */
- ushc->cbw->cmd_idx = cpu_to_le16(req->cmd->opcode);
+ ushc->cbw->cmd_idx = req->cmd->opcode;
if (req->data)
ushc->cbw->block_size = cpu_to_le16(req->data->blksz);
else
^ permalink raw reply related [flat|nested] only message in thread