From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Chris Ball <cjb@laptop.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdio: Fix PM_SLEEP related build warnings
Date: Thu, 9 Aug 2012 11:55:34 +0200 [thread overview]
Message-ID: <201208091155.34573.rjw@sisk.pl> (raw)
In-Reply-To: <20120809092756.GA1020@avionic-0098.mockup.avionic-design.de>
On Thursday, August 09, 2012, Thierry Reding wrote:
> On Thu, Aug 09, 2012 at 11:27:02AM +0200, Rafael J. Wysocki wrote:
> > On Thursday, August 09, 2012, Thierry Reding wrote:
> > > Power management callbacks defined by SIMPLE_DEV_PM_OPS are only used if
> > > the PM_SLEEP Kconfig symbol has been defined. If not, the compiler will
> > > complain about them being unused.
> > >
> > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> >
> > The pm_no_operation() thing is not necessary at all, AFAICT. I'd just
> > remove it entirely. :-)
>
> I don't actually have a setup where I can test suspend/resume with this
> driver, but if you say so I can follow up with a patch that removes
> pm_no_operation(). It should work because many drivers without proper
> PM_SLEEP support do not specify .suspend() nor .resume() callbacks
> either.
Sure, it should work.
Thanks,
Rafael
next prev parent reply other threads:[~2012-08-09 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 6:56 [PATCH] mmc: sdio: Fix PM_SLEEP related build warnings Thierry Reding
2012-08-09 9:27 ` Rafael J. Wysocki
2012-08-09 9:27 ` Thierry Reding
2012-08-09 9:55 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-09 9:32 Thierry Reding
2012-08-09 10:00 ` Rafael J. Wysocki
2012-09-17 7:35 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208091155.34573.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox