From: Dan Carpenter <dan.carpenter@oracle.com>
To: heiko@sntech.de
Cc: linux-mmc@vger.kernel.org
Subject: re: mmc: sdhci-s3c: fix missing clock for gpio card-detect
Date: Fri, 8 Nov 2013 13:04:27 +0300 [thread overview]
Message-ID: <20131108100427.GT27977@elgon.mountain> (raw)
Hello Heiko Stübner,
This is a semi-automatic email about new static checker warnings.
The patch fe007c02f965: "mmc: sdhci-s3c: fix missing clock for gpio
card-detect" from Nov 18, 2012, leads to the following Smatch
complaint:
drivers/mmc/host/sdhci-s3c.c:381 sdhci_s3c_notify_change()
warn: variable dereferenced before check 'host' (see line 377)
drivers/mmc/host/sdhci-s3c.c
376 #ifdef CONFIG_PM_RUNTIME
377 struct sdhci_s3c *sc = sdhci_priv(host);
^^^^^^^^^^^^^^^^
Dereference.
378 #endif
379 unsigned long flags;
380
381 if (host) {
^^^^^
Check.
382 spin_lock_irqsave(&host->lock, flags);
383 if (state) {
regards,
dan carpenter
reply other threads:[~2013-11-08 10:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108100427.GT27977@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=heiko@sntech.de \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox