public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
* re: mmc: sdhci-s3c: fix missing clock for gpio card-detect
@ 2013-11-08 10:04 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-11-08 10:04 UTC (permalink / raw)
  To: heiko; +Cc: linux-mmc

Hello Heiko Stübner,

This is a semi-automatic email about new static checker warnings.

The patch fe007c02f965: "mmc: sdhci-s3c: fix missing clock for gpio 
card-detect" from Nov 18, 2012, leads to the following Smatch 
complaint:

drivers/mmc/host/sdhci-s3c.c:381 sdhci_s3c_notify_change()
	 warn: variable dereferenced before check 'host' (see line 377)

drivers/mmc/host/sdhci-s3c.c
   376	#ifdef CONFIG_PM_RUNTIME
   377		struct sdhci_s3c *sc = sdhci_priv(host);
                                       ^^^^^^^^^^^^^^^^
Dereference.

   378	#endif
   379		unsigned long flags;
   380	
   381		if (host) {
                   ^^^^^
Check.

   382			spin_lock_irqsave(&host->lock, flags);
   383			if (state) {

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-11-08 10:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 10:04 mmc: sdhci-s3c: fix missing clock for gpio card-detect Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox