From: Lee Jones <lee.jones@linaro.org>
To: Roger <rogerable@realtek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wei WANG <wei_wang@realsil.com.cn>,
devel@linuxdriverproject.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] mmc: rtsx: usb backend needs LED support
Date: Thu, 8 May 2014 09:29:11 +0100 [thread overview]
Message-ID: <20140508082911.GA5767@lee--X1> (raw)
In-Reply-To: <536B3B6F.1010209@realtek.com>
> >>From: Roger Tseng <rogerable@realtek.com>
> >>Date: Wed, 30 Apr 2014 11:11:25 +0800
> >>Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in
> >>
> >>rtsx_usb_sdmmc module uses the LED classdev if available, but the code
> >>failed
> >>to consider the situation that it is built-in and the LED classdev is a
> >>module,
> >>leading to following linking error:
> >>
> >> LD init/built-in.o
> >>drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':
> >>rtsx_usb_sdmmc.c:(.text+0x2a018e): undefined reference to
> >>`led_classdev_unregister'
> >>drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_probe':
> >>rtsx_usb_sdmmc.c:(.text+0x2a197e): undefined reference to
> >>`led_classdev_register'
> >>
> >>Fix by excluding such condition when defining macro RTSX_USB_USE_LEDS_CLASS.
> >>
> >>Signed-off-by: Roger Tseng <rogerable@realtek.com>
> >
> >Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Would this patch be merged into linux-next or Lee's mfd.git
> ib-mfd-mmc-memstick-3.16 branch?
This patch doesn't have anything to do with MFD.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2014-05-08 8:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 1:54 [PATCH 0/2] mmc: rtsx: revert support for mmc async request micky_ching
2014-04-29 1:54 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch warnings" micky_ching
2014-04-29 7:30 ` Ulf Hansson
2014-05-08 5:49 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove " micky
2014-05-08 7:55 ` Lee Jones
2014-05-08 8:22 ` Ulf Hansson
2014-05-09 1:09 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings" micky
2014-04-29 1:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" micky_ching
2014-04-29 7:36 ` Ulf Hansson
2014-05-05 9:31 ` Ulf Hansson
2014-05-08 7:53 ` Lee Jones
2014-05-08 5:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req" micky
2014-04-29 8:02 ` [PATCH 0/2] mmc: rtsx: revert support for mmc async request Lee Jones
2014-04-30 1:32 ` micky
2014-04-29 9:45 ` [PATCH] mmc: rtsx: usb backend needs LED support Arnd Bergmann
2014-04-29 11:05 ` Ulf Hansson
2014-04-29 12:46 ` Arnd Bergmann
[not found] ` <201404300228.s3U2S7WA026782@rtits1.realtek.com>
2014-04-30 3:34 ` Roger
2014-04-30 7:00 ` Arnd Bergmann
2014-04-30 8:19 ` Ulf Hansson
2014-05-08 8:08 ` Roger
2014-05-08 8:25 ` Arnd Bergmann
2014-05-08 8:29 ` Lee Jones [this message]
2014-05-08 8:29 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508082911.GA5767@lee--X1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox