From: Wolfram Sang <wsa@the-dreams.de>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Cc: linux-mmc@vger.kernel.org,
Ian Molton <ian.molton@codethink.co.uk>,
Ulf Hansson <ulf.hansson@linaro.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] mmc: tmio: Fix timeout value for command request
Date: Mon, 15 Jun 2015 18:34:31 +0200 [thread overview]
Message-ID: <20150615163431.GA1583@katana> (raw)
In-Reply-To: <1434302606-31040-1-git-send-email-ykaneko0929@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
Hi,
> @@ -230,7 +230,7 @@ static void tmio_mmc_reset_work(struct work_struct *work)
> */
> if (IS_ERR_OR_NULL(mrq)
> || time_is_after_jiffies(host->last_req_ts +
> - msecs_to_jiffies(2000))) {
> + msecs_to_jiffies(5000))) {
> spin_unlock_irqrestore(&host->lock, flags);
> return;
> }
> @@ -818,7 +818,7 @@ static void tmio_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
> ret = tmio_mmc_start_command(host, mrq->cmd);
> if (!ret) {
> schedule_delayed_work(&host->delayed_reset_work,
> - msecs_to_jiffies(2000));
> + msecs_to_jiffies(5000));
What about using a define here since the same kind of magic value is
used in two different places?
Kind regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-15 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 17:23 [PATCH/RFC] mmc: tmio: Fix timeout value for command request Yoshihiro Kaneko
2015-06-15 5:49 ` Leon Romanovsky
2015-06-21 15:46 ` Yoshihiro Kaneko
2015-06-15 16:34 ` Wolfram Sang [this message]
2015-06-21 15:52 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615163431.GA1583@katana \
--to=wsa@the-dreams.de \
--cc=horms@verge.net.au \
--cc=ian.molton@codethink.co.uk \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox