From: Jean Delvare <jdelvare@suse.de>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, ulf.hansson@linaro.org,
Weijun.Yang@csr.com, sbranden@broadcom.com,
t.takinishi@jp.fujitsu.com, sboyd@codeaurora.org,
alim.akhtar@samsung.com, ludovic.desroches@atmel.com,
vincent.yang.fujitsu@gmail.com, chaotian.jing@mediatek.com,
linux@rainbow-software.org, yangbo.lu@freescale.com,
haokexin@gmail.com, linux-mmc@vger.kernel.org,
javier@osg.samsung.com
Subject: Re: [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST
Date: Tue, 13 Oct 2015 09:12:17 +0200 [thread overview]
Message-ID: <20151013091217.0cc0632d@endymion.delvare> (raw)
In-Reply-To: <1444493312-1592-1-git-send-email-luisbg@osg.samsung.com>
On Sat, 10 Oct 2015 17:08:32 +0100, Luis de Bethencourt wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to always be built when the
> COMPILE_TEST option is enabled.
>
> That way, the driver can be built with a config generated by make
> allyesconfig and check if a patch would break the build.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 12b274a..56f5b14 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,7 +473,7 @@ config MMC_DAVINCI
>
> config MMC_GOLDFISH
> tristate "goldfish qemu Multimedia Card Interface support"
> - depends on GOLDFISH
> + depends on GOLDFISH || COMPILE_TEST
> help
> This selects the Goldfish Multimedia card Interface emulation
> found on the Goldfish Android virtual device emulation.
Looks good.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-10-13 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 16:08 [PATCH] mmc: android-goldfish: Allow compiling the driver with COMPILE_TEST Luis de Bethencourt
2015-10-13 7:12 ` Jean Delvare [this message]
2015-10-16 8:25 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013091217.0cc0632d@endymion.delvare \
--to=jdelvare@suse.de \
--cc=Weijun.Yang@csr.com \
--cc=alim.akhtar@samsung.com \
--cc=chaotian.jing@mediatek.com \
--cc=haokexin@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=ludovic.desroches@atmel.com \
--cc=luisbg@osg.samsung.com \
--cc=sboyd@codeaurora.org \
--cc=sbranden@broadcom.com \
--cc=t.takinishi@jp.fujitsu.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.yang.fujitsu@gmail.com \
--cc=yangbo.lu@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox