From: Wei Yongjun <weiyj.lk@gmail.com>
To: Hu Ziji <huziji@marvell.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, linux-mmc@vger.kernel.org
Subject: [PATCH -next] mmc: sdhci-xenon: Remove redundant dev_err call in get_dt_pad_ctrl_data()
Date: Tue, 25 Apr 2017 06:34:46 +0000 [thread overview]
Message-ID: <20170425063446.32726-1-weiyj.lk@gmail.com> (raw)
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mmc/host/sdhci-xenon-phy.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c
index 4bdbcd3..d43841e 100644
--- a/drivers/mmc/host/sdhci-xenon-phy.c
+++ b/drivers/mmc/host/sdhci-xenon-phy.c
@@ -639,11 +639,8 @@ static int get_dt_pad_ctrl_data(struct sdhci_host *host,
params->pad_ctrl.reg = devm_ioremap_resource(mmc_dev(host->mmc),
&iomem);
- if (IS_ERR(params->pad_ctrl.reg)) {
- dev_err(mmc_dev(host->mmc), "Unable to get SoC PHY PAD ctrl register for %s\n",
- np->name);
+ if (IS_ERR(params->pad_ctrl.reg))
return PTR_ERR(params->pad_ctrl.reg);
- }
ret = of_property_read_string(np, "marvell,pad-type", &name);
if (ret) {
next reply other threads:[~2017-04-25 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 6:34 Wei Yongjun [this message]
2017-04-25 7:57 ` [PATCH -next] mmc: sdhci-xenon: Remove redundant dev_err call in get_dt_pad_ctrl_data() Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425063446.32726-1-weiyj.lk@gmail.com \
--to=weiyj.lk@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=huziji@marvell.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox