* [PATCH -next] mmc: sdhci-xenon: Remove redundant dev_err call in get_dt_pad_ctrl_data()
@ 2017-04-25 6:34 Wei Yongjun
2017-04-25 7:57 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-04-25 6:34 UTC (permalink / raw)
To: Hu Ziji, Adrian Hunter, Ulf Hansson; +Cc: Wei Yongjun, linux-mmc
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mmc/host/sdhci-xenon-phy.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c
index 4bdbcd3..d43841e 100644
--- a/drivers/mmc/host/sdhci-xenon-phy.c
+++ b/drivers/mmc/host/sdhci-xenon-phy.c
@@ -639,11 +639,8 @@ static int get_dt_pad_ctrl_data(struct sdhci_host *host,
params->pad_ctrl.reg = devm_ioremap_resource(mmc_dev(host->mmc),
&iomem);
- if (IS_ERR(params->pad_ctrl.reg)) {
- dev_err(mmc_dev(host->mmc), "Unable to get SoC PHY PAD ctrl register for %s\n",
- np->name);
+ if (IS_ERR(params->pad_ctrl.reg))
return PTR_ERR(params->pad_ctrl.reg);
- }
ret = of_property_read_string(np, "marvell,pad-type", &name);
if (ret) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] mmc: sdhci-xenon: Remove redundant dev_err call in get_dt_pad_ctrl_data()
2017-04-25 6:34 [PATCH -next] mmc: sdhci-xenon: Remove redundant dev_err call in get_dt_pad_ctrl_data() Wei Yongjun
@ 2017-04-25 7:57 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2017-04-25 7:57 UTC (permalink / raw)
To: Wei Yongjun
Cc: Hu Ziji, Adrian Hunter, Wei Yongjun, linux-mmc@vger.kernel.org
On 25 April 2017 at 08:34, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-xenon-phy.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-xenon-phy.c b/drivers/mmc/host/sdhci-xenon-phy.c
> index 4bdbcd3..d43841e 100644
> --- a/drivers/mmc/host/sdhci-xenon-phy.c
> +++ b/drivers/mmc/host/sdhci-xenon-phy.c
> @@ -639,11 +639,8 @@ static int get_dt_pad_ctrl_data(struct sdhci_host *host,
>
> params->pad_ctrl.reg = devm_ioremap_resource(mmc_dev(host->mmc),
> &iomem);
> - if (IS_ERR(params->pad_ctrl.reg)) {
> - dev_err(mmc_dev(host->mmc), "Unable to get SoC PHY PAD ctrl register for %s\n",
> - np->name);
> + if (IS_ERR(params->pad_ctrl.reg))
> return PTR_ERR(params->pad_ctrl.reg);
> - }
>
> ret = of_property_read_string(np, "marvell,pad-type", &name);
> if (ret) {
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-25 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 6:34 [PATCH -next] mmc: sdhci-xenon: Remove redundant dev_err call in get_dt_pad_ctrl_data() Wei Yongjun
2017-04-25 7:57 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox