* [RFT 1/2] mmc: renesas_sdhi: enably CBSY bit for RZ platform
2017-08-09 19:14 [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Wolfram Sang
@ 2017-08-09 19:14 ` Wolfram Sang
2017-08-09 19:14 ` [RFT 2/2] mmc: renesas_sdhi: document version of RZ/A1 instance Wolfram Sang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-09 19:14 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Chris Brandt, Wolfram Sang
It is documented, so enable it to follow the recommendation in the docs
and also save a few cycles.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 9b77f521cd2c2f..160fbb22ca00b4 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -33,7 +33,8 @@ static const struct renesas_sdhi_of_data of_default_cfg = {
};
static const struct renesas_sdhi_of_data of_rz_compatible = {
- .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_32BIT_DATA_PORT,
+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_32BIT_DATA_PORT |
+ TMIO_MMC_HAVE_CBSY,
.tmio_ocr_mask = MMC_VDD_32_33,
.capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
};
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RFT 2/2] mmc: renesas_sdhi: document version of RZ/A1 instance
2017-08-09 19:14 [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Wolfram Sang
2017-08-09 19:14 ` [RFT 1/2] mmc: renesas_sdhi: enably CBSY bit for RZ platform Wolfram Sang
@ 2017-08-09 19:14 ` Wolfram Sang
2017-08-10 12:59 ` [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Chris Brandt
2017-08-21 12:33 ` Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-09 19:14 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-renesas-soc, Chris Brandt, Wolfram Sang
We don't use this new define yet, but it is helpful to document which
versions we know of.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index e46504edc9fcb4..d0554088adfc41 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -40,6 +40,7 @@
#define EXT_ACC 0xe4
#define SDHI_VER_GEN2_SDR50 0x490c
+#define SDHI_VER_RZ_A1 0x820b
/* very old datasheets said 0x490c for SDR104, too. They are wrong! */
#define SDHI_VER_GEN2_SDR104 0xcb0d
#define SDHI_VER_GEN3_SD 0xcc10
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1
2017-08-09 19:14 [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Wolfram Sang
2017-08-09 19:14 ` [RFT 1/2] mmc: renesas_sdhi: enably CBSY bit for RZ platform Wolfram Sang
2017-08-09 19:14 ` [RFT 2/2] mmc: renesas_sdhi: document version of RZ/A1 instance Wolfram Sang
@ 2017-08-10 12:59 ` Chris Brandt
2017-08-11 8:47 ` Simon Horman
2017-08-21 12:33 ` Ulf Hansson
3 siblings, 1 reply; 6+ messages in thread
From: Chris Brandt @ 2017-08-10 12:59 UTC (permalink / raw)
To: Wolfram Sang, linux-mmc@vger.kernel.org; +Cc: linux-renesas-soc@vger.kernel.org
Hello Wolfram,
On Wednesday, August 09, 2017, Wolfram Sang wrote:
> Here is a small series to improve RZ support for SDHI. I don't have that
> platform currently, so I hope Chris has some time to check these simple
> patches. It is based on top of the patch just sent out:
> "[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"
I applied the 3 patches and tested with an SD Card. No issues.
Thank you for considering RZ!
Chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1
2017-08-10 12:59 ` [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Chris Brandt
@ 2017-08-11 8:47 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-08-11 8:47 UTC (permalink / raw)
To: Chris Brandt
Cc: Wolfram Sang, linux-mmc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
On Thu, Aug 10, 2017 at 12:59:05PM +0000, Chris Brandt wrote:
> Hello Wolfram,
>
>
> On Wednesday, August 09, 2017, Wolfram Sang wrote:
> > Here is a small series to improve RZ support for SDHI. I don't have that
> > platform currently, so I hope Chris has some time to check these simple
> > patches. It is based on top of the patch just sent out:
> > "[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"
>
>
> I applied the 3 patches and tested with an SD Card. No issues.
>
> Thank you for considering RZ!
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1
2017-08-09 19:14 [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Wolfram Sang
` (2 preceding siblings ...)
2017-08-10 12:59 ` [RFT 0/2] mmc: renesas_sdhi: small patches for RZ/A1 Chris Brandt
@ 2017-08-21 12:33 ` Ulf Hansson
3 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2017-08-21 12:33 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc@vger.kernel.org, Linux-Renesas, Chris Brandt
On 9 August 2017 at 21:14, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Here is a small series to improve RZ support for SDHI. I don't have that
> platform currently, so I hope Chris has some time to check these simple
> patches. It is based on top of the patch just sent out:
> "[PATCH] mmc: renesas_sdhi: use extra flag for CBSY usage"
>
> Regards,
>
> Wolfram
>
>
> Wolfram Sang (2):
> mmc: renesas_sdhi: enably CBSY bit for RZ platform
> mmc: renesas_sdhi: document version of RZ/A1 instance
>
> drivers/mmc/host/renesas_sdhi_core.c | 1 +
> drivers/mmc/host/renesas_sdhi_sys_dmac.c | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> --
Thanks, applied for next!
Adding tags from Simon and Chris.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread