* [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-03 14:49 ` Adrian Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Ulf Hansson, Adrian Hunter, Shawn Lin,
Faiz Abbas, Masahiro Yamada, Geert Uytterhoeven, Chunyan Zhang,
Jisheng Zhang, Ludovic Barre, Arnd Bergmann, Alex Smith,
Chris Brandt,
open list:MULTIMEDIA CARD MMC, SECURE DIGITAL SD AND...,
open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/mmc/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index e26b8145efb3..1b9401fe94c0 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -116,7 +116,7 @@ config MMC_RICOH_MMC
config MMC_SDHCI_ACPI
tristate "SDHCI support for ACPI enumerated SDHCI controllers"
- depends on MMC_SDHCI && ACPI
+ depends on MMC_SDHCI && ACPI && PCI
select IOSF_MBI if X86
help
This selects support for ACPI enumerated SDHCI controllers,
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit Sinan Kaya
@ 2019-01-03 14:49 ` Adrian Hunter
2019-01-03 14:57 ` Sinan Kaya
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Hunter @ 2019-01-03 14:49 UTC (permalink / raw)
To: Sinan Kaya, linux-next
Cc: linux-acpi, Ulf Hansson, Shawn Lin, Faiz Abbas, Masahiro Yamada,
Geert Uytterhoeven, Chunyan Zhang, Jisheng Zhang, Ludovic Barre,
Arnd Bergmann, Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list
On 2/01/19 8:10 PM, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
This driver does not rely on IOSF_MBI
You wrote on the other email QCOM doesn't use PCI but here you are making
them depend on it. Please explain.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/mmc/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e26b8145efb3..1b9401fe94c0 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
>
> config MMC_SDHCI_ACPI
> tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> - depends on MMC_SDHCI && ACPI
> + depends on MMC_SDHCI && ACPI && PCI
> select IOSF_MBI if X86
> help
> This selects support for ACPI enumerated SDHCI controllers,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit
2019-01-03 14:49 ` Adrian Hunter
@ 2019-01-03 14:57 ` Sinan Kaya
0 siblings, 0 replies; 3+ messages in thread
From: Sinan Kaya @ 2019-01-03 14:57 UTC (permalink / raw)
To: Adrian Hunter
Cc: Linux Next Mailing List, ACPI Devel Mailing List, Ulf Hansson,
Shawn Lin, Faiz Abbas, Masahiro Yamada, Geert Uytterhoeven,
Chunyan Zhang, Jisheng Zhang, Ludovic Barre, Arnd Bergmann,
Alex Smith, Chris Brandt,
open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND...,
open list
On Thu, Jan 3, 2019 at 2:50 PM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> On 2/01/19 8:10 PM, Sinan Kaya wrote:
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This driver relies on IOSF_MBI and IOSF_MBI depends
> > on PCI. For this reason, add a direct dependency to CONFIG_PCI here.
>
> This driver does not rely on IOSF_MBI
>
X86 version does.
select IOSF_MBI if X86
> You wrote on the other email QCOM doesn't use PCI but here you are making
> them depend on it. Please explain.
>
I matched the behavior before my change. This code wouldn't be
available without PCI and ACPI on previous kernel versions and left
kconfig cleanup as another exercise for some other day.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > drivers/mmc/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index e26b8145efb3..1b9401fe94c0 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -116,7 +116,7 @@ config MMC_RICOH_MMC
> >
> > config MMC_SDHCI_ACPI
> > tristate "SDHCI support for ACPI enumerated SDHCI controllers"
> > - depends on MMC_SDHCI && ACPI
> > + depends on MMC_SDHCI && ACPI && PCI
> > select IOSF_MBI if X86
> > help
> > This selects support for ACPI enumerated SDHCI controllers,
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-03 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190102181038.4418-1-okaya@kernel.org>
2019-01-02 18:10 ` [PATCH v5 09/11] mmc: sdhci-acpi: Make PCI dependency explicit Sinan Kaya
2019-01-03 14:49 ` Adrian Hunter
2019-01-03 14:57 ` Sinan Kaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox