* [PATCH] mmc: sdhci: Fix a potential uninitialized variable
@ 2020-07-14 14:14 Dan Carpenter
2020-08-05 6:35 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-07-14 14:14 UTC (permalink / raw)
To: Adrian Hunter
Cc: Ulf Hansson, Veerabhadrarao Badiganti, linux-mmc, kernel-janitors
Smatch complains that "ret" can be used without being initialized.
drivers/mmc/host/sdhci.c
4383 if (!IS_ERR(mmc->supply.vqmmc)) {
4384 if (enable_vqmmc) {
^^^^^^^^^^^^
4385 ret = regulator_enable(mmc->supply.vqmmc);
^^^^^
4386 host->sdhci_core_to_disable_vqmmc = !ret;
4387 }
"ret" is only initialized when "enable_vqmmc" is true.
Fixes: b13099a4dea6 ("mmc: sdhci: Fix potential null pointer access while accessing vqmmc")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/mmc/host/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 8db06da55602..3ad394b40eb1 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -4104,7 +4104,7 @@ int sdhci_setup_host(struct sdhci_host *host)
unsigned int ocr_avail;
unsigned int override_timeout_clk;
u32 max_clk;
- int ret;
+ int ret = 0;
bool enable_vqmmc = false;
WARN_ON(host == NULL);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: sdhci: Fix a potential uninitialized variable
2020-07-14 14:14 [PATCH] mmc: sdhci: Fix a potential uninitialized variable Dan Carpenter
@ 2020-08-05 6:35 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2020-08-05 6:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Adrian Hunter, Veerabhadrarao Badiganti,
linux-mmc@vger.kernel.org, kernel-janitors
On Tue, 14 Jul 2020 at 16:14, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Smatch complains that "ret" can be used without being initialized.
>
> drivers/mmc/host/sdhci.c
> 4383 if (!IS_ERR(mmc->supply.vqmmc)) {
> 4384 if (enable_vqmmc) {
> ^^^^^^^^^^^^
> 4385 ret = regulator_enable(mmc->supply.vqmmc);
> ^^^^^
> 4386 host->sdhci_core_to_disable_vqmmc = !ret;
> 4387 }
>
> "ret" is only initialized when "enable_vqmmc" is true.
>
> Fixes: b13099a4dea6 ("mmc: sdhci: Fix potential null pointer access while accessing vqmmc")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied for next (a while ago), thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 8db06da55602..3ad394b40eb1 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4104,7 +4104,7 @@ int sdhci_setup_host(struct sdhci_host *host)
> unsigned int ocr_avail;
> unsigned int override_timeout_clk;
> u32 max_clk;
> - int ret;
> + int ret = 0;
> bool enable_vqmmc = false;
>
> WARN_ON(host == NULL);
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-05 6:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-14 14:14 [PATCH] mmc: sdhci: Fix a potential uninitialized variable Dan Carpenter
2020-08-05 6:35 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox