From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [RFT] mmc: tmio: reset device on timeout, too
Date: Sun, 30 Aug 2020 15:03:57 +0200 [thread overview]
Message-ID: <20200830130357.GA2194@kunai> (raw)
In-Reply-To: <CAPDyKFp7rsHDY2vREakrR+PFJLs0n8JBR+URV1vCu5bydEhHuA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
> This isn't how mmc_hw_reset() is intended to be used. Instead, the
> idea is that it should be called by upper layer code, when some error
> path is triggered for an I/O request.
Hmm, there are some wireless drivers using it as well. I am confused, is
this considered "upper layer"?
drivers/net/wireless/ath/ath10k/sdio.c: ret = mmc_hw_reset(ar_sdio->func->card->host);
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c: mmc_hw_reset(sdiodev->func1->card->host);
drivers/net/wireless/marvell/mwifiex/sdio.c: ret = mmc_hw_reset(func->card->host);
drivers/net/wireless/ti/wlcore/sdio.c: mmc_hw_reset(card->host);
I'd like to understand, so I can add some docs. Because the intended use
is nowhere documented to the best of my knowledge.
> However, let me think a bit about this.
Sure, thanks for the help!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-30 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 8:16 [RFT] mmc: tmio: reset device on timeout, too Wolfram Sang
2020-08-28 12:18 ` Yoshihiro Shimoda
2020-08-28 12:35 ` Ulf Hansson
2020-08-30 13:03 ` Wolfram Sang [this message]
2020-09-09 11:24 ` Ulf Hansson
2020-09-09 11:37 ` Wolfram Sang
2020-09-09 12:45 ` Ulf Hansson
2020-09-15 10:05 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830130357.GA2194@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox