From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux MMC List <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [RFC PATCH v2 2/2] mmc: renesas_sdhi: do hard reset if possible
Date: Tue, 23 Feb 2021 11:17:09 +0100 [thread overview]
Message-ID: <20210223101709.GA2486@ninjato> (raw)
In-Reply-To: <CAMuHMdVFuof3C7JPw9BLUM0vBaiD+ZpUX2nSf8hiAZ4qw9doSQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hi Geert,
> "if (priv->rstc)" if the reset is made optional.
Yes, that would be better.
> > + priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
>
> devm_reset_control_get_optional_exclusive()?
> + missing error handling (real errors and -EPROBE_DEFER).
OK.
> Perhaps you want to add a "select RESET_CONTROLLER" to "config
> MMC_SDHI"?
Isn't "select" too strong for an optional feature? I'd think so.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-23 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 11:39 [RFC PATCH v2 0/2] mmc: renesas_sdhi: reset via reset controller Wolfram Sang
2021-02-22 11:39 ` [RFC PATCH v2 1/2] mmc: tmio: abort DMA before reset Wolfram Sang
2021-02-22 11:39 ` [RFC PATCH v2 2/2] mmc: renesas_sdhi: do hard reset if possible Wolfram Sang
2021-02-23 10:06 ` Geert Uytterhoeven
2021-02-23 10:17 ` Wolfram Sang [this message]
2021-02-23 10:20 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223101709.GA2486@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox